Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2022-01-03 | Update copyright years. | Jakub Jelinek | 1 | -1/+1 | |
2021-10-15 | openmp: Fix up strtoul and strtoull uses in libgomp | Jakub Jelinek | 1 | -4/+7 | |
Yesterday when working on numa_domains, I've noticed because of a bug in my patch a hang on a large NUMA machine. I've fixed the bug, but also discovered that the hang was a result of making wrong assumptions about strtoul/strtoull. All the uses were for portability setting errno = 0 before the calls and treating non-zero errno after the call as invalid input, but for the case where there are no valid digits at all strtoul may set errno to EINVAL, but doesn't have to and with glibc doesn't do that. So, this patch goes through all the strtoul calls and next to errno != 0 checks adds also endptr == startptr check. Haven't done it in places where we immediately reject strtoul returning 0 the same as we reject errno != 0, because strtoul must return 0 in the case where it sets endptr to the start pointer. In some spots the code was using errno = 0; x = strtoul (p, &p, 10); if (errno) { /*invalid*/ } and those spots had to be changed to errno = 0; x = strtoul (p, &end, 10); if (errno || end == p) { /*invalid*/ } p = end; 2021-10-15 Jakub Jelinek <jakub@redhat.com> * env.c (parse_schedule): For strtoul or strtoull calls which don't clearly reject return value 0 as invalid handle the case where end pointer is the same as first argument as invalid. (parse_unsigned_long_1): Likewise. (parse_one_place): Likewise. (parse_places_var): Likewise. (parse_stacksize): Likewise. (parse_spincount): Likewise. (parse_affinity): Likewise. (parse_gomp_openacc_dim): Likewise. Avoid strict aliasing violation. Make code valid C89. * config/linux/affinity.c (gomp_affinity_find_last_cache_level): For strtoul calls which don't clearly reject return value 0 as invalid handle the case where end pointer is the same as first argument as invalid. (gomp_affinity_init_level_1): Likewise. (gomp_affinity_init_numa_domains): Likewise. * config/rtems/proc.c (parse_thread_pools): Likewise. | |||||
2021-01-04 | Update copyright years. | Jakub Jelinek | 1 | -1/+1 | |
2020-01-01 | Update copyright years. | Jakub Jelinek | 1 | -1/+1 | |
From-SVN: r279813 | |||||
2019-01-01 | Update copyright years. | Jakub Jelinek | 1 | -1/+1 | |
From-SVN: r267494 | |||||
2018-01-03 | Update copyright years. | Jakub Jelinek | 1 | -1/+1 | |
From-SVN: r256169 | |||||
2017-01-01 | Update copyright years. | Jakub Jelinek | 1 | -1/+1 | |
From-SVN: r243994 | |||||
2016-12-02 | [RTEMS] Use spin lock for pool management | Sebastian Huber | 1 | -1/+1 | |
libgomp/ * libgomp/config/rtems/pool.h (gomp_thread_pool_reservoir): Use pthread_spinlock_t instead of gomp_mutex_t lock. (gomp_get_thread_pool): Likewise. (gomp_release_thread_pool): Likewise. * libgomp/config/rtems/proc.c (allocate_thread_pool_reservoir): Likewise. From-SVN: r243181 | |||||
2016-01-04 | Update copyright years. | Jakub Jelinek | 1 | -1/+1 | |
From-SVN: r232055 | |||||
2015-09-03 | [gomp] Add thread attribute customization | Sebastian Huber | 1 | -4/+19 | |
libgomp/ChangeLog * config/posix/pool.h (gomp_adjust_thread_attr): New. * config/rtems/pool.h (gomp_adjust_thread_attr): Likewise. (gomp_thread_pool_reservoir): Add priority member. * confi/rtems/proc.c (allocate_thread_pool_reservoir): Add priority. (parse_thread_pools): Likewise. * team.c (gomp_team_start): Call configuration provided gomp_adjust_thread_attr(). Destroy thread attributes if necessary. * libgomp.texi: Document GOMP_RTEMS_THREAD_POOLS. From-SVN: r227442 | |||||
2015-09-03 | [gomp] Thread pool management | Sebastian Huber | 1 | -0/+145 | |
libgomp/ChangeLog * config/posix/pool.h: New. * config/rtems/pool.h: Likewise. * config/rtems/proc.c: Likewise. * libgomp.h (gomp_thread_destructor): Declare. * team.c: Include configuration provided "pool.h". (gomp_get_thread_pool): Define in configuration. (gomp_team_end): Call configuration defined gomp_release_thread_pool(). From-SVN: r227441 |