aboutsummaryrefslogtreecommitdiff
path: root/gcc
AgeCommit message (Collapse)AuthorFilesLines
2020-12-17[Ada] Prevent early exits without restoring a global variablePiotr Trojanek1-2/+3
gcc/ada/ * sem_ch5.adb (Analyze_Case_Statement): Move modification of Unblocked_Exit_Count after early return statements; fix typo in comment.
2020-12-17[Ada] Reduce scopes of local variables for case and if statementsPiotr Trojanek1-16/+17
gcc/ada/ * sem_ch5.adb (Analyze_Case_Statement): Change local variable Exp to constant; remove unreferenced Last_Choice variable; reduce scope of other variables. (Analyze_If_Statement): Reduce scope of a local variable; add comment.
2020-12-17[Ada] Refine type of a multi unit index numberPiotr Trojanek1-1/+1
gcc/ada/ * opt.ads (Multiple_Unit_Index): Refine type from Int to Nat.
2020-12-17[Ada] Prevent In_Check_Node routine from going too far in the parent chainPiotr Trojanek1-5/+11
gcc/ada/ * sem_util.adb (In_Check_Node): Add guard and rename Node to Par, just like it is done in surrounding routines, e.g. In_Assertion_Expression_Pragma and In_Generic_Formal_Package.
2020-12-17[Ada] Ada2020: AI12-0400 Ambiguities associated with VectorBob Duff12-169/+261
gcc/ada/ * libgnat/a-cbdlli.adb, libgnat/a-cbdlli.ads, libgnat/a-cdlili.adb, libgnat/a-cdlili.ads, libgnat/a-cidlli.adb, libgnat/a-cidlli.ads, libgnat/a-cobove.adb, libgnat/a-cobove.ads, libgnat/a-coinve.adb, libgnat/a-coinve.ads, libgnat/a-convec.adb, libgnat/a-convec.ads: Add *_Vector operations, remove default for Count, rename Append_One to be Append.
2020-12-17[Ada] Crash on if expression inside declare expressionArnaud Charlet3-11/+32
gcc/ada/ * sem_res.adb (Resolve_Declare_Expression): Need to establish a transient scope in case Expression (N) requires actions to be wrapped. Code cleanup. * exp_ch7.adb, exp_ch11.adb: Code cleanup.
2020-12-17[Ada] Consistent wording for missing -gnat2020 switchPiotr Trojanek6-35/+18
gcc/ada/ * par-ch3.adb (P_Identifier_Declarations): Reuse Error_Msg_Ada_2020_Feature for object renaming without subtype. * par-ch4.adb (P_Primary): Likewise for target name. (P_Iterated_Component_Association): Likewise for iterated component. (P_Declare_Expression): Likewise for declare expression. * par-ch6.adb (P_Formal_Part): Likewise for aspect on formal parameter. * sem_aggr.adb (Resolve_Delta_Aggregate): Ditto. * sem_ch8.adb (Analyze_Object_Renaming): Reuse Error_Msg_Ada_2020_Feature. * sem_ch13.adb (Validate_Aspect_Aggregate): Reuse Error_Msg_Ada_2020_Feature; use lower case for "aspect" and don't use underscore for "Ada_2020"; don't give up on analysis in Ada 2012 mode. (Validate_Aspect_Stable_Properties): Reuse Error_Msg_Ada_2020_Feature; use lower case for "aspect"; minor style fixes.
2020-12-17[Ada] Remove discriminant checks processing in gigiArnaud Charlet12-121/+353
gcc/ada/ * sem_ch4.adb (Analyze_Selected_Component): Request a compile time error replacement in Apply_Compile_Time_Constraint_Error in case of an invalid field. * sem_ch3.adb (Create_Constrained_Components): Take advantage of Gather_Components also in the case of a record extension and also constrain records in the case of compile time known discriminant values, as already done in gigi. * sem_util.ads, sem_util.adb (Gather_Components): New parameter Allow_Compile_Time to allow compile time known (but non static) discriminant values, needed by Create_Constrained_Components, and new parameter Include_Interface_Tag. (Is_Dependent_Component_Of_Mutable_Object): Use Original_Node to perform check on the original tree. (Is_Object_Reference): Likewise. Only call Original_Node when relevant via a new function Safe_Prefix. (Is_Static_Discriminant_Component, In_Check_Node): New. (Is_Actual_Out_Or_In_Out_Parameter): New. * exp_ch4.adb (Expand_N_Selected_Component): Remove no longer needed code preventing evaluating statically discriminants in more cases. * exp_ch5.adb (Expand_N_Loop_Statement): Simplify expansion of loops with an N_Raise_xxx_Error node to avoid confusing the code generator. (Make_Component_List_Assign): Try to find a constrained type to extract discriminant values from, so that the case statement built gets an opportunity to be folded by Expand_N_Case_Statement. (Expand_Assign_Record): Update comments, code cleanups. * sem_attr.adb (Analyze_Attribute): Perform most of the analysis on the original prefix node to deal properly with a prefix rewritten as a N_Raise_xxx_Error. * sem_ch5.adb (Analyze_Loop_Parameter_Specification): Handle properly a discrete subtype definition being rewritten as N_Raise_xxx_Error. * sem_ch8.adb (Analyze_Object_Renaming): Handle N_Raise_xxx_Error nodes as part of the expression being renamed. * sem_eval.ads, sem_eval.adb (Fold, Eval_Selected_Component): New. (Compile_Time_Known_Value, Expr_Value, Expr_Rep_Value): Evaluate static discriminant component values. * sem_res.adb (Resolve_Selected_Component): Call Eval_Selected_Component.
2020-12-17[Ada] Move folding of unchecked conversions from expansion to evaluationPiotr Trojanek3-59/+57
gcc/ada/ * exp_ch4.adb (Expand_N_Unchecked_Type_Conversion): Remove folding of discrete values. * exp_intr.adb (Expand_Unc_Conversion): Analyze, resolve and evaluate (if possible) calls to instances of Ada.Unchecked_Conversion after they have been expanded into N_Unchecked_Type_Conversion. * sem_eval.adb (Eval_Unchecked_Conversion): Add folding of discrete values.
2020-12-17[Ada] Do not use exponentiation for common bases in floating-point ValueEric Botcazou15-73/+653
gcc/ada/ * Makefile.rtl (GNATRTL_NONTASKING_OBJS): Likewise. * exp_imgv.adb (Expand_Value_Attribute): Use RE_Value_Long_Float in lieu of RE_Value_Long_Long_Float as fallback for fixed-point types. Also use it for Long_Long_Float if it has same size as Long_Float. * libgnat/s-imgrea.adb: Replace Powten_Table with Powen_LLF. * libgnat/s-powflt.ads: New file. * libgnat/s-powlfl.ads: Likewise. * libgnat/s-powtab.ads: Rename to... * libgnat/s-powllf.ads: ...this. * libgnat/s-valflt.ads: Add with clause for System.Powten_Flt and pass its table as actual parameter to System.Val_Real. * libgnat/s-vallfl.ads: Likewise for System.Powten_LFlt. * libgnat/s-valllf.ads: Likewise for System.Powten_LLF. * libgnat/s-valrea.ads: Add Maxpow and Powten_Address parameters. * libgnat/s-valrea.adb: Add pragma Warnings (Off). (Need_Extra): New boolean constant. (Precision_Limit): Set it according to Need_Extra. (Impl): Adjust actual parameter. (Integer_to_Rea): Add assertion on the machine radix. Take into account the extra digit only if Need_Extra is true. Reimplement the computation of the final value for bases 2, 4, 8, 10 and 16. * libgnat/s-valued.adb (Impl): Adjust actual parameter. (Scan_Decimal): Add pragma Unreferenced. (Value_Decimal): Likewise. * libgnat/s-valuef.adb (Impl): Adjust actual parameter. * libgnat/s-valuer.ads (Floating): Remove. (Round): New formal parameter. * libgnat/s-valuer.adb (Round_Extra): New procedure. (Scan_Decimal_Digits): Use it to round the extra digit if Round is set to True in the instantiation. (Scan_Integral_Digits): Likewise.
2020-12-17[Ada] Fix small typo in comments.Erwan Le Guillou2-2/+2
gcc/ada/ * libgnat/system-lynxos178-ppc.ads, libgnat/system-lynxos178-x86.ads: Fix small typo in comments.
2020-12-17[Ada] Do not generate encodings for fixed-point types by defaultEric Botcazou1-1/+1
gcc/ada/ * exp_dbug.adb (Get_Encoded_Name): Generate encodings for fixed point types only if -fgnat-encodings=all is specified.
2020-12-17[Ada] Crash on discriminant check with current instanceJustin Squirek1-0/+34
gcc/ada/ * checks.adb (Build_Discriminant_Checks): Add condition to replace references to the current instance of the type when we are within an Init_Proc. (Replace_Current_Instance): Examine a given node and replace the current instance of the type with the corresponding _init formal. (Search_And_Replace_Current_Instance): Traverse proc which calls Replace_Current_Instance in order to replace all references within a given expression.
2020-12-17[Ada] Better diagnostic for new language featuresPiotr Trojanek3-24/+19
gcc/ada/ * par-ch12.adb (P_Formal_Derived_Type_Definition): Complain about formal type with aspect specification, which only become legal in Ada 2020. * par-ch9.adb (P_Protected_Operation_Declaration_Opt): Reuse Error_Msg_Ada_2005_Extension. (P_Entry_Declaration): Likewise. * scng.adb (Scan): Improve diagnostics for target_name; emit error, but otherwise continue in earlier than Ada 2020 modes.
2020-12-17[Ada] Spurious discriminant check on bounded synchronized queueEd Schonberg1-1/+9
gcc/ada/ * libgnat/a-cbsyqu.ads (Implementation): Provide a box initialization for the element array used internally to represent the queue, so that its components are properly initialized if the given element type has default initialization. Suppress warnings on the rest of the package in case the element type has no default or discriminant, because it is bound to be confusing to the user.
2020-12-17[Ada] Assert failure on b38105a in -gnat95 modeArnaud Charlet1-1/+3
gcc/ada/ * sem_util.adb (Inherit_Predicate_Flags): No-op before Ada 2012.
2020-12-17[Ada] Compiler crash on protected component of controlled typeArnaud Charlet2-3/+24
gcc/ada/ * exp_ch7.adb (Make_Final_Call, Make_Init_Call): Take protected types into account. * sem_util.ads: Fix typo.
2020-12-17[Ada] Fixes for GNAT error/warning messagesYannick Moy27-125/+132
gcc/ada/ * checks.adb: Rework error messages. * exp_ch3.adb: Likewise. * freeze.adb: Likewise. * lib-load.adb: Likewise. * par-ch12.adb: Likewise. * par-ch3.adb: Likewise. * par-ch4.adb: Likewise. * par-ch9.adb: Likewise. * sem_aggr.adb: Likewise. * sem_attr.adb: Likewise. * sem_cat.adb: Likewise. * sem_ch10.adb: Likewise. * sem_ch12.adb: Likewise. (Instantiate_Type): Fix CODEFIX comment, applicable only on continuation message, and identify the second message as a continuation. * sem_ch13.adb: Rework error messages. * sem_ch3.adb: Likewise. * sem_ch4.adb: Likewise. * sem_ch5.adb: Likewise. * sem_ch6.adb: Likewise. * sem_ch8.adb: Likewise. * sem_ch9.adb: Likewise. * sem_prag.adb: Likewise. * sem_res.adb: Likewise. * sem_util.adb: Likewise. (Wrong_Type): Fix CODEFIX comment, applicable only on continuation message, and identify the second message as a continuation. * symbols.adb: Rework error messages. gcc/testsuite/ * gnat.dg/interface6.adb, gnat.dg/not_null.adb, gnat.dg/protected_func.adb: Adjust error messages.
2020-12-17[Ada] Spurious error on Type'Access and <>Arnaud Charlet1-3/+8
gcc/ada/ * sem_attr.adb (OK_Self_Reference): Return True if node does not come from source (e.g. a rewritten aggregate).
2020-12-17[Ada] Style cleanups in Parse_Aspect_Stable_PropertiesPiotr Trojanek1-8/+20
gcc/ada/ * sem_ch13.adb (Parse_Aspect_Stable_Properties): Fix style; limit the scope of local variables; remove extra assignment in Extract_Entity. (Validate_Aspect_Stable_Properties): Simplify with procedural Next.
2020-12-17IBM Z: Detect libc's float_t behavior on cross compilesMarius Hillenbrand3-41/+85
When cross-compiling GCC with target libc headers available and configure option --enable-s390-excess-float-precision has been omitted, identify whether they clamp float_t to double or respect __FLT_EVAL_METHOD__ via a compile test that coerces the build-system compiler to use the target headers. Then derive the setting from that. gcc/ChangeLog: 2020-12-16 Marius Hillenbrand <mhillen@linux.ibm.com> * configure.ac: Change --enable-s390-excess-float-precision default behavior for cross compiles with target headers. * configure: Regenerate. * doc/install.texi: Adjust documentation.
2020-12-17Fortran: Delay vtab generation until after parsing [PR92587]Tobias Burnus3-3/+83
gcc/fortran/ChangeLog: PR fortran/92587 * match.c (gfc_match_assignment): Move gfc_find_vtab call from here ... * resolve.c (gfc_resolve_code): ... to here. gcc/testsuite/ChangeLog: PR fortran/92587 * gfortran.dg/finalize_37.f90: New test.
2020-12-17PR fortran/98307 - Dependency check fails when using "allocatable"Harald Anlauf2-2/+35
The dependency check for FORALL constructs already handled pointer components to derived types, but missed allocatables. Fix that. gcc/fortran/ChangeLog: PR fortran/98307 * trans-stmt.c (check_forall_dependencies): Extend dependency check to allocatable components of derived types. gcc/testsuite/ChangeLog: PR fortran/98307 * gfortran.dg/forall_19.f90: New test.
2020-12-16test: add new Go tests from source repoIan Lance Taylor505-0/+13602
2020-12-16test: add new Go tests from source repoIan Lance Taylor274-0/+7480
2020-12-16gcc: xtensa: add optimizations for shift operationsTakayuki 'January June' Suwa2-0/+74
2020-12-16 Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp> gcc/ * config/xtensa/xtensa.md (*ashlsi3_1, *ashlsi3_3x, *ashrsi3_3x) (*lshrsi3_3x): New patterns. gcc/testsuite/ * gcc.target/xtensa/shifts.c: New test.
2020-12-17Daily bump.GCC Administrator10-1/+683
2020-12-17fwprop: Rewrite to use RTL SSARichard Sandiford4-1155/+548
This patch rewrites fwprop.c to use the RTL SSA framework. It tries as far as possible to mimic the old behaviour, even in caes where that doesn't fit naturally with the new framework. I've added ??? comments to mark those places, but I think “fixing” them should be done separately to make bisection easier. In particular: * The old implementation iterated over uses, and after a successful substitution, the new insn's uses were added to the end of the list. The pass still processed those uses, but because it processed them at the end, it didn't fully optimise one instruction before propagating it into the next. The new version follows the same approach for comparison purposes, but I'd like to drop that as a follow-on patch. * The old implementation operated on single use sites (DF_REF_LOCs). This doesn't work well for instructions with match_dups, where it's necessary to update both an operand and its dups at the same time. For example, attempting to substitute into a divmod instruction would fail because only the div or the mod side would be updated. The new version again follows this to some extent for comparison purposes (although not exactly). Again I'd like to drop it as a follow-on patch. One difference is that if a register occurs in multiple MEM addresses in a set, the new version will try to update them all at once. This is what causes the SVE ACLE st4* output to improve. Also, the old version didn't naturally guarantee termination (PR79405), whereas the new one does. gcc/ * fwprop.c: Rewrite to use the RTL SSA framework. gcc/testsuite/ * gcc.dg/rtl/x86_64/test-return-const.c.before-fwprop.c: Don't expect insn updates to be deferred. * gcc.target/aarch64/sve/acle/asm/st4_s8.c: Expect the addition to be folded into the address. * gcc.target/aarch64/sve/acle/asm/st4_u8.c: Likewise.
2020-12-17Add rtl-ssaRichard Sandiford23-2/+10061
This patch adds the RTL SSA infrastructure itself. The following fwprop.c patch will make use of it. gcc/ * configure.ac: Add rtl-ssa to the list of dependence directories. * configure: Regenerate. * Makefile.in (rtl-ssa-warn): New variable. (OBJS): Add the rtl-ssa object files. * emit-rtl.h (rtl_data::ssa): New field. * rtl-ssa.h: New file. * system.h: Include <functional> when INCLUDE_FUNCTIONAL is defined. * rtl-ssa/access-utils.h: Likewise. * rtl-ssa/accesses.h: New file. * rtl-ssa/accesses.cc: Likewise. * rtl-ssa/blocks.h: New file. * rtl-ssa/blocks.cc: Likewise. * rtl-ssa/change-utils.h: Likewise. * rtl-ssa/changes.h: New file. * rtl-ssa/changes.cc: Likewise. * rtl-ssa/functions.h: New file. * rtl-ssa/functions.cc: Likewise. * rtl-ssa/insn-utils.h: Likewise. * rtl-ssa/insns.h: New file. * rtl-ssa/insns.cc: Likewise. * rtl-ssa/internals.inl: Likewise. * rtl-ssa/is-a.inl: Likewise. * rtl-ssa/member-fns.inl: Likewise. * rtl-ssa/movement.h: Likewise.
2020-12-17doc: Add documentation for rtl-ssaRichard Sandiford1-0/+787
This patch adds some documentation to rtl.texi about the SSA form. It only really describes the high-level structure -- I think for API-level stuff it's better to rely on function comments instead. gcc/ * doc/rtl.texi (RTL SSA): New node.
2020-12-17rtlanal: Add simple_regno_setRichard Sandiford2-0/+34
This patch adds a routine for finding a “simple” SET for a register definition. See the comment in the patch for details. gcc/ * rtl.h (simple_regno_set): Declare. * rtlanal.c (simple_regno_set): New function.
2020-12-17rtlanal: Add some new helper classesRichard Sandiford2-0/+616
This patch adds some classes for gathering the list of registers and memory that are read and written by an instruction, along with various properties about the accesses. In some ways it's similar to the information that DF collects for registers, but extended to memory. The main reason for using it instead of DF is that it can analyse tentative changes to instructions before they've been committed. The classes also collect general information about the instruction, since it's cheap to do and helps to avoid multiple walks of the same RTL pattern. I've tried to optimise the code quite a bit, since with later patches it becomes relatively performance-sensitive. See the discussion in the comments for the trade-offs involved. I put the declarations in a new rtlanal.h header file since it seemed a bit excessive to put so much new inline stuff in rtl.h. gcc/ * rtlanal.h: New file. (MEM_REGNO): New constant. (rtx_obj_flags): New namespace. (rtx_obj_reference, rtx_properties): New classes. (growing_rtx_properties, vec_rtx_properties_base): Likewise. (vec_rtx_properties): New alias. * rtlanal.c: Include it. (rtx_properties::try_to_add_reg): New function. (rtx_properties::try_to_add_dest): Likewise. (rtx_properties::try_to_add_src): Likewise. (rtx_properties::try_to_add_pattern): Likewise. (rtx_properties::try_to_add_insn): Likewise. (vec_rtx_properties_base::grow): Likewise.
2020-12-17recog: Add an RAII class for undoing insn changesRichard Sandiford1-0/+51
When using validate_change to make a group of changes, you have to remember to cancel them if something goes wrong. This patch adds an RAII class to make that easier. See the comments in the patch for details and examples. gcc/ * recog.h (insn_change_watermark): New class.
2020-12-17recog: Add a class for propagating into insnsRichard Sandiford2-0/+480
This patch adds yet another way of propagating into an instruction and simplifying the result. (The net effect of the series is to keep the total number of propagation approaches the same though, since a later patch removes the fwprop.c routines.) One of the drawbacks of the validate_replace_* routines is that they only do simple simplifications, mostly canonicalisations: /* Do changes needed to keep rtx consistent. Don't do any other simplifications, as it is not our job. */ if (simplify) simplify_while_replacing (loc, to, object, op0_mode); But substituting can often lead to real simplification opportunities. simplify-rtx.c:simplify_replace_rtx does fully simplify the result, but it only operates on specific rvalues rather than full instruction patterns. It is also nondestructive, which means that it returns a new rtx whenever a substitution or simplification was possible. This can create quite a bit of garbage rtl in the context of a speculative recog, where changing the contents of a pointer is often enough. The new routines are therefore supposed to provide simplify_replace_rtx- style substitution in recog. They go to some effort to prevent garbage rtl from being created. At the moment, the new routines fail if the pattern would still refer to the old "from" value in some way. That might be unnecessary in some contexts; if so, it could be put behind a configuration parameter. gcc/ * recog.h (insn_propagation): New class. * recog.c (insn_propagation::apply_to_mem_1): New function. (insn_propagation::apply_to_rvalue_1): Likewise. (insn_propagation::apply_to_lvalue_1): Likewise. (insn_propagation::apply_to_pattern_1): Likewise. (insn_propagation::apply_to_pattern): Likewise. (insn_propagation::apply_to_rvalue): Likewise.
2020-12-17recog: Add a way of temporarily undoing changesRichard Sandiford2-0/+50
In some cases, it can be convenient to roll back the changes that have been made by validate_change to see how things looked before, then reroll the changes. For example, this makes it possible to defer calculating the cost of an instruction until we know that the result is actually needed. It can also make dumps easier to read. This patch adds a couple of helper functions for doing that. gcc/ * recog.h (temporarily_undo_changes, redo_changes): Declare. * recog.c (temporarily_undone_changes): New variable. (validate_change_1, confirm_change_group): Check that it's zero. (cancel_changes): Likewise. (swap_change, temporarily_undo_changes): New functions. (redo_changes): Likewise.
2020-12-17recog: Add a validate_change_xveclen functionRichard Sandiford2-6/+36
A later patch wants to be able to use the validate_change machinery to reduce the XVECLEN of a PARALLEL. This should be more efficient than allocating a separate PARALLEL at a possibly distant memory location, especially since the new PARALLEL would be garbage rtl if the new pattern turns out not to match. Combine already pulls this trick with SUBST_INT. This patch adds a general helper for doing that. gcc/ * recog.h (validate_change_xveclen): Declare. * recog.c (change_t::old_len): New field. (validate_change_1): Add a new_len parameter. Conditionally replace the XVECLEN of an rtx, avoiding single-element PARALLELs. (validate_change_xveclen): New function. (cancel_changes): Undo changes made by validate_change_xveclen.
2020-12-17simplify-rtx: Put simplify routines into a classRichard Sandiford2-81/+220
One of the recurring warts of RTL is that multiplication by a power of 2 is represented as a MULT inside a MEM but as an ASHIFT outside a MEM. It would obviously be better if we didn't have this kind of context sensitivity, but it would be difficult to remove. Currently the simplify-rtx.c routines are hard-coded for the ASHIFT form. This means that some callers have to convert the ASHIFTs “back” into MULTs after calling the simplify-rtx.c routines; see fwprop.c:canonicalize_address for an example. I think we can relieve some of the pain by wrapping the simplify-rtx.c routines in a simple class that tracks whether the expression occurs in a MEM or not, so that no post-processing is needed. An obvious concern is whether passing the “this” pointer around will slow things down or bloat the code. I can't measure any increase in compile time after applying the patch. Sizewise, simplify-rtx.o text increases by 2.3% in default-checking builds and 4.1% in release-checking builds. I realise the MULT/ASHIFT thing isn't the most palatable reason for doing this, but I think it might be useful for other things in future, such as using local nonzero_bits hooks/virtual functions instead of the global hooks. The obvious alternative would be to add a static variable and hope that it is always updated correctly. Later patches make use of this. gcc/ * rtl.h (simplify_context): New class. (simplify_unary_operation, simplify_binary_operation): Use it. (simplify_ternary_operation, simplify_relational_operation): Likewise. (simplify_subreg, simplify_gen_unary, simplify_gen_binary): Likewise. (simplify_gen_ternary, simplify_gen_relational): Likewise. (simplify_gen_subreg, lowpart_subreg): Likewise. * simplify-rtx.c (simplify_gen_binary): Turn into a member function of simplify_context. (simplify_gen_unary, simplify_gen_ternary, simplify_gen_relational) (simplify_truncation, simplify_unary_operation): Likewise. (simplify_unary_operation_1, simplify_byte_swapping_operation) (simplify_associative_operation, simplify_logical_relational_operation) (simplify_binary_operation, simplify_binary_operation_series) (simplify_distributive_operation, simplify_plus_minus): Likewise. (simplify_relational_operation, simplify_relational_operation_1) (simplify_cond_clz_ctz, simplify_merge_mask): Likewise. (simplify_ternary_operation, simplify_subreg, simplify_gen_subreg) (lowpart_subreg): Likewise. (simplify_binary_operation_1): Likewise. Test mem_depth when deciding whether the ASHIFT or MULT form is canonical. (simplify_merge_mask): Use simplify_context.
2020-12-17recog: Split out a register_asm_p functionRichard Sandiford3-4/+14
verify_changes has a test for whether a particular hard register is a user-defined register asm. A later patch needs to test the same thing, so this patch splits it out into a helper. gcc/ * rtl.h (register_asm_p): Declare. * recog.c (verify_changes): Split out the test for whether a hard register is a register asm to... * rtlanal.c (register_asm_p): ...this new function.
2020-12-17Export print-rtl.c:print_insn_with_notesRichard Sandiford2-4/+2
Later patches want to use print_insn_with_notes (printing to a pretty_printer). This patch exports it from print-rtl.c. The non-notes version is already public. gcc/ * print-rtl.h (print_insn_with_notes): Declare. * print-rtl.c (print_insn_with_notes): Make non-static
2020-12-17Split update_cfg_for_uncondjump out of combineRichard Sandiford3-36/+48
Later patches want to reuse combine's update_cfg_for_uncondjump, so this patch makes it a public cfgrtl.c function. gcc/ * cfgrtl.h (update_cfg_for_uncondjump): Declare. * combine.c (update_cfg_for_uncondjump): Move to... * cfgrtl.c: ...here.
2020-12-17Add a cut-down version of std::span (array_slice)Richard Sandiford1-0/+120
A later patch wants to be able to pass around subarray views of an existing array. The standard class to do that is std::span, but it's a C++20 thing. This patch just adds a cut-down version of it. The intention is just to provide what's currently needed. gcc/ * vec.h (array_slice): New class.
2020-12-17Add an alternative splay tree implementationRichard Sandiford7-0/+1721
We already have two splay tree implementations: the old C one in libiberty and a templated reimplementation of it in typed-splay-tree.h. However, they have some drawbacks: - They hard-code the assumption that nodes should have both a key and a value, which isn't always true. - They use the two-phase method of lookup, and so nodes need to store a temporary back pointer. We can avoid that overhead by using the top-down method (as e.g. the bitmap tree code already does). - The tree node has to own the key and the value. For some use cases it's more convenient to embed the tree links in the value instead. Also, a later patch wants to use splay trees to represent an adaptive total order: the splay tree itself records whether node N1 is less than node N2, and (in the worst case) comparing nodes is a splay operation. This patch therefore adds an alternative implementation. The main features are: - Nodes can optionally point back to their parents. - An Accessors class abstracts accessing child nodes and (where applicable) parent nodes, so that the information can be embedded in larger data structures. - There is no fixed comparison function at the class level. Instead, individual functions that do comparisons take a comparison function argument. - There are two styles of comparison function, optimised for different use cases. (See the comments in the patch for details.) - It's possible to do some operations directly on a given node, without knowing whether it's the root. This includes the comparison use case described above. This of course has its own set of drawbacks. It's really providing splay utility functions rather than a true ADT, and so is more low-level than the existing routines. It's mostly geared for cases in which the client code wants to participate in the splay operations to some extent. gcc/ * Makefile.in (OBJS): Add splay-tree-utils.o. * system.h: Include <array> when INCLUDE_ARRAY is defined. * selftest.h (splay_tree_cc_tests): Declare. * selftest-run-tests.c (selftest::run_tests): Run splay_tree_cc_tests. * splay-tree-utils.h: New file. * splay-tree-utils.tcc: Likewise. * splay-tree-utils.cc: Likewise.
2020-12-17Add a class that multiplexes two pointer typesRichard Sandiford1-0/+251
This patch adds a pointer_mux<T1, T2> class that provides similar functionality to: union { T1 *a; T2 *b; }; ... bool is_b_rather_than_a; except that the is_b_rather_than_a tag is stored in the low bit of the pointer. See the comments in the patch for a comparison between the two approaches and why this one can be more efficient. I've tried to microoptimise the class a fair bit, since a later patch uses it extensively in order to keep the sizes of data structures down. gcc/ * mux-utils.h: New file.
2020-12-17Add an RAII class for managing obstacksRichard Sandiford1-0/+86
This patch adds an RAII class for managing the lifetimes of objects on an obstack. See the comments in the patch for more details and example usage. gcc/ * obstack-utils.h: New file.
2020-12-17Add more iterator utilitiesRichard Sandiford1-0/+159
This patch adds some more iterator helper classes. They really fall into two groups, but there didn't seem much value in separating them: - A later patch has a class hierarchy of the form: Base +- Derived1 +- Derived2 A class wants to store an array A1 of Derived1 pointers and an array A2 of Derived2 pointers. However, for compactness reasons, it was convenient to have a single array of Base pointers, with A1 and A2 being slices of this array. This reduces the overhead from two pointers and two ints (3 LP64 words) to one pointer and two ints (2 LP64 words). But consumers of the class shouldn't be aware of this: they should see A1 as containing Derived1 pointers rather than Base pointers and A2 as containing Derived2 pointers rather than Base pointers. This patch adds derived_iterator and const_derived_container classes to support this use case. - A later patch also adds various linked lists. This patch adds wrapper_iterator and list_iterator classes to make it easier to create iterators for these linked lists. For example: // Iterators for lists of definitions. using def_iterator = list_iterator<def_info, &def_info::next_def>; using reverse_def_iterator = list_iterator<def_info, &def_info::prev_def>; This in turn makes it possible to use range-based for loops on the lists. The patch just adds the things that the later patches need; it doesn't try to make the classes as functionally complete as possible. I think we should add extra functionality when needed rather than ahead of time. gcc/ * iterator-utils.h (derived_iterator): New class. (const_derived_container, wrapper_iterator): Likewise. (list_iterator): Likewise.
2020-12-17reginfo: Add a global_reg_setRichard Sandiford2-0/+7
A later patch wants to use the set of global registers as a HARD_REG_SET rather than a bool/char array. Most other arrays already have a HARD_REG_SET counterpart, but this one didn't. gcc/ * hard-reg-set.h (global_reg_set): Declare. * reginfo.c (global_reg_set): New variable. (init_reg_sets_1, globalize_reg): Update it when globalizing registers.
2020-12-16rs6000: Add support for powerpc64le-unknown-freebsdPiotr Kubaj4-3/+19
This implements support for powerpc64le architecture on FreeBSD. Since we don't have powerpcle (32-bit), I did not add support for powerpcle here. This remains to be changed if there is powerpcle support in the future. 2020-12-15 Piotr Kubaj <pkubaj@FreeBSD.org> gcc/ * config.gcc (powerpc*le-*-freebsd*): Add. * configure.ac (powerpc*le-*-freebsd*): Ditto. * configure: Regenerate. * config/rs6000/freebsd64.h (ASM_SPEC_COMMON): Use ENDIAN_SELECT. (DEFAULT_ASM_ENDIAN): Add little endian support. (LINK_OS_FREEBSD_SPEC64): Ditto.
2020-12-16test: add new Go tests from source repoIan Lance Taylor14-0/+579
2020-12-16C: Drop qualifiers of assignment expressions. [PR98047]Martin Uecker2-10/+21
ISO C17 6.5.15.1 specifies that the result is the type the LHS would have after lvalue conversion. 2020-12-16 Martin Uecker <muecker@gwdg.de> gcc/c/ PR c/98047 * c-typeck.c (build_modify_expr): Drop qualifiers. gcc/testsuite/ PR c/98047 * gcc.dg/qual-assign-7.c: New test.
2020-12-16C: Avoid incorrect warning for volatile in compound expressions [PR98260]Martin Uecker2-2/+21
2020-12-16 Martin Uecker <muecker@gwdg.de> gcc/c/ PR c/98260 * c-parser.c (c_parser_expression): Look into nop expression when marking expressions as read. gcc/testsuite/ PR c/98260 * gcc.dg/unused-9.c: New test.