aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/gimple-ssa-warn-restrict.c4
-rw-r--r--gcc/testsuite/ChangeLog6
-rw-r--r--gcc/testsuite/gcc.dg/Wrestrict-19.c32
-rw-r--r--gcc/testsuite/gcc.dg/Wrestrict-5.c15
5 files changed, 51 insertions, 12 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f57c2f9..bc97e19 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2019-04-04 Martin Sebor <msebor@redhat.com>
+
+ PR middle-end/89934
+ * gimple-ssa-warn-restrict.c (builtin_access::builtin_access): Bail
+ out if the number of arguments is less than expected.
+
2019-04-04 Jeff Law <law@redhat.com>
PR rtl-optimization/89399
diff --git a/gcc/gimple-ssa-warn-restrict.c b/gcc/gimple-ssa-warn-restrict.c
index 4ebe99f..0c571ef 100644
--- a/gcc/gimple-ssa-warn-restrict.c
+++ b/gcc/gimple-ssa-warn-restrict.c
@@ -730,6 +730,10 @@ builtin_access::builtin_access (gimple *call, builtin_memref &dst,
offset_int bounds[2] = { maxobjsize, maxobjsize };
if (dstref->strbounded_p)
{
+ unsigned nargs = gimple_call_num_args (call);
+ if (nargs <= sizeargno)
+ return;
+
tree size = gimple_call_arg (call, sizeargno);
tree range[2];
if (get_size_range (size, range, true))
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 389ca03..cc60f53 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2019-04-04 Martin Sebor <msebor@redhat.com>
+
+ PR middle-end/89934
+ * gcc.dg/Wrestrict-19.c: New test.
+ * gcc.dg/Wrestrict-5.c: Add comment. Remove unused code.
+
2019-04-04 Jeff Law <law@redhat.com>
PR rtl-optimization/89399
diff --git a/gcc/testsuite/gcc.dg/Wrestrict-19.c b/gcc/testsuite/gcc.dg/Wrestrict-19.c
new file mode 100644
index 0000000..d475053
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/Wrestrict-19.c
@@ -0,0 +1,32 @@
+/* PR middle-end/89934 - ICE on a call with fewer arguments to strncpy
+ declared without prototype
+ { dg-do compile }
+ { dg-options "-O2 -Wall" } */
+
+typedef __SIZE_TYPE__ size_t;
+
+char *strncpy ();
+
+char* f0 (char *s)
+{
+ return strncpy ();
+}
+
+char* f1 (char *s)
+{
+ return strncpy (s);
+}
+
+char* f2 (char *s)
+{
+ return strncpy (s, s + 1); /* ICE here. */
+}
+
+void f3 (char *s, size_t n, const char *t)
+{
+ strncpy (s, n, t);
+ strncpy (n, s, t);
+}
+
+/* { dg-prune-output "\\\[-Wbuiltin-declaration-mismatch]" }
+ { dg-prune-output "\\\[-Wint-conversion]" } */
diff --git a/gcc/testsuite/gcc.dg/Wrestrict-5.c b/gcc/testsuite/gcc.dg/Wrestrict-5.c
index 90babfd..513b426 100644
--- a/gcc/testsuite/gcc.dg/Wrestrict-5.c
+++ b/gcc/testsuite/gcc.dg/Wrestrict-5.c
@@ -1,20 +1,11 @@
-/* Test to verify that valid calls to common restrict-qualified built-in
+/* PR tree-optimization/83655 - ICE on an invalid call to memcpy declared
+ with no prototype
+ Test to verify that valid calls to common restrict-qualified built-in
functions declared with no prototype are checked for overlap, and that
invalid calls are ignored.
{ dg-do compile }
- { dg-prune-output "conflicting types for built-in" }
{ dg-options "-O2 -Wrestrict" } */
-typedef __SIZE_TYPE__ size_t;
-
-#if __cplusplus
-extern "C" {
-
-#define NO_PROTO ...
-#else
-#define NO_PROTO /* empty */
-#endif
-
void* memcpy ();
char* strncpy ();