diff options
author | Jakub Jelinek <jakub@redhat.com> | 2022-11-24 10:37:50 +0100 |
---|---|---|
committer | Jakub Jelinek <jakub@redhat.com> | 2022-11-24 10:37:50 +0100 |
commit | d1389be011f0fac422e98e795c55156052c4d960 (patch) | |
tree | a0cc609a4a03c3104d9f61dff1a0f253c57ad34d /libstdc++-v3 | |
parent | add0f941be18cdf962a0f300019acacbf2325d41 (diff) | |
download | gcc-d1389be011f0fac422e98e795c55156052c4d960.zip gcc-d1389be011f0fac422e98e795c55156052c4d960.tar.gz gcc-d1389be011f0fac422e98e795c55156052c4d960.tar.bz2 |
libstdc++: Workaround buggy printf on Solaris in to_chars/float128_c++23.cc test [PR107815]
As mentioned in the PR, Solaris apparently can handle right
printf ("%.0Lf\n", 1e+202L * __DBL_MAX__);
which prints 511 chars long number, but can't handle
printf ("%.0Lf\n", 1e+203L * __DBL_MAX__);
nor
printf ("%.0Lf\n", __LDBL_MAX__);
properly, instead of printing 512 chars long number for the former and
4933 chars long number for the second, it handles them as
if user asked for "%.0Le\n" in those cases.
The following patch disables the single problematic value that fails
in the test, and also fixes commented out debugging printouts.
2022-11-24 Jakub Jelinek <jakub@redhat.com>
PR libstdc++/107815
* testsuite/20_util/to_chars/float128_c++23.cc (test): Disable
__FLT128_MAX__ test on Solaris. Fix up commented out debugging
printouts.
Diffstat (limited to 'libstdc++-v3')
-rw-r--r-- | libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc index 28824c9..735a507 100644 --- a/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc +++ b/libstdc++-v3/testsuite/20_util/to_chars/float128_c++23.cc @@ -52,14 +52,17 @@ test(std::chars_format fmt = std::chars_format{}) std::numbers::inv_sqrt3_v<std::float128_t>, std::numbers::egamma_v<std::float128_t>, std::numbers::phi_v<std::float128_t>, +// Solaris has non-conforming printf, see PR98384 and PR107815. +#if !(defined(__sun__) && defined(__svr4__)) std::numeric_limits<std::float128_t>::max() +#endif }; char str1[10000], str2[10000]; for (auto u : tests) { auto [ptr1, ec1] = std::to_chars(str1, str1 + sizeof(str1), u, fmt); VERIFY( ec1 == std::errc() ); -// std::cout << i << ' ' << std::string_view (str1, ptr1) << '\n'; +// std::cout << u << ' ' << std::string_view (str1, ptr1) << '\n'; if (fmt == std::chars_format::fixed) { auto [ptr2, ec2] = std::to_chars(str2, str2 + (ptr1 - str1), u, fmt); @@ -76,7 +79,7 @@ test(std::chars_format fmt = std::chars_format{}) auto [ptr5, ec5] = std::to_chars(str1, str1 + sizeof(str1), u, fmt, 90); VERIFY( ec5 == std::errc() ); -// std::cout << i << ' ' << std::string_view (str1, ptr5) << '\n'; +// std::cout << u << ' ' << std::string_view (str1, ptr5) << '\n'; v = 4.0f128; auto [ptr6, ec6] = std::from_chars(str1, ptr5, v, fmt == std::chars_format{} |