diff options
author | Bryce McKinlay <bryce@albatross.co.nz> | 2000-12-11 03:47:48 +0000 |
---|---|---|
committer | Bryce McKinlay <bryce@gcc.gnu.org> | 2000-12-11 03:47:48 +0000 |
commit | 488d42af6f3f61ea75656c994ad9722a6e8e6af9 (patch) | |
tree | a87887486e291036f5eac4a8533c9b4456c7262d /libjava/java/util/AbstractMap.java | |
parent | a0932f7d1ae8df5e6d975821546353c7e76d941b (diff) | |
download | gcc-488d42af6f3f61ea75656c994ad9722a6e8e6af9.zip gcc-488d42af6f3f61ea75656c994ad9722a6e8e6af9.tar.gz gcc-488d42af6f3f61ea75656c994ad9722a6e8e6af9.tar.bz2 |
Makefile.am: Add HashSet.java and java/lang/ref classes.
* Makefile.am: Add HashSet.java and java/lang/ref classes.
Remove BasicMapEntry.java and Bucket.java.
* Makefile.in: Rebuilt.
* java/util/HashMap.java: Rewritten.
* java/util/HashSet.java: Imported from classpath.
* java/util/WeakHashMap.java: Imported from classpath.
* java/util/Hashtable.java: Rewritten based on new HashMap code.
* java/util/Bucket.java: Deleted.
* java/util/BasicMapEntry.java: Deleted.
* java/util/Collections.java (search): Use a for-loop, not iterator
hasNext().
(copy): Use a for-loop. Throw an IndexOutOfBoundsException if run out
of elements in source.
(max): Use a for-loop.
(min): Ditto.
(reverse): Keep track of positions instead of using Iterator's
nextIndex() and previousIndex().
(shuffle(List)): Initialize defaultRandom if required using
double-check thread safety idiom. Call two-argument shuffle method
using defaultRandom.
(defaultRandom): New field.
(shuffle(List, Random)): Use a for-loop. Keep track of pos instead
of using previousIndex() and nextIndex().
(singletonMap(iterator)): Use a HashMap.Entry, not BasicMapEntry.
* java/util/AbstractCollection.java (toString): Use a StringBuffer.
* java/util/AbstractMap.java (toString): Use StringBuffer.
* java/lang/ref/PhantomReference.java: Imported from classpath.
* java/lang/ref/SoftReference.java: Ditto.
* java/lang/ref/Reference.java: Ditto.
* java/lang/ref/WeakReference.java: Ditto.
* java/lang/ref/ReferenceQueue.java: Ditto.
From-SVN: r38183
Diffstat (limited to 'libjava/java/util/AbstractMap.java')
-rw-r--r-- | libjava/java/util/AbstractMap.java | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/libjava/java/util/AbstractMap.java b/libjava/java/util/AbstractMap.java index c4f9df0..7ce7305 100644 --- a/libjava/java/util/AbstractMap.java +++ b/libjava/java/util/AbstractMap.java @@ -227,15 +227,18 @@ public abstract class AbstractMap implements Map { Iterator entries = entrySet().iterator(); int size = size(); - String r = "{"; + StringBuffer r = new StringBuffer("{"); for (int pos = 0; pos < size; pos++) { - r += entries.next(); + // Append the toString value of the entries rather than calling + // getKey/getValue. This is more efficient and it matches the JDK + // behaviour. + r.append(entries.next()); if (pos < size - 1) - r += ", "; + r.append(", "); } - r += "}"; - return r; + r.append("}"); + return r.toString(); } public Collection values() |