diff options
author | Patrick Palka <ppalka@redhat.com> | 2021-02-25 16:44:34 -0500 |
---|---|---|
committer | Patrick Palka <ppalka@redhat.com> | 2021-02-25 16:44:34 -0500 |
commit | 7fb9a1e929db520fd741e60d84ec1a58581a8299 (patch) | |
tree | 6466778fc7fd42d5dd7bc2bf9948424abd4a1498 /libgomp/task.c | |
parent | 676f6f3277181662cf3ed07769edfa2d4fb7df28 (diff) | |
download | gcc-7fb9a1e929db520fd741e60d84ec1a58581a8299.zip gcc-7fb9a1e929db520fd741e60d84ec1a58581a8299.tar.gz gcc-7fb9a1e929db520fd741e60d84ec1a58581a8299.tar.bz2 |
c++: Fix pretty printing the context of local class [PR99213]
My r10-7705 patch for PR94521 made us set TFF_NO_FUNCTION_ARGUMENTS when
pretty printing the function scope of a local class type in order to
eliminate infinite recursion with a function signature that contains
decltype([]{}). But due to the way dump_function_decl works, this
change regressed our pretty printing of local class types whose context
contains a class template specialization, as in the testcase below, in
which we wrongly pretty print the two local types as 'A<T>::f<char>::S1'
and 'B<T>::f<int>::S2'.
This patch makes dump_scope pass TFF_NO_TEMPLATE_BINDINGS instead of
TFF_NO_FUNCTION_ARGUMENTS when pretty printing a function scope. It
appears this is the strictly better flag to use: it avoids the infinite
recursion issue, it restores pretty printing of the function parameter
list, and it stops dump_function_decl from trying to print a function
template specialization in its own weird way.
Summary of pretty printing differences for the below testcase:
r10-7704: A<T>::f() [with U = char; T = int]::S1
B<T>::f() [with T = int]::S2
r10-7705: A<T>::f<char>::S1
B<T>::f<int>::S2
this patch: A<int>::f<char>()::S1
B<int>::f()::S2
gcc/cp/ChangeLog:
PR c++/99213
PR c++/94521
* error.c (dump_scope): Pass TFF_NO_TEMPLATE_BINDINGS instead of
TFF_NO_FUNCTION_ARGUMENTS when dumping a function scope.
gcc/testsuite/ChangeLog:
PR c++/99213
PR c++/94521
* g++.dg/diagnostic/local1.C: New test.
Diffstat (limited to 'libgomp/task.c')
0 files changed, 0 insertions, 0 deletions