diff options
author | Jakub Jelinek <jakub@redhat.com> | 2022-06-28 13:05:28 +0200 |
---|---|---|
committer | Jakub Jelinek <jakub@redhat.com> | 2022-06-28 13:14:45 +0200 |
commit | 133d0d422ebd18dbd215cfa5394aff9f938e7060 (patch) | |
tree | 61960a3bd1b5217720216943ef30f5065d944b5a /libgfortran/io | |
parent | 8354d0abeb7646e109b2fb982afbc253644b0925 (diff) | |
download | gcc-133d0d422ebd18dbd215cfa5394aff9f938e7060.zip gcc-133d0d422ebd18dbd215cfa5394aff9f938e7060.tar.gz gcc-133d0d422ebd18dbd215cfa5394aff9f938e7060.tar.bz2 |
fortran, libgfortran: Avoid using libquadmath for glibc 2.26+
As mentioned by Joseph in PR105101, glibc 2.26 or later has on x86
(both -m32/-m64), powerpc64le, ia64 and mips support for
*f128 math/complex APIs plus strtof128 and strfromf128, and these APIs allow
us to avoid libquadmath for Fortran purposes on these architectures,
replace *q math/complex APIs, strtof128 instead of strtoflt128 and,
while strfromf128 unfortunately isn't a perfect replacement to
quadmath_snprintf, it can be made to work.
The advantage of this is that when configured against such glibcs
(2.26 is now almost 5 years old), we can avoid linking against an extra shared
library and the math support in glibc is maintained better than libquadmath.
We need both a compiler change (so that for glibc 2.26+ it uses *f128 APIs
instead of *q) and library change.
The above mentioned problem with strfromf128 is that the strfrom* functions
are severely restricted versions of snprintf. In libgfortran, we handle
!isfinite differently and just use snprintf/quadmath_snprintf for
%+-#.*{L,Q}{f,e} printing.
strfrom* doesn't allow +, -, # modifiers and it only supports .34 or
similar precision, not .* . The L/Q etc. letters are omitted.
The + is there to force + sign at the start if it is positive.
Workaround in the patch is to add the + at the start manually for
!signbit (val).
The - (left alignment instead of right) I don't understand why we need it,
when minimum field width isn't specified (for strfrom* can't be specified),
no padding is ever added anywhere I believe.
The # is to force adding . - workaround is to search for first . or e or '\0'
character, if it is '\0', just append ., if it is e, insert . before e and
memmove the rest (which is just a few bytes, e, +/- and at most a few digits)
one byte later.
The .* case is handled by creating the format string for strfrom* by
snprintf into a temporary buffer.
As requested, this patch also switches from using __float128 type in
libgfortran to _Float128 which is equivalent on all arches that support
__float128.
The change is done in a backwards compatible change, when GCC is configured
against glibc 2.26 or newer, libgfortran.so.5 itself doesn't link against
-lquadmath nor uses any libquadmath APIs, libgfortran.a doesn't use any
libquadmath APIs either. User programs and libraries when being linked
by gfortran driver are linked against -lgfortran and -lquadmath, but
the latter only in the --as-needed linker mode, which means it needs
to be around during linking and will be linked in if there are any
calls to math/complex functions with real(kind=16) or complex(kind=16)
in compilation units compiled by older versions of gcc, but if either
user code doesn't call those math/complex functions for the largest
supported kind, or the code is recompiled by gcc with this change in,
libquadmath won't be linked in.
2022-06-28 Jakub Jelinek <jakub@redhat.com>
gcc/fortran/
* gfortran.h (gfc_real_info): Add use_iec_60559 bitfield.
* trans-types.h (gfc_real16_use_iec_60559): Declare.
* trans-types.cc (gfc_real16_use_iec_60559): Define.
(gfc_init_kinds): When building powerpc64le-linux libgfortran
on glibc 2.26 to 2.31, set gfc_real16_use_iec_60559 and
use_iec_60559.
(gfc_build_real_type): Set gfc_real16_use_iec_60559 and use_iec_60559
on glibc 2.26 or later.
* trans-intrinsic.cc (gfc_build_intrinsic_lib_fndecls): Adjust
comment. Handle gfc_real16_use_iec_60559.
(gfc_get_intrinsic_lib_fndecl): Handle use_iec_60559.
libgfortran/
* configure.ac: Check for strtof128 and strfromf128.
Check for math and complex *f128 functions. Set
have_iec_60559_libc_support to yes if *f128 support is around, for
--enable-libquadmath-support default to "default" rather than yes if
have_iec_60559_libc_support is yes.
* acinclude.m4 (LIBGFOR_CHECK_FLOAT128): Test
_Float128/_Complex _Float128 rather than __float128 and
_Complex float __attribute__((mode(TC))). If libquadmath support
is defaulted and have_iec_60559_libc_support is yes, define and subst
USE_IEC_60559. Remove unused LIBGFOR_BUILD_QUAD conditional.
* Makefile.am (kinds.h): Pass @USE_IEC_60559@ as an extra
mk-kinds-h.sh argument.
* mk-kinds-h.sh: Accept 4th use_iec_60559 argument. Use
_Float128/_Complex _Float128 types instead of __float128 and
_Complex float __attribute__((mode(TC))), and if use_iec_60559 is yes,
use f128 suffix instead of q and define GFC_REAL_16_USE_IEC_60559.
* kinds-override.h: Use _Float128/_Complex _Float128 types instead of
__float128 and _Complex float __attribute__((mode(TC))), if
USE_IEC_60559 is defined, use f128 suffixes instead of q and
define GFC_REAL_17_USE_IEC_60559.
* libgfortran.h: Don't include quadmath_weak.h if USE_IEC_60559 is
defined.
(GFC_REAL_16_INFINITY, GFC_REAL_16_QUIET_NAN): Define
for GFC_REAL_16_USE_IEC_60559 differently.
* caf/single.c (convert_type): Use _Float128/_Complex _Float128
instead of __float128 and _Complex float __attribute__((mode(TC))).
For HAVE_GFC_REAL_10 when HAVE_GFC_REAL_16 isn't defined use
_Complex long double instead of long double.
* ieee/issignaling_fallback.h (ieee854_float128_shape_type): Use
_Float128 instead of __float128.
(__issignalingf128): Change argument type to _Float128.
(issignaling): Use _Float128 instead of __float128 in _Generic.
* intrinsics/cshift0.c (cshift0): Use _Float128 instead of __float128
in a comment. Fix a comment typo, logn double -> long double.
* intrinsics/erfc_scaled.c (_THRESH, _M_2_SQRTPI, _INF, _ERFC, _EXP):
Use different definitions if GFC_REAL_16_USE_IEC_60559.
(_THRESH, _M_2_SQRTPI): Use GFC_REAL_17_LITERAL macro.
(_ERFC, _EXP): Use different definitions if GFC_REAL_17_USE_IEC_60559.
* intrinsics/spread_generic.c (spread, spread_scalar): Use _Float128
instead of __float128 in a comment. Fix a comment typo,
logn double -> long double.
* intrinsics/trigd.c (ENABLE_SIND, ENABLE_COSD, ENABLE_TAND): Handle
GFC_REAL_16_USE_IEC_60559.
* intrinsics/pack_generic.c (pack): Use _Float128 instead of
__float128 in a comment. Fix a comment typo, logn double ->
long double.
* intrinsics/unpack_generic.c (unpack1, unpack0): Likewise.
* runtime/in_pack_generic.c (internal_pack): Likewise.
* runtime/in_unpack_generic.c (internal_unpack): Likewise.
* io/read.c (convert_real, convert_infnan): Handle
GFC_REAL_16_USE_IEC_60559 and GFC_REAL_17_USE_IEC_60559.
* io/transfer128.c (tmp1, tmp2): Don't define if libquadmath
isn't needed.
* io/write_float.def (gfor_strfromf128): New function.
(DTOA2Q, FDTOA2Q): Define differently if
GFC_REAL_16_USE_IEC_60559 or GFC_REAL_17_USE_IEC_60559.
* m4/mtype.m4: Use different suffix if GFC_REAL_16_USE_IEC_60559
or GFC_REAL_17_USE_IEC_60559.
* config.h.in: Regenerated.
* configure: Regenerated.
* Makefile.in: Regenerated.
* generated/bessel_r16.c: Regenerated.
* generated/bessel_r17.c: Regenerated.
* generated/norm2_r16.c: Regenerated.
* generated/norm2_r17.c: Regenerated.
Diffstat (limited to 'libgfortran/io')
-rw-r--r-- | libgfortran/io/read.c | 13 | ||||
-rw-r--r-- | libgfortran/io/transfer128.c | 4 | ||||
-rw-r--r-- | libgfortran/io/write_float.def | 54 |
3 files changed, 68 insertions, 3 deletions
diff --git a/libgfortran/io/read.c b/libgfortran/io/read.c index 21e7851..8e9d50d 100644 --- a/libgfortran/io/read.c +++ b/libgfortran/io/read.c @@ -186,7 +186,11 @@ convert_real (st_parameter_dt *dtp, void *dest, const char *buffer, int length) #if defined(HAVE_GFC_REAL_16) # if defined(GFC_REAL_16_IS_FLOAT128) case 16: +# if defined(GFC_REAL_16_USE_IEC_60559) + *((GFC_REAL_16*) dest) = strtof128 (buffer, &endptr); +# else *((GFC_REAL_16*) dest) = __qmath_(strtoflt128) (buffer, &endptr); +# endif break; # elif defined(HAVE_STRTOLD) case 16: @@ -199,6 +203,8 @@ convert_real (st_parameter_dt *dtp, void *dest, const char *buffer, int length) case 17: # if defined(POWER_IEEE128) *((GFC_REAL_17*) dest) = __strtoieee128 (buffer, &endptr); +# elif defined(GFC_REAL_17_USE_IEC_60559) + *((GFC_REAL_17*) dest) = strtof128 (buffer, &endptr); # else *((GFC_REAL_17*) dest) = __qmath_(strtoflt128) (buffer, &endptr); # endif @@ -272,7 +278,14 @@ convert_infnan (st_parameter_dt *dtp, void *dest, const char *buffer, #if defined(HAVE_GFC_REAL_16) # if defined(GFC_REAL_16_IS_FLOAT128) case 16: +# if defined(GFC_REAL_16_USE_IEC_60559) + if (is_inf) + *((GFC_REAL_16*) dest) = plus ? __builtin_inff128 () : -__builtin_inff128 (); + else + *((GFC_REAL_16*) dest) = plus ? __builtin_nanf128 ("") : -__builtin_nanf128 (""); +# else *((GFC_REAL_16*) dest) = __qmath_(strtoflt128) (buffer, NULL); +# endif break; # else case 16: diff --git a/libgfortran/io/transfer128.c b/libgfortran/io/transfer128.c index 7372ad7..8f30730 100644 --- a/libgfortran/io/transfer128.c +++ b/libgfortran/io/transfer128.c @@ -65,7 +65,9 @@ export_proto(transfer_complex128_write); write_float; the pointer assignment with USED attribute make sure that there is a non-weakref dependence if the quadmath functions are used. That avoids segfault when libquadmath is statically linked. */ -# if !defined(HAVE_GFC_REAL_17) || !defined(POWER_IEEE128) +# if (defined(HAVE_GFC_REAL_17) && !defined(POWER_IEEE128) \ + && !defined(GFC_REAL_17_USE_IEC_60559)) \ + || (!defined(HAVE_GFC_REAL_17) && !defined(GFC_REAL_16_USE_IEC_60559)) static void __attribute__((used)) *tmp1 = strtoflt128; static void __attribute__((used)) *tmp2 = quadmath_snprintf; # endif diff --git a/libgfortran/io/write_float.def b/libgfortran/io/write_float.def index 1f4be0d..a4d8493 100644 --- a/libgfortran/io/write_float.def +++ b/libgfortran/io/write_float.def @@ -837,18 +837,60 @@ snprintf (buffer, size, "%+-#.*e", (prec), (val)) #define DTOA2L(prec,val) \ snprintf (buffer, size, "%+-#.*Le", (prec), (val)) +#if defined(GFC_REAL_16_USE_IEC_60559) || defined(GFC_REAL_17_USE_IEC_60559) +/* strfromf128 unfortunately doesn't allow +, - and # modifiers + nor .* (only allows .number). For +, work around it by adding + leading + manually for !signbit values. For - I don't see why + we need it, when we don't specify field minimum width. + For #, add . if it is missing. Assume size is at least 2. */ +static int +gfor_strfromf128 (char *buffer, size_t size, int kind, int prec, _Float128 val) +{ + int ret, n = 0; + char fmt[sizeof (int) * 3 + 5]; + snprintf (fmt, sizeof fmt, "%%.%d%c", prec, kind); + if (!__builtin_signbit (val)) + { + n = 1; + buffer[0] = '+'; + } + ret = strfromf128 (buffer + n, size - n, fmt, val) + n; + if ((size_t) ret < size - 1) + { + size_t s = strcspn (buffer, ".e"); + if (buffer[s] != '.') + { + if (buffer[s] == '\0') + buffer[s + 1] = '\0'; + else + memmove (buffer + s + 1, buffer + s, ret + 1 - s); + buffer[s] = '.'; + ++ret; + } + } + return ret; +} +#endif #if defined(HAVE_GFC_REAL_17) # if defined(POWER_IEEE128) # define DTOA2Q(prec,val) \ __snprintfieee128 (buffer, size, "%+-#.*Le", (prec), (val)) +# elif defined(GFC_REAL_17_USE_IEC_60559) +# define DTOA2Q(prec,val) \ +gfor_strfromf128 (buffer, size, 'e', (prec), (val)) # else # define DTOA2Q(prec,val) \ quadmath_snprintf (buffer, size, "%+-#.*Qe", (prec), (val)) # endif #elif defined(GFC_REAL_16_IS_FLOAT128) -# define DTOA2Q(prec,val) \ +# if defined(GFC_REAL_16_USE_IEC_60559) +# define DTOA2Q(prec,val) \ +gfor_strfromf128 (buffer, size, 'e', (prec), (val)) +# else +# define DTOA2Q(prec,val) \ quadmath_snprintf (buffer, size, "%+-#.*Qe", (prec), (val)) +# endif #endif #define FDTOA(suff,prec,val) TOKENPASTE(FDTOA2,suff)(prec,val) @@ -865,13 +907,21 @@ snprintf (buffer, size, "%+-#.*Lf", (prec), (val)) # if defined(POWER_IEEE128) # define FDTOA2Q(prec,val) \ __snprintfieee128 (buffer, size, "%+-#.*Lf", (prec), (val)) +# elif defined(GFC_REAL_17_USE_IEC_60559) +# define FDTOA2Q(prec,val) \ +gfor_strfromf128 (buffer, size, 'f', (prec), (val)) # else # define FDTOA2Q(prec,val) \ quadmath_snprintf (buffer, size, "%+-#.*Qf", (prec), (val)) # endif #elif defined(GFC_REAL_16_IS_FLOAT128) -# define FDTOA2Q(prec,val) \ +# if defined(GFC_REAL_16_USE_IEC_60559) +# define FDTOA2Q(prec,val) \ +gfor_strfromf128 (buffer, size, 'f', (prec), (val)) +# else +# define FDTOA2Q(prec,val) \ quadmath_snprintf (buffer, size, "%+-#.*Qf", (prec), (val)) +# endif #endif |