diff options
author | Janne Blomqvist <jb@gcc.gnu.org> | 2018-01-31 16:16:22 +0200 |
---|---|---|
committer | Janne Blomqvist <jb@gcc.gnu.org> | 2018-01-31 16:16:22 +0200 |
commit | 7a157266876058eee921323240e4bfd7e5a84fba (patch) | |
tree | e8ba29378820ddd29c4b97a197217560ac1a8f19 /libgfortran/intrinsics | |
parent | 9f3dcd14146c29ca01507051ae9729a0f5569173 (diff) | |
download | gcc-7a157266876058eee921323240e4bfd7e5a84fba.zip gcc-7a157266876058eee921323240e4bfd7e5a84fba.tar.gz gcc-7a157266876058eee921323240e4bfd7e5a84fba.tar.bz2 |
Use pointer sized array indices.
Using pointer sized variables (e.g. size_t / ptrdiff_t) when the
variables are used as array indices allows accessing larger arrays,
and can be a slight performance improvement due to no need for sign or
zero extending, or masking.
Regtested on x86_64-pc-linux-gnu.
libgfortran/ChangeLog:
2018-01-31 Janne Blomqvist <jb@gcc.gnu.org>
* generated/cshift1_16.c (cshift1): Regenerated.
* generated/cshift1_4.c (cshift1): Regenerated.
* generated/cshift1_8.c (cshift1): Regenerated.
* generated/eoshift1_16.c (eoshift1): Regenerated.
* generated/eoshift1_4.c (eoshift1): Regenerated.
* generated/eoshift1_8.c (eoshift1): Regenerated.
* generated/eoshift3_16.c (eoshift3): Regenerated.
* generated/eoshift3_4.c (eoshift3): Regenerated.
* generated/eoshift3_8.c (eoshift3): Regenerated.
* generated/in_pack_c10.c (internal_pack_c10): Regenerated.
* generated/in_pack_c16.c (internal_pack_c16): Regenerated.
* generated/in_pack_c4.c (internal_pack_c4): Regenerated.
* generated/in_pack_c8.c (internal_pack_c8): Regenerated.
* generated/in_pack_i1.c (internal_pack_1): Regenerated.
* generated/in_pack_i16.c (internal_pack_16): Regenerated.
* generated/in_pack_i2.c (internal_pack_2): Regenerated.
* generated/in_pack_i4.c (internal_pack_4): Regenerated.
* generated/in_pack_i8.c (internal_pack_8): Regenerated.
* generated/in_pack_r10.c (internal_pack_r10): Regenerated.
* generated/in_pack_r16.c (internal_pack_r16): Regenerated.
* generated/in_pack_r4.c (internal_pack_r4): Regenerated.
* generated/in_pack_r8.c (internal_pack_r8): Regenerated.
* generated/in_unpack_c10.c (internal_unpack_c10): Regenerated.
* generated/in_unpack_c16.c (internal_unpack_c16): Regenerated.
* generated/in_unpack_c4.c (internal_unpack_c4): Regenerated.
* generated/in_unpack_c8.c (internal_unpack_c8): Regenerated.
* generated/in_unpack_i1.c (internal_unpack_1): Regenerated.
* generated/in_unpack_i16.c (internal_unpack_16): Regenerated.
* generated/in_unpack_i2.c (internal_unpack_2): Regenerated.
* generated/in_unpack_i4.c (internal_unpack_4): Regenerated.
* generated/in_unpack_i8.c (internal_unpack_8): Regenerated.
* generated/in_unpack_r10.c (internal_unpack_r10): Regenerated.
* generated/in_unpack_r16.c (internal_unpack_r16): Regenerated.
* generated/in_unpack_r4.c (internal_unpack_r4): Regenerated.
* generated/in_unpack_r8.c (internal_unpack_r8): Regenerated.
* generated/reshape_c10.c (reshape_c10): Regenerated.
* generated/reshape_c16.c (reshape_c16): Regenerated.
* generated/reshape_c4.c (reshape_c4): Regenerated.
* generated/reshape_c8.c (reshape_c8): Regenerated.
* generated/reshape_i16.c (reshape_16): Regenerated.
* generated/reshape_i4.c (reshape_4): Regenerated.
* generated/reshape_i8.c (reshape_8): Regenerated.
* generated/reshape_r10.c (reshape_r10): Regenerated.
* generated/reshape_r16.c (reshape_r16): Regenerated.
* generated/reshape_r4.c (reshape_r4): Regenerated.
* generated/reshape_r8.c (reshape_r8): Regenerated.
* generated/shape_i1.c (shape_1): Regenerated.
* generated/shape_i16.c (shape_16): Regenerated.
* generated/shape_i2.c (shape_2): Regenerated.
* generated/shape_i4.c (shape_4): Regenerated.
* generated/shape_i8.c (shape_8): Regenerated.
* generated/spread_c10.c (spread_scalar_c10): Regenerated.
* generated/spread_c16.c (spread_scalar_c16): Regenerated.
* generated/spread_c4.c (spread_scalar_c4): Regenerated.
* generated/spread_c8.c (spread_scalar_c8): Regenerated.
* generated/spread_i1.c (spread_scalar_i1): Regenerated.
* generated/spread_i16.c (spread_scalar_i16): Regenerated.
* generated/spread_i2.c (spread_scalar_i2): Regenerated.
* generated/spread_i4.c (spread_scalar_i4): Regenerated.
* generated/spread_i8.c (spread_scalar_i8): Regenerated.
* generated/spread_r10.c (spread_scalar_r10): Regenerated.
* generated/spread_r16.c (spread_scalar_r16): Regenerated.
* generated/spread_r4.c (spread_scalar_r4): Regenerated.
* generated/spread_r8.c (spread_scalar_r8): Regenerated.
* intrinsics/random.c (jump): Use size_t for array index in loop.
(getosrandom): Likewise.
(arandom_r4): Make n an index_type.
(arandom_r8): Likewise.
(arandom_r10): Likewise.
(arandom_r16): Likewise.
(scramble_seed): Use size_t for array index in loop.
* m4/cshift1.m4: Make i an index_type.
* m4/eoshift1.m4: Likewise.
* m4/eoshift3.m4: Likewise.
* m4/in_pack.m4: Make n an index_type.
* m4/in_unpack.m4: Likewise.
* m4/reshape.m4: Make n and dim index_type's.
* m4/shape.m4: Make n an index_type.
* m4/spread.m4: Likewise, use index_type argument rather than
copying to int.
* runtime/bounds.c (bounds_ifunction_return): Make n an
index_type.
* runtime/in_pack_generic.c (internal_pack): Likewise.
* runtime/in_unpack_generic.c (internal_unpack): Make n and size
index_type's.
From-SVN: r257234
Diffstat (limited to 'libgfortran/intrinsics')
-rw-r--r-- | libgfortran/intrinsics/random.c | 27 |
1 files changed, 11 insertions, 16 deletions
diff --git a/libgfortran/intrinsics/random.c b/libgfortran/intrinsics/random.c index 797f914..234c5ff 100644 --- a/libgfortran/intrinsics/random.c +++ b/libgfortran/intrinsics/random.c @@ -259,7 +259,7 @@ jump (xorshift1024star_state* rs) }; uint64_t t[16] = { 0 }; - for(unsigned int i = 0; i < sizeof JUMP / sizeof *JUMP; i++) + for(size_t i = 0; i < sizeof JUMP / sizeof *JUMP; i++) for(int b = 0; b < 64; b++) { if (JUMP[i] & 1ULL << b) @@ -306,7 +306,7 @@ getosrandom (void *buf, size_t buflen) /* rand_s is available in MinGW-w64 but not plain MinGW. */ #if defined(__MINGW64_VERSION_MAJOR) unsigned int* b = buf; - for (unsigned i = 0; i < buflen / sizeof (unsigned int); i++) + for (size_t i = 0; i < buflen / sizeof (unsigned int); i++) rand_s (&b[i]); return buflen; #else @@ -462,14 +462,12 @@ arandom_r4 (gfc_array_r4 *x) index_type dim; GFC_REAL_4 *dest; xorshift1024star_state* rs = get_rand_state(); - int n; - dest = x->base_addr; dim = GFC_DESCRIPTOR_RANK (x); - for (n = 0; n < dim; n++) + for (index_type n = 0; n < dim; n++) { count[n] = 0; stride[n] = GFC_DESCRIPTOR_STRIDE(x,n); @@ -494,7 +492,7 @@ arandom_r4 (gfc_array_r4 *x) dest += stride0; count[0]++; /* Advance to the next source element. */ - n = 0; + index_type n = 0; while (count[n] == extent[n]) { /* When we get to the end of a dimension, reset it and increment @@ -531,13 +529,12 @@ arandom_r8 (gfc_array_r8 *x) index_type dim; GFC_REAL_8 *dest; xorshift1024star_state* rs = get_rand_state(); - int n; dest = x->base_addr; dim = GFC_DESCRIPTOR_RANK (x); - for (n = 0; n < dim; n++) + for (index_type n = 0; n < dim; n++) { count[n] = 0; stride[n] = GFC_DESCRIPTOR_STRIDE(x,n); @@ -561,7 +558,7 @@ arandom_r8 (gfc_array_r8 *x) dest += stride0; count[0]++; /* Advance to the next source element. */ - n = 0; + index_type n = 0; while (count[n] == extent[n]) { /* When we get to the end of a dimension, reset it and increment @@ -600,13 +597,12 @@ arandom_r10 (gfc_array_r10 *x) index_type dim; GFC_REAL_10 *dest; xorshift1024star_state* rs = get_rand_state(); - int n; dest = x->base_addr; dim = GFC_DESCRIPTOR_RANK (x); - for (n = 0; n < dim; n++) + for (index_type n = 0; n < dim; n++) { count[n] = 0; stride[n] = GFC_DESCRIPTOR_STRIDE(x,n); @@ -630,7 +626,7 @@ arandom_r10 (gfc_array_r10 *x) dest += stride0; count[0]++; /* Advance to the next source element. */ - n = 0; + index_type n = 0; while (count[n] == extent[n]) { /* When we get to the end of a dimension, reset it and increment @@ -671,13 +667,12 @@ arandom_r16 (gfc_array_r16 *x) index_type dim; GFC_REAL_16 *dest; xorshift1024star_state* rs = get_rand_state(); - int n; dest = x->base_addr; dim = GFC_DESCRIPTOR_RANK (x); - for (n = 0; n < dim; n++) + for (index_type n = 0; n < dim; n++) { count[n] = 0; stride[n] = GFC_DESCRIPTOR_STRIDE(x,n); @@ -702,7 +697,7 @@ arandom_r16 (gfc_array_r16 *x) dest += stride0; count[0]++; /* Advance to the next source element. */ - n = 0; + index_type n = 0; while (count[n] == extent[n]) { /* When we get to the end of a dimension, reset it and increment @@ -751,7 +746,7 @@ static const uint64_t xor_keys[] = { static void scramble_seed (uint64_t *dest, const uint64_t *src) { - for (int i = 0; i < (int) SZU64; i++) + for (size_t i = 0; i < SZU64; i++) dest[i] = src[i] ^ xor_keys[i]; } |