aboutsummaryrefslogtreecommitdiff
path: root/libcpp
diff options
context:
space:
mode:
authorJakub Jelinek <jakub@redhat.com>2024-03-12 10:23:19 +0100
committerJakub Jelinek <jakub@redhat.com>2024-03-12 10:23:19 +0100
commit39737cdf002637c7a652e9c3e36f369cfce581e5 (patch)
treeacfe62ce9b77705b5f5e05fc34e3a9e11a7d9740 /libcpp
parentcdf0c6604d03afd7f544dd8bd5d43d9ded059ada (diff)
downloadgcc-39737cdf002637c7a652e9c3e36f369cfce581e5.zip
gcc-39737cdf002637c7a652e9c3e36f369cfce581e5.tar.gz
gcc-39737cdf002637c7a652e9c3e36f369cfce581e5.tar.bz2
strlen: Fix another spot that can create invalid ranges [PR114293]
This PR is similar to PR110603 fixed with r14-8487, except in a different spot. From the memset with -1 size of non-zero value we determine minimum of (size_t) -1 and the code uses PTRDIFF_MAX - 2 (not really sure I understand why it is - 2 and not - 1, e.g. heap allocated array with PTRDIFF_MAX char elements which contain '\0' in the last element should be fine, no? One can still represent arr[PTRDIFF_MAX] - arr[0] and arr[0] - arr[PTRDIFF_MAX] in ptrdiff_t and strlen (arr) == PTRDIFF_MAX - 1) as the maximum, so again invalid range. As in the other case, it is just UB that can lead to that, and we have choice to only keep the min and use +inf for max, or only keep max and use 0 for min, or not set the range at all, or use [min, min] or [max, max] etc. The following patch uses [min, +inf]. 2024-03-12 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/114293 * tree-ssa-strlen.cc (strlen_pass::handle_builtin_strlen): If max is smaller than min, set max to ~(size_t)0. * gcc.dg/pr114293.c: New test.
Diffstat (limited to 'libcpp')
0 files changed, 0 insertions, 0 deletions