aboutsummaryrefslogtreecommitdiff
path: root/libcpp
diff options
context:
space:
mode:
authorRichard Sandiford <richard.sandiford@arm.com>2022-01-18 12:20:00 +0000
committerRichard Sandiford <richard.sandiford@arm.com>2022-01-18 12:20:00 +0000
commit38ec23fafb167ddfe840d7bb22b3e943d8a7d29e (patch)
tree1db43c3072f3419ac35534663e172deeb7ecdae5 /libcpp
parentd21db05b6f44f8cb6df8da5af276df0c4bb3a6c9 (diff)
downloadgcc-38ec23fafb167ddfe840d7bb22b3e943d8a7d29e.zip
gcc-38ec23fafb167ddfe840d7bb22b3e943d8a7d29e.tar.gz
gcc-38ec23fafb167ddfe840d7bb22b3e943d8a7d29e.tar.bz2
aarch64: Fix overly optimistic LDP/STP matching [PR104005]
In g:526e1639aa76b0a8496b0dc3a3ff2c450229544e I'd added support for finding more consecutive MEMs. However, the check was too eager, in that it matched MEM_REFs with the same base address even if that base address was an arbitrary SSA name. This can give wrong results if a MEM_REF from one loop iteration is compared with a MEM_REF from another (e.g. after rtl unrolling). In principle, we could still accept MEM_REFs based on the same incoming SSA name, but there seems to be no out-of-the-box API for doing that. Adding a new one at this stage in GCC 12 doesn't feel like a good risk/reward trade-off. This patch therefore restricts the MEM_EXPR comparison to base decls only, excluding all MEM_REFs. It means we lose all the new STPs in the PR testcase but keep the ones in the original stp_1.c testcase. gcc/ PR target/104005 * config/aarch64/aarch64.cc (aarch64_check_consecutive_mems): When using MEM_EXPR, require the base to be a decl. gcc/testsuite/ PR target/104005 * gcc.target/aarch64/pr104005.c: New test.
Diffstat (limited to 'libcpp')
0 files changed, 0 insertions, 0 deletions