diff options
| author | Iain Sandoe <iain@sandoe.co.uk> | 2024-02-08 17:54:31 +0000 |
|---|---|---|
| committer | Iain Sandoe <iain@sandoe.co.uk> | 2024-02-19 20:14:34 +0000 |
| commit | 1609fdff16f17ead37666f6d0e801800ee3d04d2 (patch) | |
| tree | 2700db8f4e8850a4a53688c73e7e213f2ff1ae7e /libcpp | |
| parent | 20e57660e64eab7c9ef0f2dd25f3088835f8f44f (diff) | |
| download | gcc-1609fdff16f17ead37666f6d0e801800ee3d04d2.zip gcc-1609fdff16f17ead37666f6d0e801800ee3d04d2.tar.gz gcc-1609fdff16f17ead37666f6d0e801800ee3d04d2.tar.bz2 | |
libstdc++, Darwin: Handle a linker warning [PR112397].
Darwin's linker warns when we make a direct branch to code that is
in a weak definition (citing that if a different implementation of
the weak function is chosen by the dynamic linker this would be an
error).
As the analysis in the PR shows, this can happen when we have hot/
cold partitioning and there is an error path that is primarily cold
but makes use of epilogue code in the hot section. In this simple
case, we can easily deduce that the code is in fact safe; however
that is not something we can realistically implement in the linker.
Since the user-replaceable allocators are implemented using weak
definitions, this is a warning that is frequently flagged up in both
the testsuite and end-user code.
The chosen solution here is to suppress the hot/cold partitioning for
these cases (it is unlikely to impact performance much c.f. the
actual allocation).
PR target/112397
libstdc++-v3/ChangeLog:
* configure: Regenerate.
* configure.ac: Detect if we are building for Darwin.
* libsupc++/Makefile.am: If we are building for Darwin, then
suppress hot/cold partitioning for the array allocators.
* libsupc++/Makefile.in: Regenerated.
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
Co-authored-by: Jonathan Wakely <jwakely@redhat.com>
Diffstat (limited to 'libcpp')
0 files changed, 0 insertions, 0 deletions