diff options
| author | Richard Biener <rguenther@suse.de> | 2019-11-05 11:00:24 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2019-11-05 11:00:24 +0000 |
| commit | f340142b839ca1ed576013b4dba3d34245bac7d0 (patch) | |
| tree | c14ff685b2062175664a66789b40fb313c6efa3e /gcc | |
| parent | a895e6d72d763d3fc090ec852d405a07a61d01f4 (diff) | |
| download | gcc-f340142b839ca1ed576013b4dba3d34245bac7d0.zip gcc-f340142b839ca1ed576013b4dba3d34245bac7d0.tar.gz gcc-f340142b839ca1ed576013b4dba3d34245bac7d0.tar.bz2 | |
re PR tree-optimization/92324 (ICE in expand_direct_optab_fn, at internal-fn.c:2890)
2019-11-05 Richard Biener <rguenther@suse.de>
PR tree-optimization/92324
* tree-vect-loop.c (check_reduction_path): For MIN/MAX require
all signed or unsigned operations.
* gcc.dg/vect/pr92324-3.c: New testcase.
From-SVN: r277822
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/vect/pr92324-3.c | 27 | ||||
| -rw-r--r-- | gcc/tree-vect-loop.c | 13 |
4 files changed, 50 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index cf4b36f..562b69d 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2019-11-05 Richard Biener <rguenther@suse.de> + + PR tree-optimization/92324 + * tree-vect-loop.c (check_reduction_path): For MIN/MAX require + all signed or unsigned operations. + 2019-11-05 Jan Hubicka <jh@suse.cz> * hsa-brig.c: Include alloc-pool.h diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 8a12ddc..1e372eb 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-11-05 Richard Biener <rguenther@suse.de> + + PR tree-optimization/92324 + * gcc.dg/vect/pr92324-3.c: New testcase. + 2019-11-05 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/91945 diff --git a/gcc/testsuite/gcc.dg/vect/pr92324-3.c b/gcc/testsuite/gcc.dg/vect/pr92324-3.c new file mode 100644 index 0000000..db5c399 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr92324-3.c @@ -0,0 +1,27 @@ +#include "tree-vect.h" + +int a[1024]; +unsigned b[1024]; + +int __attribute__((noipa)) +foo (int n) +{ + int res = 0; + for (int i = 0; i < n; ++i) + { + res = res > a[i] ? res : a[i]; + res = res > b[i] ? res : b[i]; + } + return res; +} + +int main () +{ + check_vect (); + b[3] = (unsigned)__INT_MAX__ + 1; + if (foo (4) != -__INT_MAX__ - 1) + __builtin_abort (); + return 0; +} + +/* { dg-final { scan-tree-dump-not "vectorized \[1-9\] loops" "vect" } } */ diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index 4064e9c..3448b55 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -2740,6 +2740,7 @@ pop: /* Check whether the reduction path detected is valid. */ bool fail = path.length () == 0; bool neg = false; + int sign = -1; *code = ERROR_MARK; for (unsigned i = 1; i < path.length (); ++i) { @@ -2783,12 +2784,22 @@ pop: TREE_TYPE (gimple_assign_rhs1 (use_stmt)))) ; else if (*code == ERROR_MARK) - *code = use_code; + { + *code = use_code; + sign = TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt))); + } else if (use_code != *code) { fail = true; break; } + else if ((use_code == MIN_EXPR + || use_code == MAX_EXPR) + && sign != TYPE_SIGN (TREE_TYPE (gimple_assign_lhs (use_stmt)))) + { + fail = true; + break; + } } return ! fail && ! neg && *code != ERROR_MARK; } |