diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2019-12-03 01:27:43 +0000 |
|---|---|---|
| committer | Joseph Myers <jsm28@gcc.gnu.org> | 2019-12-03 01:27:43 +0000 |
| commit | 85d1195708cf977bd90afeb9ad51aba085993fb7 (patch) | |
| tree | e6654e02617080350ee0156781d32dfc272029da /gcc | |
| parent | b650026dff124049729faf9fefa66ff0f0effceb (diff) | |
| download | gcc-85d1195708cf977bd90afeb9ad51aba085993fb7.zip gcc-85d1195708cf977bd90afeb9ad51aba085993fb7.tar.gz gcc-85d1195708cf977bd90afeb9ad51aba085993fb7.tar.bz2 | |
Diagnose use of [*] in old-style parameter definitions (PR c/88704).
GCC wrongly accepts [*] in old-style parameter definitions because
because parm_flag is set on the scope used for those definitions and,
unlike the case of a prototype in a function definition, there is no
subsequent check to disallow this invalid usage. This patch adds such
a check. (At this point we don't have location information for the
[*], so the diagnostic location isn't ideal.)
Bootstrapped with no regressions for x86_64-pc-linux-gnu.
PR c/88704
gcc/c:
* c-decl.c (store_parm_decls_oldstyle): Diagnose use of [*] in
old-style parameter definitions.
gcc/testsuite:
* gcc.dg/vla-25.c: New test.
From-SVN: r278917
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/c/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/c/c-decl.c | 3 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/vla-25.c | 9 |
4 files changed, 23 insertions, 0 deletions
diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog index c04443e..3ea177f 100644 --- a/gcc/c/ChangeLog +++ b/gcc/c/ChangeLog @@ -1,3 +1,9 @@ +2019-12-03 Joseph Myers <joseph@codesourcery.com> + + PR c/88704 + * c-decl.c (store_parm_decls_oldstyle): Diagnose use of [*] in + old-style parameter definitions. + 2019-12-01 Sandra Loosemore <sandra@codesourcery.com> PR target/92499 diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c index bf1857d..0450fcd 100644 --- a/gcc/c/c-decl.c +++ b/gcc/c/c-decl.c @@ -9394,6 +9394,9 @@ store_parm_decls_oldstyle (tree fndecl, const struct c_arg_info *arg_info) "old-style function definition"); } + if (current_scope->had_vla_unspec) + error ("%<[*]%> not allowed in other than function prototype scope"); + /* Match each formal parameter name with its declaration. Save each decl in the appropriate TREE_PURPOSE slot of the parmids chain. */ for (parm = parmids; parm; parm = TREE_CHAIN (parm)) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index d5c7b0d..915c062 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-12-03 Joseph Myers <joseph@codesourcery.com> + + PR c/88704 + * gcc.dg/vla-25.c: New test. + 2019-12-03 Jakub Jelinek <jakub@redhat.com> * g++.dg/lto/inline-crossmodule-1_0.C: Use -fdump-ipa-inline-details diff --git a/gcc/testsuite/gcc.dg/vla-25.c b/gcc/testsuite/gcc.dg/vla-25.c new file mode 100644 index 0000000..f604157 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vla-25.c @@ -0,0 +1,9 @@ +/* Test [*] diagnosed on old-style parameter declaration. PR c/88704. */ +/* { dg-do compile } */ +/* { dg-options "-std=c99 -pedantic-errors" } */ + +void +f (x) + int x[*]; +{ /* { dg-error "not allowed in other than function prototype scope" } */ +} |