diff options
author | Jonathan Wakely <jwakely@redhat.com> | 2021-05-04 23:31:48 +0100 |
---|---|---|
committer | Jonathan Wakely <jwakely@redhat.com> | 2021-10-01 20:34:48 +0100 |
commit | cfb582f62791dfadc243d97d37f0b83ef77cf480 (patch) | |
tree | 8c6798f1e8fce4f6a6cde8ce0f14da32fdc5d23f /gcc | |
parent | c46ecb0112e91c80ee111439e79a58a953e4479d (diff) | |
download | gcc-cfb582f62791dfadc243d97d37f0b83ef77cf480.zip gcc-cfb582f62791dfadc243d97d37f0b83ef77cf480.tar.gz gcc-cfb582f62791dfadc243d97d37f0b83ef77cf480.tar.bz2 |
libstdc++: Optimize std::visit for the common case [PR 78113]
GCC does not do a good job of optimizing the table of function pointers
used for variant visitation. This avoids using the table for the common
case of visiting a single variant with a small number of alternative
types. Instead we use:
switch(v.index())
{
case 0: return visitor(get<0>(v));
case 1: return visitor(get<1>(v));
...
}
It's not quite that simple, because get<1>(v) is ill-formed if the
variant only has one alternative, and similarly for each get<N>. We
need to ensure each case only applies the visitor if the index is in
range for the actual type we're dealing with, and tell the compiler that
the case is unreachable otherwise. We also need to invoke the visitor
via the __gen_vtable_impl::__visit_invoke function, to handle the raw
visitation cases used to implement std::variant assignments and
comparisons.
Because that gets quite verbose and repetitive, a macro is used to stamp
out the cases.
We also need to handle the valueless_by_exception case, but only for raw
visitation, because std::visit already checks for it before calling
__do_visit.
Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
libstdc++-v3/ChangeLog:
PR libstdc++/78113
* include/std/variant (__do_visit): Use a switch when we have a
single variant with a small number of alternatives.
Diffstat (limited to 'gcc')
0 files changed, 0 insertions, 0 deletions