aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorJakub Jelinek <jakub@redhat.com>2015-05-13 10:07:58 +0200
committerJakub Jelinek <jakub@gcc.gnu.org>2015-05-13 10:07:58 +0200
commitc1ee2e626ea59d8ba14a1d2f36621a2fe525320a (patch)
tree858c3d51df65a4a724285ee74c872658f393de56 /gcc
parente9ae68afa0154895e42dbc098bc7ba63eaef7ce6 (diff)
downloadgcc-c1ee2e626ea59d8ba14a1d2f36621a2fe525320a.zip
gcc-c1ee2e626ea59d8ba14a1d2f36621a2fe525320a.tar.gz
gcc-c1ee2e626ea59d8ba14a1d2f36621a2fe525320a.tar.bz2
re PR target/66112 (__builtin_mul_overflow for int16_t emits poor code)
PR target/66112 * internal-fn.c (get_min_precision): Use UNSIGNED instead of SIGNED to get precision of non-negative value. * gcc.target/i386/pr66112-1.c: New test. From-SVN: r223115
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/internal-fn.c2
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.target/i386/pr66112-1.c16
4 files changed, 28 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 35f8197..1199ad7 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2015-05-13 Jakub Jelinek <jakub@redhat.com>
+
+ PR target/66112
+ * internal-fn.c (get_min_precision): Use UNSIGNED instead of
+ SIGNED to get precision of non-negative value.
+
2015-05-13 Ilya Enkovich <ilya.enkovich@intel.com>
PR target/66048
diff --git a/gcc/internal-fn.c b/gcc/internal-fn.c
index 0053ed9..4eeb681 100644
--- a/gcc/internal-fn.c
+++ b/gcc/internal-fn.c
@@ -399,7 +399,7 @@ get_min_precision (tree arg, signop sign)
}
else if (sign == UNSIGNED && !wi::neg_p (arg_min, SIGNED))
{
- int p = wi::min_precision (arg_max, SIGNED);
+ int p = wi::min_precision (arg_max, UNSIGNED);
prec = MIN (prec, p);
}
return prec + (orig_sign != sign);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 2f83f4e..4600fe1 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-05-13 Jakub Jelinek <jakub@redhat.com>
+
+ PR target/66112
+ * gcc.target/i386/pr66112-1.c: New test.
+
2015-05-13 Ilya Enkovich <ilya.enkovich@intel.com>
PR target/66048
diff --git a/gcc/testsuite/gcc.target/i386/pr66112-1.c b/gcc/testsuite/gcc.target/i386/pr66112-1.c
new file mode 100644
index 0000000..268990c
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr66112-1.c
@@ -0,0 +1,16 @@
+/* PR target/66112 */
+/* { dg-do compile } */
+/* { dg-options "-O2" } */
+
+unsigned int
+foo (long long a, long long b)
+{
+ unsigned int res;
+ a &= ~0U;
+ b &= ~0U;
+ if (__builtin_mul_overflow (a, b, &res))
+ res = 0x123U;
+ return res;
+}
+
+/* { dg-final { scan-assembler "jn?o\[ \t\]" } } */