diff options
| author | Richard Biener <rguenther@suse.de> | 2022-06-24 13:37:22 +0200 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2022-06-24 14:50:05 +0200 |
| commit | b36a1c964f99758de1f3b169628965d3c3af812b (patch) | |
| tree | 16002b04d83ab2c47affc181a23be9cd5dfd4769 /gcc | |
| parent | fa4e97907fc979f550c3f02cde03d9c35f99df9b (diff) | |
| download | gcc-b36a1c964f99758de1f3b169628965d3c3af812b.zip gcc-b36a1c964f99758de1f3b169628965d3c3af812b.tar.gz gcc-b36a1c964f99758de1f3b169628965d3c3af812b.tar.bz2 | |
middle-end/106070 - bogus cond-expr folding
The following fixes up r13-469-g9a53101caadae1b5 by properly
implementing what operand_equal_for_comparison_p did.
2022-06-24 Richard Biener <rguenther@suse.de>
PR middle-end/106070
* match.pd (a != b ? a : b): Fix translation of
operand_equal_for_comparison_p.
* gcc.dg/torture/pr106070.c: New testcase.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/match.pd | 11 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/torture/pr106070.c | 20 |
2 files changed, 27 insertions, 4 deletions
diff --git a/gcc/match.pd b/gcc/match.pd index 4a57089..e486b4b 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -4574,12 +4574,15 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) (cond (cmp:c (nop_convert1?@c0 @0) (nop_convert2?@c1 @1)) (convert3? @0) (convert4? @1)) (if (!HONOR_SIGNED_ZEROS (type) - && ((INTEGRAL_TYPE_P (type) - /* Allow widening conversions of the data. */ + && (/* Allow widening conversions of the compare operands as data. */ + (INTEGRAL_TYPE_P (type) + && types_match (TREE_TYPE (@c0), TREE_TYPE (@0)) + && types_match (TREE_TYPE (@c1), TREE_TYPE (@1)) && TYPE_PRECISION (TREE_TYPE (@0)) <= TYPE_PRECISION (type) && TYPE_PRECISION (TREE_TYPE (@1)) <= TYPE_PRECISION (type)) - || (tree_nop_conversion_p (type, TREE_TYPE (@0)) - && tree_nop_conversion_p (type, TREE_TYPE (@1))))) + /* Or sign conversions for the comparison. */ + || (types_match (type, TREE_TYPE (@0)) + && types_match (type, TREE_TYPE (@1))))) (switch (if (cmp == EQ_EXPR) (if (VECTOR_TYPE_P (type)) diff --git a/gcc/testsuite/gcc.dg/torture/pr106070.c b/gcc/testsuite/gcc.dg/torture/pr106070.c new file mode 100644 index 0000000..c36534f --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr106070.c @@ -0,0 +1,20 @@ +/* { dg-do run } */ + +unsigned int var_2 = 1; +int var_4 = -1; +int var_10 = 4; +unsigned long arr_252; +void __attribute__((noipa)) test() { + for (int a = 0; a < var_10; a += 2) + arr_252 = var_2 != (int)var_4 ? (unsigned long)var_4 : (unsigned long)var_2; +} + +void test(); + +int main() +{ + test(); + if (arr_252 != 0xffffffffffffffff) + __builtin_abort(); + return 0; +} |