diff options
| author | Paolo Carlini <paolo.carlini@oracle.com> | 2017-06-01 10:20:27 +0000 |
|---|---|---|
| committer | Paolo Carlini <paolo@gcc.gnu.org> | 2017-06-01 10:20:27 +0000 |
| commit | ac853c9071ab9a8df483c26fe8672732546c51ab (patch) | |
| tree | 840e9172b123a07168d915101b1f9441c3c29348 /gcc | |
| parent | 7841f13c8064c7d8f4eb13acd396bd0455e12c26 (diff) | |
| download | gcc-ac853c9071ab9a8df483c26fe8672732546c51ab.zip gcc-ac853c9071ab9a8df483c26fe8672732546c51ab.tar.gz gcc-ac853c9071ab9a8df483c26fe8672732546c51ab.tar.bz2 | |
re PR c++/80896 ([[nodiscard]] is ignored for functions returning references)
/cp
2017-06-01 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/80896
* cvt.c (convert_to_void): Possibly call maybe_warn_nodiscard
for case INDIRECT_REF too in the main switch.
/testsuite
2017-06-01 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/80896
* g++.dg/cpp1z/nodiscard5.C: New.
From-SVN: r248784
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/cp/cvt.c | 2 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/cpp1z/nodiscard5.C | 7 |
4 files changed, 20 insertions, 0 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index bbb6a53..60fe1a5 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2017-06-01 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/80896 + * cvt.c (convert_to_void): Possibly call maybe_warn_nodiscard + for case INDIRECT_REF too in the main switch. + 2017-05-31 Jason Merrill <jason@redhat.com> PR c++/80840 - ICE with constexpr and reference diff --git a/gcc/cp/cvt.c b/gcc/cp/cvt.c index e8a7ee2..6b28ef6 100644 --- a/gcc/cp/cvt.c +++ b/gcc/cp/cvt.c @@ -1296,6 +1296,8 @@ convert_to_void (tree expr, impl_conv_void implicit, tsubst_flags_t complain) && !is_reference) warning_at (loc, OPT_Wunused_value, "value computed is not used"); expr = TREE_OPERAND (expr, 0); + if (TREE_CODE (expr) == CALL_EXPR) + maybe_warn_nodiscard (expr, implicit); } break; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 952bc93..a1212f2 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-06-01 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/80896 + * g++.dg/cpp1z/nodiscard5.C: New. + 2017-06-01 Claudiu Zissulescu <claziss@synopsys.com> * gcc.target/arc/pr9001195952.c: New test. diff --git a/gcc/testsuite/g++.dg/cpp1z/nodiscard5.C b/gcc/testsuite/g++.dg/cpp1z/nodiscard5.C new file mode 100644 index 0000000..fa9a974 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp1z/nodiscard5.C @@ -0,0 +1,7 @@ +// PR c++/80896 +// { dg-do compile { target c++11 } } + +int x = 42; +[[nodiscard]] int& func() { return x; } + +int main() { func(); } // { dg-warning "ignoring return value" } |