diff options
| author | Bin Cheng <bin.cheng@arm.com> | 2016-05-19 09:03:36 +0000 |
|---|---|---|
| committer | Bin Cheng <amker@gcc.gnu.org> | 2016-05-19 09:03:36 +0000 |
| commit | 8340e4fcb8e413588ed7a7db2c1cca9517ea154b (patch) | |
| tree | ed0749d933bf5830fe927bf80ef9f5d93cf0c72c /gcc | |
| parent | e1fe3c698f5400139a4a5bec73c4600da8858356 (diff) | |
| download | gcc-8340e4fcb8e413588ed7a7db2c1cca9517ea154b.zip gcc-8340e4fcb8e413588ed7a7db2c1cca9517ea154b.tar.gz gcc-8340e4fcb8e413588ed7a7db2c1cca9517ea154b.tar.bz2 | |
re PR tree-optimization/69848 (poor vectorization of a loop from SPEC2006 464.h264ref)
PR tree-optimization/69848
* tree-vect-loop.c (vectorizable_reduction): Don't factor
comparison expr out of VEC_COND_EXPR for COND_REDUCTION.
From-SVN: r236447
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/tree-vect-loop.c | 17 |
2 files changed, 11 insertions, 12 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e2e29fe..b39357a 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2016-05-19 Bin Cheng <bin.cheng@arm.com> + + PR tree-optimization/69848 + * tree-vect-loop.c (vectorizable_reduction): Don't factor + comparison expr out of VEC_COND_EXPR for COND_REDUCTION. + 2016-05-19 Segher Boessenkool <segher@kernel.crashing.org> * function.c (thread_prologue_and_epilogue_insn): Move the diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index d673c67..67053af 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -6159,21 +6159,14 @@ vectorizable_reduction (gimple *stmt, gimple_stmt_iterator *gsi, Finally, we update the phi (NEW_PHI_TREE) to take the value of the new cond_expr (INDEX_COND_EXPR). */ - /* Turn the condition from vec_stmt into an ssa name. */ - gimple_stmt_iterator vec_stmt_gsi = gsi_for_stmt (*vec_stmt); - tree ccompare = gimple_assign_rhs1 (*vec_stmt); - tree ccompare_name = make_ssa_name (TREE_TYPE (ccompare)); - gimple *ccompare_stmt = gimple_build_assign (ccompare_name, - ccompare); - gsi_insert_before (&vec_stmt_gsi, ccompare_stmt, GSI_SAME_STMT); - gimple_assign_set_rhs1 (*vec_stmt, ccompare_name); - update_stmt (*vec_stmt); + /* Duplicate the condition from vec_stmt. */ + tree ccompare = unshare_expr (gimple_assign_rhs1 (*vec_stmt)); /* Create a conditional, where the condition is taken from vec_stmt - (CCOMPARE_NAME), then is the induction index (INDEX_BEFORE_INCR) - and else is the phi (NEW_PHI_TREE). */ + (CCOMPARE), then is the induction index (INDEX_BEFORE_INCR) and + else is the phi (NEW_PHI_TREE). */ tree index_cond_expr = build3 (VEC_COND_EXPR, cr_index_vector_type, - ccompare_name, indx_before_incr, + ccompare, indx_before_incr, new_phi_tree); cond_name = make_ssa_name (cr_index_vector_type); gimple *index_condition = gimple_build_assign (cond_name, |