diff options
| author | Thomas Preud'homme <thomas.preudhomme@arm.com> | 2018-03-14 10:47:32 +0000 |
|---|---|---|
| committer | Thomas Preud'homme <thopre01@gcc.gnu.org> | 2018-03-14 10:47:32 +0000 |
| commit | 7b06ad56de211882b9cbfa932443ebd3c0b48a86 (patch) | |
| tree | 1def88f356c5d4c852c23c96789c099be6ffc9ba /gcc | |
| parent | 79ab536427e403df631eb3ed3480c6330b2ff898 (diff) | |
| download | gcc-7b06ad56de211882b9cbfa932443ebd3c0b48a86.zip gcc-7b06ad56de211882b9cbfa932443ebd3c0b48a86.tar.gz gcc-7b06ad56de211882b9cbfa932443ebd3c0b48a86.tar.bz2 | |
Fix FAIL display for some scan-*-times directives
scan-assembler-times and scan-tree-dump-times dejagnu directives show a
different output in the summary files depending on whether they PASS or
FAIL. This means that dg-cmp-results would not show a regression because
it would not see a connection between the two output.
The difference comes from the FAIL showing the number of actual times
the pattern was match, presumably to help debugging. This patch moves
the info regarding the actual number of times the pattern match in a
separate verbose message. This keeps the message unchanged but let
developers have the required debug message with -v.
2018-03-14 Thomas Preud'homme <thomas.preudhomme@arm.com>
gcc/testsuite/
* lib/scanasm.exp (scan-assembler-times): Move FAIL debug info into a
separate verbose message.
* lib/scandump.exp (scan-dump-times): Likewise.
From-SVN: r258519
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/lib/scanasm.exp | 3 | ||||
| -rw-r--r-- | gcc/testsuite/lib/scandump.exp | 3 |
3 files changed, 10 insertions, 2 deletions
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 187cc6b..f89a29a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2018-03-14 Thomas Preud'homme <thomas.preudhomme@arm.com> + + * lib/scanasm.exp (scan-assembler-times): Move FAIL debug info into a + separate verbose message. + * lib/scandump.exp (scan-dump-times): Likewise. + 2018-03-14 Julia Koval <julia.koval@intel.com> * g++.dg/ext/mv16.C: Split up icelake on icelake client and icelake diff --git a/gcc/testsuite/lib/scanasm.exp b/gcc/testsuite/lib/scanasm.exp index 3a775b0..61e0f3f 100644 --- a/gcc/testsuite/lib/scanasm.exp +++ b/gcc/testsuite/lib/scanasm.exp @@ -266,7 +266,8 @@ proc scan-assembler-times { args } { if {$result_count == $times} { pass "$testcase scan-assembler-times $pp_pattern $times" } else { - fail "$testcase scan-assembler-times $pp_pattern $times (found $result_count times)" + verbose -log "$testcase: $pp_pattern found $result_count times" + fail "$testcase scan-assembler-times $pp_pattern $times" } } diff --git a/gcc/testsuite/lib/scandump.exp b/gcc/testsuite/lib/scandump.exp index 4e3da97..be8fbe8 100644 --- a/gcc/testsuite/lib/scandump.exp +++ b/gcc/testsuite/lib/scandump.exp @@ -110,7 +110,8 @@ proc scan-dump-times { args } { if {$result_count == $times} { pass "$testname" } else { - fail "$testname (found $result_count times)" + verbose -log "$testcase: pattern found $result_count times" + fail "$testname" } } |