diff options
| author | Roger Sayle <roger@nextmovesoftware.com> | 2021-11-25 19:02:06 +0000 |
|---|---|---|
| committer | Roger Sayle <roger@nextmovesoftware.com> | 2021-11-25 19:02:06 +0000 |
| commit | 6ea5fb3cc7f3cc9b731d72183c66c23543876f5a (patch) | |
| tree | 2b5e6764bfe48e574083d57a5cfc6914717ffd7b /gcc | |
| parent | 9488d24206687be80443dafdb2cdfc4ff3aca28c (diff) | |
| download | gcc-6ea5fb3cc7f3cc9b731d72183c66c23543876f5a.zip gcc-6ea5fb3cc7f3cc9b731d72183c66c23543876f5a.tar.gz gcc-6ea5fb3cc7f3cc9b731d72183c66c23543876f5a.tar.bz2 | |
PR middle-end/103406: Check for Inf before simplifying x-x.
This is a simple one line fix to the regression PR middle-end/103406,
where x - x is being folded to 0.0 even when x is +Inf or -Inf.
In GCC 11 and previously, we'd check whether the type honored NaNs
(which implicitly covered the case where the type honors infinities),
but my patch to test whether the operand could potentially be NaN
failed to also check whether the operand could potentially be Inf.
2021-11-25 Roger Sayle <roger@nextmovesoftware.com>
gcc/ChangeLog
PR middle-end/103406
* match.pd (minus @0 @0): Check tree_expr_maybe_infinite_p.
gcc/testsuite/ChangeLog
PR middle-end/103406
* gcc.dg/pr103406.c: New test case.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/match.pd | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr103406.c | 14 |
2 files changed, 17 insertions, 1 deletions
diff --git a/gcc/match.pd b/gcc/match.pd index 39fd77d..fbb5a5a 100644 --- a/gcc/match.pd +++ b/gcc/match.pd @@ -233,7 +233,9 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) is volatile. */ (simplify (minus @0 @0) - (if (!FLOAT_TYPE_P (type) || !tree_expr_maybe_nan_p (@0)) + (if (!FLOAT_TYPE_P (type) + || (!tree_expr_maybe_nan_p (@0) + && !tree_expr_maybe_infinite_p (@0))) { build_zero_cst (type); })) (simplify (pointer_diff @@0 @0) diff --git a/gcc/testsuite/gcc.dg/pr103406.c b/gcc/testsuite/gcc.dg/pr103406.c new file mode 100644 index 0000000..9c7b83b --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr103406.c @@ -0,0 +1,14 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-optimized" } */ + +#define HUGE __DBL_MAX__ +#define INF (HUGE + HUGE) +#define NAN (INF - INF) + +double foo() { + double x = -NAN; + double y = NAN; + return x + y; +} + +/* { dg-final { scan-tree-dump-not "return 0\.0" "optimized" } } */ |