diff options
author | Jason Merrill <jason@redhat.com> | 2021-04-05 22:50:44 -0400 |
---|---|---|
committer | Jason Merrill <jason@redhat.com> | 2021-04-06 00:12:57 -0400 |
commit | 55f40d968b0bd3be4478a9481e829a99ee0fa04f (patch) | |
tree | 659592b42ad51c77fbb9ac7f710f20e5f47be509 /gcc | |
parent | 66de517b1c1dd22df7914f8e9a083cd5a73adbe2 (diff) | |
download | gcc-55f40d968b0bd3be4478a9481e829a99ee0fa04f.zip gcc-55f40d968b0bd3be4478a9481e829a99ee0fa04f.tar.gz gcc-55f40d968b0bd3be4478a9481e829a99ee0fa04f.tar.bz2 |
c++: mangling of lambdas in default args [PR91241]
In this testcase, the parms remembered in LAMBDA_EXPR_EXTRA_SCOPE are no
longer the parms of the FUNCTION_DECL they have as their DECL_CONTEXT, so we
were mangling both lambdas as parm #0. But since the parms are numbered
from right to left we don't need to need to find them in the FUNCTION_DECL,
we can measure their own DECL_CHAIN.
gcc/cp/ChangeLog:
PR c++/91241
* mangle.c (write_compact_number): Add sanity check.
(write_local_name): Use list_length for parm number.
gcc/testsuite/ChangeLog:
PR c++/91241
* g++.dg/abi/lambda-defarg1.C: New test.
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/cp/mangle.c | 11 | ||||
-rw-r--r-- | gcc/testsuite/g++.dg/abi/lambda-defarg1.C | 11 |
2 files changed, 13 insertions, 9 deletions
diff --git a/gcc/cp/mangle.c b/gcc/cp/mangle.c index 6c11134..4399165 100644 --- a/gcc/cp/mangle.c +++ b/gcc/cp/mangle.c @@ -1628,6 +1628,7 @@ write_literal_operator_name (tree identifier) static void write_compact_number (int num) { + gcc_checking_assert (num >= 0); if (num > 0) write_unsigned_number (num - 1); write_char ('_'); @@ -2027,15 +2028,7 @@ write_local_name (tree function, const tree local_entity, /* For this purpose, parameters are numbered from right-to-left. */ if (parm) { - tree t; - int i = 0; - for (t = DECL_ARGUMENTS (function); t; t = DECL_CHAIN (t)) - { - if (t == parm) - i = 1; - else if (i) - ++i; - } + int i = list_length (parm); write_char ('d'); write_compact_number (i - 1); } diff --git a/gcc/testsuite/g++.dg/abi/lambda-defarg1.C b/gcc/testsuite/g++.dg/abi/lambda-defarg1.C new file mode 100644 index 0000000..8c53858 --- /dev/null +++ b/gcc/testsuite/g++.dg/abi/lambda-defarg1.C @@ -0,0 +1,11 @@ +// PR c++/91241 +// { dg-do compile { target c++11 } } + +struct A { + int *b(const int & = []() -> int { return 0; }(), + const int & = []() -> int { return 0; }()); +}; +int *A::b(const int &, const int &) { b(); return 0; } +// { dg-final { scan-assembler "_ZN1A1bERKiS1_" } } +// { dg-final { scan-assembler "_ZZN1A1bERKiS1_Ed_NKUlvE_clEv" } } +// { dg-final { scan-assembler "_ZZN1A1bERKiS1_Ed0_NKUlvE_clEv" } } |