aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorAlan Modra <amodra@bigpond.net.au>2004-05-27 07:41:50 +0000
committerAlan Modra <amodra@gcc.gnu.org>2004-05-27 17:11:50 +0930
commit42f806e5a0bbc3f5a02394893343e7e6ce1e94f2 (patch)
treedab3ea8a505686bcd5d39b18a2d6c0ead1478474 /gcc
parentc5d2de6b4c976dc152c8618ab3e8e1319018dc30 (diff)
downloadgcc-42f806e5a0bbc3f5a02394893343e7e6ce1e94f2.zip
gcc-42f806e5a0bbc3f5a02394893343e7e6ce1e94f2.tar.gz
gcc-42f806e5a0bbc3f5a02394893343e7e6ce1e94f2.tar.bz2
re PR target/14478 ([3.3 only] rs6000 geu/ltu patterns generate incorrect code)
PR target/14478 * config/rs6000/rs6000.c (reg_or_neg_short_operand): Don't allow zero. From-SVN: r82315
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ChangeLog5
-rw-r--r--gcc/config/rs6000/rs6000.c7
2 files changed, 10 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index a13cbdd..353c25c 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2004-05-27 Alan Modra <amodra@bigpond.net.au>
+
+ PR target/14478
+ * config/rs6000/rs6000.c (reg_or_neg_short_operand): Don't allow zero.
+
2004-05-27 Josef Zlomek <zlomekj@suse.cz>
PR middle-end/14084
diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index e6ce004..4b23dcc 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -1407,13 +1407,16 @@ reg_or_short_operand (rtx op, enum machine_mode mode)
}
/* Similar, except check if the negation of the constant would be
- valid for a D-field. */
+ valid for a D-field. Don't allow a constant zero, since all the
+ patterns that call this predicate use "addic r1,r2,-constant" on
+ a constant value to set a carry when r2 is greater or equal to
+ "constant". That doesn't work for zero. */
int
reg_or_neg_short_operand (rtx op, enum machine_mode mode)
{
if (GET_CODE (op) == CONST_INT)
- return CONST_OK_FOR_LETTER_P (INTVAL (op), 'P');
+ return CONST_OK_FOR_LETTER_P (INTVAL (op), 'P') && INTVAL (op) != 0;
return gpc_reg_operand (op, mode);
}