aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorJakub Jelinek <jakub@redhat.com>2015-11-19 09:30:19 +0100
committerJakub Jelinek <jakub@gcc.gnu.org>2015-11-19 09:30:19 +0100
commit397d0df98c972375682078d74e90eaf4f09c3748 (patch)
treee5c89f28712764e4fd88032f4e00896a1d80e584 /gcc
parent46ce03de3afe6dcd7b23572ada199c28ffc10e70 (diff)
downloadgcc-397d0df98c972375682078d74e90eaf4f09c3748.zip
gcc-397d0df98c972375682078d74e90eaf4f09c3748.tar.gz
gcc-397d0df98c972375682078d74e90eaf4f09c3748.tar.bz2
re PR target/67770 (i386: -fshrink-wrap can interact badly with trampolines)
PR target/67770 * config/i386/i386.md (simple_return): Disable if ix86_static_chain_on_stack is true. * gcc.target/i386/pr67770.c: New test. From-SVN: r230593
Diffstat (limited to 'gcc')
-rw-r--r--gcc/ChangeLog6
-rw-r--r--gcc/config/i386/i386.md6
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/gcc.target/i386/pr67770.c40
4 files changed, 56 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index f37ad25..3ba9327 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,9 @@
+2015-11-19 Jakub Jelinek <jakub@redhat.com>
+
+ PR target/67770
+ * config/i386/i386.md (simple_return): Disable if
+ ix86_static_chain_on_stack is true.
+
2015-11-19 Richard Sandiford <richard.sandiford@arm.com>
PR bootstrap/68393
diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
index 39b058f..4c5e22a 100644
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -12203,10 +12203,14 @@
;; We need to disable this for TARGET_SEH, as otherwise
;; shrink-wrapped prologue gets enabled too. This might exceed
;; the maximum size of prologue in unwind information.
+;; Also disallow shrink-wrapping if using stack slot to pass the
+;; static chain pointer - the first instruction has to be pushl %esi
+;; and it can't be moved around, as we use alternate entry points
+;; in that case.
(define_expand "simple_return"
[(simple_return)]
- "!TARGET_SEH"
+ "!TARGET_SEH && !ix86_static_chain_on_stack"
{
if (crtl->args.pops_args)
{
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 48f536f..8c7746f 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-11-19 Jakub Jelinek <jakub@redhat.com>
+
+ PR target/67770
+ * gcc.target/i386/pr67770.c: New test.
+
2015-11-18 Jeff Law <law@redhat.com>
PR tree-optimization/68198
diff --git a/gcc/testsuite/gcc.target/i386/pr67770.c b/gcc/testsuite/gcc.target/i386/pr67770.c
new file mode 100644
index 0000000..3826aff
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr67770.c
@@ -0,0 +1,40 @@
+/* PR target/67770 */
+/* { dg-do run { target ia32 } } */
+/* { dg-require-effective-target trampolines } */
+/* { dg-options "-O2" } */
+
+#ifndef NO_TRAMPOLINES
+__attribute__ ((noinline)) void
+foo (int i, void (* __attribute__ ((regparm (3))) bar) (int))
+{
+ bar (i);
+}
+#endif
+
+int
+main ()
+{
+#ifndef NO_TRAMPOLINES
+ int p = 0;
+
+ __attribute__ ((regparm (3), noinline)) void
+ bar (int i)
+ {
+ if (__builtin_expect (i, 0))
+ ++p;
+ }
+
+ foo (0, bar);
+ bar (0);
+
+ if (p != 0)
+ __builtin_abort ();
+
+ foo (1, bar);
+ bar (1);
+
+ if (p != 2)
+ __builtin_abort ();
+#endif
+ return 0;
+}