diff options
author | Jonathan Wakely <jwakely@redhat.com> | 2022-01-21 12:08:20 +0000 |
---|---|---|
committer | Jonathan Wakely <jwakely@redhat.com> | 2022-01-23 22:47:00 +0000 |
commit | 2d8a9ad4a922e3248d0f6c60a6331be6f47dc435 (patch) | |
tree | 2e04720702ab3bf795dbd06dbb25b334f260bc1f /gcc | |
parent | 2da90ad39bf8fa9ee287e040d1f4411cb7a2e7ed (diff) | |
download | gcc-2d8a9ad4a922e3248d0f6c60a6331be6f47dc435.zip gcc-2d8a9ad4a922e3248d0f6c60a6331be6f47dc435.tar.gz gcc-2d8a9ad4a922e3248d0f6c60a6331be6f47dc435.tar.bz2 |
libstdc++: Fix aliasing violation in std::shared_ptr [PR104019]
The non-atomic store that sets both reference counts to zero uses a
type-punned pointer, which has undefined behaviour. We could use memset
to write 8 bytes, but we don't actually need it to be a single store
anyway. No other thread can observe the values, that's why it's safe to
use non-atomic stores in the first place. So we can just set each count
to zero.
With -fstore-merging (which is enabled by default at -O2) GCC produces
the same code for this as for memset or the type punned store. Clang
does that store merging even at -O1.
libstdc++-v3/ChangeLog:
PR libstdc++/104019
* include/bits/shared_ptr_base.h (_Sp_counted_base<>::_M_release):
Set members to zero without type punning.
Diffstat (limited to 'gcc')
0 files changed, 0 insertions, 0 deletions