diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2021-06-24 15:55:28 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2021-06-24 15:55:28 +0200 |
| commit | fdc5522fb04b4a820b28c4d1f16f54897f5978de (patch) | |
| tree | 2afc55a0c4f161758564e1acdd99faff0ffee43a /gcc | |
| parent | 836328b2c99f5b8d45dcca5797f162af322e74da (diff) | |
| download | gcc-fdc5522fb04b4a820b28c4d1f16f54897f5978de.zip gcc-fdc5522fb04b4a820b28c4d1f16f54897f5978de.tar.gz gcc-fdc5522fb04b4a820b28c4d1f16f54897f5978de.tar.bz2 | |
c: Fix C cast error-recovery [PR101171]
The following testcase ICEs during error-recovery, as build_c_cast calls
note_integer_operands on error_mark_node and that wraps it into
C_MAYBE_CONST_EXPR which is unexpected and causes ICE later on.
Seems most other callers of note_integer_operands check early if something
is error_mark_node and return before calling note_integer_operands on it.
The following patch fixes it by not calling on error_mark_node, another
possibility would be to handle error_mark_node in note_integer_operands and
just return it.
2021-06-24 Jakub Jelinek <jakub@redhat.com>
PR c/101171
* c-typeck.c (build_c_cast): Don't call note_integer_operands on
error_mark_node.
* gcc.dg/pr101171.c: New test.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/c/c-typeck.c | 1 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr101171.c | 13 |
2 files changed, 14 insertions, 0 deletions
diff --git a/gcc/c/c-typeck.c b/gcc/c/c-typeck.c index d0d36c3..d079ce4 100644 --- a/gcc/c/c-typeck.c +++ b/gcc/c/c-typeck.c @@ -6131,6 +6131,7 @@ build_c_cast (location_t loc, tree type, tree expr) return value reflects this. */ if (int_operands && INTEGRAL_TYPE_P (type) + && value != error_mark_node && !EXPR_INT_CONST_OPERANDS (value)) value = note_integer_operands (value); diff --git a/gcc/testsuite/gcc.dg/pr101171.c b/gcc/testsuite/gcc.dg/pr101171.c new file mode 100644 index 0000000..8d2bcab --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr101171.c @@ -0,0 +1,13 @@ +/* PR c/101171 */ +/* { dg-do compile } */ +/* { dg-options "" } */ + +extern void foo (void); +int x = 0x1234; + +void +bar (void) +{ + if (x != (sizeof ((enum T) 0x1234))) /* { dg-error "conversion to incomplete type" } */ + foo (); +} |