diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2011-08-30 06:30:42 +0200 |
|---|---|---|
| committer | Jason Merrill <jason@gcc.gnu.org> | 2011-08-30 00:30:42 -0400 |
| commit | e7b6bcf3571f919b67a91141d56ddac2c377bbb7 (patch) | |
| tree | c3aa7e49d511db97026e1be585dacf2e4f566369 /gcc | |
| parent | 25dd2fdd4040158f1802913cd8407a77b8d0441b (diff) | |
| download | gcc-e7b6bcf3571f919b67a91141d56ddac2c377bbb7.zip gcc-e7b6bcf3571f919b67a91141d56ddac2c377bbb7.tar.gz gcc-e7b6bcf3571f919b67a91141d56ddac2c377bbb7.tar.bz2 | |
re PR c++/50207 (G++ segv's on reduced test case)
PR c++/50207
* class.c (finish_struct_1): Complain if the first field is
artificial.
Co-Authored-By: Jason Merrill <jason@redhat.com>
From-SVN: r178276
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/ChangeLog | 7 | ||||
| -rw-r--r-- | gcc/cp/class.c | 21 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/dfp/base.C | 23 |
4 files changed, 53 insertions, 3 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index d42d89a..17065de 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,10 @@ +2011-08-29 Jakub Jelinek <jakub@redhat.com> + Jason Merrill <jason@redhat.com> + + PR c++/50207 + * class.c (finish_struct_1): Complain if the first field is + artificial. + 2011-08-29 Jason Merrill <jason@redhat.com> PR c++/50209 diff --git a/gcc/cp/class.c b/gcc/cp/class.c index 6ebe758..2a4bc77 100644 --- a/gcc/cp/class.c +++ b/gcc/cp/class.c @@ -5795,10 +5795,25 @@ finish_struct_1 (tree t) /* Finish debugging output for this type. */ rest_of_type_compilation (t, ! LOCAL_CLASS_P (t)); - if (TYPE_TRANSPARENT_AGGR (t) && first_field (t) == NULL_TREE) + if (TYPE_TRANSPARENT_AGGR (t)) { - error ("type transparent class %qT does not have any fields", t); - TYPE_TRANSPARENT_AGGR (t) = 0; + tree field = first_field (t); + if (field == NULL_TREE || error_operand_p (field)) + { + error ("type transparent class %qT does not have any fields", t); + TYPE_TRANSPARENT_AGGR (t) = 0; + } + else if (DECL_ARTIFICIAL (field)) + { + if (DECL_FIELD_IS_BASE (field)) + error ("type transparent class %qT has base classes", t); + else + { + gcc_checking_assert (DECL_VIRTUAL_P (field)); + error ("type transparent class %qT has virtual functions", t); + } + TYPE_TRANSPARENT_AGGR (t) = 0; + } } } diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index c5208af..c503b69 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-08-29 Jakub Jelinek <jakub@redhat.com> + Jason Merrill <jason@redhat.com> + + * g++.dg/dfp/base.C: New test. + 2011-08-29 Jason Merrill <jason@redhat.com> Core DR 994 diff --git a/gcc/testsuite/g++.dg/dfp/base.C b/gcc/testsuite/g++.dg/dfp/base.C new file mode 100644 index 0000000..3e5dc50 --- /dev/null +++ b/gcc/testsuite/g++.dg/dfp/base.C @@ -0,0 +1,23 @@ +// PR c++/50207 +// { dg-do compile } + +namespace std +{ + namespace decimal + { + template <class _Fmt> struct _FmtTraits; + class decimal32; + template <> struct _FmtTraits <decimal32> + { + static const long _NumBytes = 4UL; + }; + template <class _Tr> class _DecBase + { + unsigned char _Bytes[_Tr::_NumBytes]; + }; + class decimal32 : public _DecBase <_FmtTraits <decimal32> > // { dg-error "has base" } + { + decimal32 () { } + }; + } +} |