diff options
| author | David Malcolm <dmalcolm@redhat.com> | 2024-01-04 09:12:40 -0500 |
|---|---|---|
| committer | David Malcolm <dmalcolm@redhat.com> | 2024-01-04 09:12:40 -0500 |
| commit | db5b01d282a0e3ddcac737e55f9758c8b081cf4b (patch) | |
| tree | 8ca4b673fa2ca19fb9c6270e7799cb6ae1b503e1 /gcc | |
| parent | 057dc349021660c40699fb5c98fd9cac8e168653 (diff) | |
| download | gcc-db5b01d282a0e3ddcac737e55f9758c8b081cf4b.zip gcc-db5b01d282a0e3ddcac737e55f9758c8b081cf4b.tar.gz gcc-db5b01d282a0e3ddcac737e55f9758c8b081cf4b.tar.bz2 | |
analyzer: handle arrays of unknown size in access diagrams [PR113222]
gcc/analyzer/ChangeLog:
PR analyzer/113222
* access-diagram.cc (valid_region_spatial_item::add_boundaries):
Handle TYPE_DOMAIN being null.
(valid_region_spatial_item::add_array_elements_to_table):
Likewise.
gcc/testsuite/ChangeLog:
PR analyzer/113222
* gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c: New test.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/analyzer/access-diagram.cc | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c | 26 |
2 files changed, 28 insertions, 2 deletions
diff --git a/gcc/analyzer/access-diagram.cc b/gcc/analyzer/access-diagram.cc index 25e6c92..9555ee8 100644 --- a/gcc/analyzer/access-diagram.cc +++ b/gcc/analyzer/access-diagram.cc @@ -1334,7 +1334,7 @@ public: logger->log ("showing first and final element in array type"); region_model_manager *mgr = m_op.m_model.get_manager (); tree domain = TYPE_DOMAIN (base_type); - if (TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain)) + if (domain && TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain)) { const svalue *min_idx_sval = mgr->get_or_create_constant_svalue (TYPE_MIN_VALUE (domain)); @@ -1364,7 +1364,7 @@ public: gcc_assert (m_boundaries != nullptr); tree domain = TYPE_DOMAIN (base_type); - if (!(TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain))) + if (!(domain && TYPE_MIN_VALUE (domain) && TYPE_MAX_VALUE (domain))) return; const int table_y = 0; diff --git a/gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c b/gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c new file mode 100644 index 0000000..4446766 --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/out-of-bounds-diagram-pr113222.c @@ -0,0 +1,26 @@ +/* Verify that we don't ICE when generating an out-of-bounds diagram + when the size of an array is unknown. */ + +/* { dg-do compile } */ +/* { dg-additional-options "-fdiagnostics-text-art-charset=unicode" } */ + +#include <stdint.h> + +struct sched_class +{ + int64_t f; +}; +extern struct sched_class __end_sched_classes[]; + +int +test () +{ + const struct sched_class* class = ((__end_sched_classes - 1)); + return class->f; /* { dg-warning "buffer under-read" } */ +} + +/* We don't care about the content of the diagram, just that we don't + ICE creating it. */ + +/* { dg-allow-blank-lines-in-output 1 } */ +/* { dg-prune-output ".*" } */ |