diff options
| author | Richard Biener <rguenther@suse.de> | 2015-12-10 09:05:58 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2015-12-10 09:05:58 +0000 |
| commit | d4f4e71c84fc7bcf21f45e315a07b1408f514f75 (patch) | |
| tree | 603382ded20cccc1a98ac7e6042bf71bb95e2a78 /gcc | |
| parent | 77ad31753c0440c4141e957edee243f739570587 (diff) | |
| download | gcc-d4f4e71c84fc7bcf21f45e315a07b1408f514f75.zip gcc-d4f4e71c84fc7bcf21f45e315a07b1408f514f75.tar.gz gcc-d4f4e71c84fc7bcf21f45e315a07b1408f514f75.tar.bz2 | |
re PR ipa/68721 (wrong code at -Os and above on x86_64-linux-gnu)
2015-12-10 Richard Biener <rguenther@suse.de>
PR ipa/68721
* ipa-split.c (split_function): Record return value properly
when the split part doesn't set it.
* gcc.dg/torture/pr68721.c: New testcase.
From-SVN: r231494
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/ipa-split.c | 3 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/torture/pr68721.c | 31 |
4 files changed, 44 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c990fc3..b5ee0be 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,11 @@ 2015-12-10 Richard Biener <rguenther@suse.de> + PR ipa/68721 + * ipa-split.c (split_function): Record return value properly + when the split part doesn't set it. + +2015-12-10 Richard Biener <rguenther@suse.de> + PR tree-optimization/68806 * tree-vect-loop.c (vect_analyze_loop_2): Properly detect reduction chains and ignore SLP reductions. diff --git a/gcc/ipa-split.c b/gcc/ipa-split.c index 56c954b..f77ab52 100644 --- a/gcc/ipa-split.c +++ b/gcc/ipa-split.c @@ -1281,7 +1281,7 @@ split_function (basic_block return_bb, struct split_point *split_point, to return void instead of just outputting function with undefined return value. For structures this affects quality of codegen. */ else if (!split_point->split_part_set_retval - && find_retval (return_bb)) + && (retval = find_retval (return_bb))) { bool redirected = true; basic_block new_return_bb = create_basic_block (NULL, 0, return_bb); @@ -1305,6 +1305,7 @@ split_function (basic_block return_bb, struct split_point *split_point, e->count = new_return_bb->count; add_bb_to_loop (new_return_bb, current_loops->tree_root); bitmap_set_bit (split_point->split_bbs, new_return_bb->index); + retbnd = find_retbnd (return_bb); } /* When we pass around the value, use existing return block. */ else diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a24de42..7ac1418 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,5 +1,10 @@ 2015-12-10 Richard Biener <rguenther@suse.de> + PR ipa/68721 + * gcc.dg/torture/pr68721.c: New testcase. + +2015-12-10 Richard Biener <rguenther@suse.de> + PR tree-optimization/68806 * gcc.dg/torture/pr68806.c: New testcase. diff --git a/gcc/testsuite/gcc.dg/torture/pr68721.c b/gcc/testsuite/gcc.dg/torture/pr68721.c new file mode 100644 index 0000000..297adab --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr68721.c @@ -0,0 +1,31 @@ +/* { dg-do run } */ + +extern void abort (void); + +int a, b, c, *d, **e = &d; + +int * +fn1 () +{ + for (;;) + { + for (; a;) + if (b) + abort (); + break; + } + for (; c;) + ; + return &a; +} + +int +main () +{ + *e = fn1 (); + + if (!d) + abort (); + + return 0; +} |