diff options
author | Marek Polacek <polacek@redhat.com> | 2017-07-25 09:49:08 +0000 |
---|---|---|
committer | Marek Polacek <mpolacek@gcc.gnu.org> | 2017-07-25 09:49:08 +0000 |
commit | d49718d6ff41cdf8ed6b013b9e099f7ec3541053 (patch) | |
tree | 1cb6cf103468770b4f76a042134eac5a3ae9a58b /gcc | |
parent | 0e82a9b9422447fe9730831a5072655e0f5780f7 (diff) | |
download | gcc-d49718d6ff41cdf8ed6b013b9e099f7ec3541053.zip gcc-d49718d6ff41cdf8ed6b013b9e099f7ec3541053.tar.gz gcc-d49718d6ff41cdf8ed6b013b9e099f7ec3541053.tar.bz2 |
re PR c/81364 (Bogus -Wmultistatement-macros warning)
PR c/81364
* c-parser.c (c_parser_else_body): Don't warn about multistatement
macro expansion if the body is in { }.
(c_parser_while_statement): Likewise.
(c_parser_for_statement): Likewise.
* Wmultistatement-macros-12.c: New test.
From-SVN: r250498
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/c/ChangeLog | 8 | ||||
-rw-r--r-- | gcc/c/c-parser.c | 9 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gcc/testsuite/c-c++-common/Wmultistatement-macros-12.c | 43 |
4 files changed, 62 insertions, 3 deletions
diff --git a/gcc/c/ChangeLog b/gcc/c/ChangeLog index bfa9e9a..4e4d20b 100644 --- a/gcc/c/ChangeLog +++ b/gcc/c/ChangeLog @@ -1,3 +1,11 @@ +2017-07-25 Marek Polacek <polacek@redhat.com> + + PR c/81364 + * c-parser.c (c_parser_else_body): Don't warn about multistatement + macro expansion if the body is in { }. + (c_parser_while_statement): Likewise. + (c_parser_for_statement): Likewise. + 2017-07-18 Nathan Sidwell <nathan@acm.org> * c-parser.c (c_parser_array_notation): Use TYPE_{MIN,MAX}_VALUE. diff --git a/gcc/c/c-parser.c b/gcc/c/c-parser.c index eae7689..16cd357 100644 --- a/gcc/c/c-parser.c +++ b/gcc/c/c-parser.c @@ -5557,7 +5557,8 @@ c_parser_else_body (c_parser *parser, const token_indent_info &else_tinfo, } else { - body_loc_after_labels = c_parser_peek_token (parser)->location; + if (!c_parser_next_token_is (parser, CPP_OPEN_BRACE)) + body_loc_after_labels = c_parser_peek_token (parser)->location; c_parser_statement_after_labels (parser, NULL, chain); } @@ -5811,6 +5812,7 @@ c_parser_while_statement (c_parser *parser, bool ivdep, bool *if_p) = get_token_indent_info (c_parser_peek_token (parser)); location_t loc_after_labels; + bool open_brace = c_parser_next_token_is (parser, CPP_OPEN_BRACE); body = c_parser_c99_block_statement (parser, if_p, &loc_after_labels); c_finish_loop (loc, cond, NULL, body, c_break_label, c_cont_label, true); add_stmt (c_end_compound_stmt (loc, block, flag_isoc99)); @@ -5820,7 +5822,7 @@ c_parser_while_statement (c_parser *parser, bool ivdep, bool *if_p) = get_token_indent_info (c_parser_peek_token (parser)); warn_for_misleading_indentation (while_tinfo, body_tinfo, next_tinfo); - if (next_tinfo.type != CPP_SEMICOLON) + if (next_tinfo.type != CPP_SEMICOLON && !open_brace) warn_for_multistatement_macros (loc_after_labels, next_tinfo.location, while_tinfo.location, RID_WHILE); @@ -6109,6 +6111,7 @@ c_parser_for_statement (c_parser *parser, bool ivdep, bool *if_p) = get_token_indent_info (c_parser_peek_token (parser)); location_t loc_after_labels; + bool open_brace = c_parser_next_token_is (parser, CPP_OPEN_BRACE); body = c_parser_c99_block_statement (parser, if_p, &loc_after_labels); if (is_foreach_statement) @@ -6122,7 +6125,7 @@ c_parser_for_statement (c_parser *parser, bool ivdep, bool *if_p) = get_token_indent_info (c_parser_peek_token (parser)); warn_for_misleading_indentation (for_tinfo, body_tinfo, next_tinfo); - if (next_tinfo.type != CPP_SEMICOLON) + if (next_tinfo.type != CPP_SEMICOLON && !open_brace) warn_for_multistatement_macros (loc_after_labels, next_tinfo.location, for_tinfo.location, RID_FOR); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index aef24ec..f3a4812 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2017-07-25 Marek Polacek <polacek@redhat.com> + + PR c/81364 + * Wmultistatement-macros-12.c: New test. + 2017-07-25 Kyrylo Tkachov <kyrylo.tkachov@arm.com> PR target/81414 diff --git a/gcc/testsuite/c-c++-common/Wmultistatement-macros-12.c b/gcc/testsuite/c-c++-common/Wmultistatement-macros-12.c new file mode 100644 index 0000000..ac8915c --- /dev/null +++ b/gcc/testsuite/c-c++-common/Wmultistatement-macros-12.c @@ -0,0 +1,43 @@ +/* PR c/81364 */ +/* { dg-do compile } */ +/* { dg-options "-Wmultistatement-macros" } */ + +#define FOO0 if (1) { } else +#define TST0 \ +void bar0 (void) \ +{ \ + FOO0 { } /* { dg-bogus "macro expands to multiple statements" } */ \ +} +TST0 + +#define FOO1 for (;;) +#define TST1 \ +void bar1 (void) \ +{ \ + FOO1 { } /* { dg-bogus "macro expands to multiple statements" } */ \ +} +TST1 + +#define FOO2 while (1) +#define TST2 \ +void bar2 (void) \ +{ \ + FOO2 { } /* { dg-bogus "macro expands to multiple statements" } */ \ +} +TST2 + +#define FOO3 switch (1) +#define TST3 \ +void bar3 (void) \ +{ \ + FOO3 { } /* { dg-bogus "macro expands to multiple statements" } */ \ +} +TST3 + +#define FOO4 if (1) +#define TST4 \ +void bar4 (void) \ +{ \ + FOO4 { } /* { dg-bogus "macro expands to multiple statements" } */ \ +} +TST4 |