diff options
| author | Ghjuvan Lacambre <lacambre@adacore.com> | 2021-03-28 14:10:53 +0200 |
|---|---|---|
| committer | Pierre-Marie de Rodat <derodat@adacore.com> | 2021-06-21 06:45:09 -0400 |
| commit | c1f1ef183691543a6dd342803f814252512fa249 (patch) | |
| tree | d88861bf2f26b54a9cf5e91f5264ea4875b70673 /gcc | |
| parent | e171a399ef7c552f40d6f4611bbd0c690e095ab7 (diff) | |
| download | gcc-c1f1ef183691543a6dd342803f814252512fa249.zip gcc-c1f1ef183691543a6dd342803f814252512fa249.tar.gz gcc-c1f1ef183691543a6dd342803f814252512fa249.tar.bz2 | |
[Ada] Address ??? comments
gcc/ada/
* exp_ch9.adb (Build_Simple_Entry_Call): Add comment.
* libgnat/s-rannum.adb (Random): Update comment.
* libgnat/s-rannum.ads (Generator): Update comment.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ada/exp_ch9.adb | 6 | ||||
| -rw-r--r-- | gcc/ada/libgnat/s-rannum.adb | 5 | ||||
| -rw-r--r-- | gcc/ada/libgnat/s-rannum.ads | 4 |
3 files changed, 12 insertions, 3 deletions
diff --git a/gcc/ada/exp_ch9.adb b/gcc/ada/exp_ch9.adb index 3948b6a..6b1e284 100644 --- a/gcc/ada/exp_ch9.adb +++ b/gcc/ada/exp_ch9.adb @@ -282,7 +282,11 @@ package body Exp_Ch9 is Concval : Node_Id; Ename : Node_Id; Index : Node_Id); - -- Some comments here would be useful ??? + -- Build the call corresponding to the task entry call. N is the task entry + -- call, Concval is the concurrent object, Ename is the entry name and + -- Index is the entry family index. + -- Note that N might be expanded into an N_Block_Statement if it gets + -- inlined. function Build_Task_Proc_Specification (T : Entity_Id) return Node_Id; -- This routine constructs a specification for the procedure that we will diff --git a/gcc/ada/libgnat/s-rannum.adb b/gcc/ada/libgnat/s-rannum.adb index 8769167..0a1565b 100644 --- a/gcc/ada/libgnat/s-rannum.adb +++ b/gcc/ada/libgnat/s-rannum.adb @@ -178,7 +178,10 @@ is function Random (Gen : Generator) return Unsigned_32 is G : Generator renames Gen.Writable.Self.all; Y : State_Val; - I : Integer; -- should avoid use of identifier I ??? + I : Integer; + -- Naming exception: I is fine to use here as it is the name used in + -- the original paper describing the Mersenne Twister and in common + -- descriptions of the algorithm. begin I := G.I; diff --git a/gcc/ada/libgnat/s-rannum.ads b/gcc/ada/libgnat/s-rannum.ads index 855b5b5..370a079 100644 --- a/gcc/ada/libgnat/s-rannum.ads +++ b/gcc/ada/libgnat/s-rannum.ads @@ -162,7 +162,9 @@ private I : Integer := N; -- Current starting position in shift register S (N means uninitialized) - -- We should avoid using the identifier I here ??? + -- Naming exception: I is fine to use here as it is the name used in the + -- original paper describing the Mersenne Twister and in common + -- descriptions of the algorithm. end record; end System.Random_Numbers; |