diff options
| author | Richard Biener <rguenther@suse.de> | 2014-03-04 08:47:55 +0000 |
|---|---|---|
| committer | Richard Biener <rguenth@gcc.gnu.org> | 2014-03-04 08:47:55 +0000 |
| commit | b75f28e1aef56750fb163c3ee580474f0a0a4dc5 (patch) | |
| tree | d20b75cfb74602234e8c13fa55fab3138dcc0945 /gcc | |
| parent | 03aac9ce62d5be02e786965125bcca50fe9f0106 (diff) | |
| download | gcc-b75f28e1aef56750fb163c3ee580474f0a0a4dc5.zip gcc-b75f28e1aef56750fb163c3ee580474f0a0a4dc5.tar.gz gcc-b75f28e1aef56750fb163c3ee580474f0a0a4dc5.tar.bz2 | |
re PR tree-optimization/60382 (ICE on valid code at -O3 on x86_64-linux-gnu (in vect_create_epilog_for_reduction, at tree-vect-loop.c:4352))
2014-03-04 Richard Biener <rguenther@suse.de>
PR tree-optimization/60382
* tree-vect-loop.c (vect_is_simple_reduction_1): Do not consider
dead PHIs a reduction.
* gcc.dg/vect/pr60382.c: New testcase.
From-SVN: r208305
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/vect/pr60382.c | 32 | ||||
| -rw-r--r-- | gcc/tree-vect-loop.c | 6 |
4 files changed, 49 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6f5bd57..ee70301 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2014-03-04 Richard Biener <rguenther@suse.de> + + PR tree-optimization/60382 + * tree-vect-loop.c (vect_is_simple_reduction_1): Do not consider + dead PHIs a reduction. + 2014-03-03 Uros Bizjak <ubizjak@gmail.com> * config/i386/xmmintrin.h (enum _mm_hint) <_MM_HINT_ET0>: Correct diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 3b0f810..7ba86f7 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-03-04 Richard Biener <rguenther@suse.de> + + PR tree-optimization/60382 + * gcc.dg/vect/pr60382.c: New testcase. + 2014-03-03 Jerry DeLisle <jvdelisle@gcc.gnu> PR libfortran/60148 diff --git a/gcc/testsuite/gcc.dg/vect/pr60382.c b/gcc/testsuite/gcc.dg/vect/pr60382.c new file mode 100644 index 0000000..a28c631 --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr60382.c @@ -0,0 +1,32 @@ +#include "tree-vect.h" + +int a, b, c, e, f; + +void +foo () +{ + for (b = 0; b < 3; b++) + if (e) + { + for (c = 0; c < 4; c++) + { + if (b) + continue; + f = 1; + for (a = 0; a < 2; a++) + f |= 1; + } + for (;;) + ; + } +} + +int +main () +{ + check_vect (); + foo (); + return 0; +} + +/* { dg-final { cleanup-tree-dump "vect" } } */ diff --git a/gcc/tree-vect-loop.c b/gcc/tree-vect-loop.c index 838803e..df6ab6f 100644 --- a/gcc/tree-vect-loop.c +++ b/gcc/tree-vect-loop.c @@ -2193,6 +2193,12 @@ vect_is_simple_reduction_1 (loop_vec_info loop_info, gimple phi, || (!check_reduction && flow_loop_nested_p (vect_loop, loop))); name = PHI_RESULT (phi); + /* ??? If there are no uses of the PHI result the inner loop reduction + won't be detected as possibly double-reduction by vectorizable_reduction + because that tries to walk the PHI arg from the preheader edge which + can be constant. See PR60382. */ + if (has_zero_uses (name)) + return NULL; nloop_uses = 0; FOR_EACH_IMM_USE_FAST (use_p, imm_iter, name) { |