diff options
author | Takayuki 'January June' Suwa <jjsuwa_sys3175@yahoo.co.jp> | 2022-05-13 22:26:30 +0900 |
---|---|---|
committer | Max Filippov <jcmvbkbc@gmail.com> | 2022-05-26 09:40:14 -0700 |
commit | b753405a5f0d45eea97f4cc7df2c2089401b08bf (patch) | |
tree | 7975b2b5376f3702d87ca85c8958f54abb3d90a7 /gcc | |
parent | 47b20d027ade5bfbd932724d0ea2aedee7421243 (diff) | |
download | gcc-b753405a5f0d45eea97f4cc7df2c2089401b08bf.zip gcc-b753405a5f0d45eea97f4cc7df2c2089401b08bf.tar.gz gcc-b753405a5f0d45eea97f4cc7df2c2089401b08bf.tar.bz2 |
xtensa: Simplify EXTUI instruction maskimm validations
No functional changes.
gcc/ChangeLog:
* config/xtensa/predicates.md (extui_fldsz_operand): Simplify.
* config/xtensa/xtensa.cc (xtensa_mask_immediate, print_operand):
Ditto.
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/config/xtensa/predicates.md | 2 | ||||
-rw-r--r-- | gcc/config/xtensa/xtensa.cc | 24 |
2 files changed, 4 insertions, 22 deletions
diff --git a/gcc/config/xtensa/predicates.md b/gcc/config/xtensa/predicates.md index 01226a2..daea63b 100644 --- a/gcc/config/xtensa/predicates.md +++ b/gcc/config/xtensa/predicates.md @@ -55,7 +55,7 @@ (define_predicate "extui_fldsz_operand" (and (match_code "const_int") - (match_test "xtensa_mask_immediate ((1 << INTVAL (op)) - 1)"))) + (match_test "IN_RANGE (INTVAL (op), 1, 16)"))) (define_predicate "sext_operand" (if_then_else (match_test "TARGET_SEXT") diff --git a/gcc/config/xtensa/xtensa.cc b/gcc/config/xtensa/xtensa.cc index 7023bad..a1f77b2 100644 --- a/gcc/config/xtensa/xtensa.cc +++ b/gcc/config/xtensa/xtensa.cc @@ -456,19 +456,7 @@ xtensa_b4constu (HOST_WIDE_INT v) bool xtensa_mask_immediate (HOST_WIDE_INT v) { -#define MAX_MASK_SIZE 16 - int mask_size; - - for (mask_size = 1; mask_size <= MAX_MASK_SIZE; mask_size++) - { - if ((v & 1) == 0) - return false; - v = v >> 1; - if (v == 0) - return true; - } - - return false; + return IN_RANGE (exact_log2 (v + 1), 1, 16); } @@ -2430,17 +2418,11 @@ print_operand (FILE *file, rtx x, int letter) case 'K': if (GET_CODE (x) == CONST_INT) { - int num_bits = 0; unsigned val = INTVAL (x); - while (val & 1) - { - num_bits += 1; - val = val >> 1; - } - if ((val != 0) || (num_bits == 0) || (num_bits > 16)) + if (!xtensa_mask_immediate (val)) fatal_insn ("invalid mask", x); - fprintf (file, "%d", num_bits); + fprintf (file, "%d", floor_log2 (val + 1)); } else output_operand_lossage ("invalid %%K value"); |