diff options
| author | Diego Novillo <dnovillo@redhat.com> | 2001-04-05 02:27:47 +0000 |
|---|---|---|
| committer | Diego Novillo <dnovillo@gcc.gnu.org> | 2001-04-04 22:27:47 -0400 |
| commit | b08355783200651f189f2f057663e12f9755bb92 (patch) | |
| tree | 102c5ecab55ff14b05898ff73ce3c22e9dd1cd40 /gcc | |
| parent | 12f0b96b84e334fb3b1d582a19079abdf0fb054f (diff) | |
| download | gcc-b08355783200651f189f2f057663e12f9755bb92.zip gcc-b08355783200651f189f2f057663e12f9755bb92.tar.gz gcc-b08355783200651f189f2f057663e12f9755bb92.tar.bz2 | |
simplify-rtx.c (simplify_binary_operation): Check for overflow when folding integer division and modulo operations.
2001-04-04 Diego Novillo <dnovillo@redhat.com>
* simplify-rtx.c (simplify_binary_operation): Check for overflow
when folding integer division and modulo operations.
2001-04-04 Diego Novillo <dnovillo@redhat.com>
* gcc.c-torture/compile/20010404-1.c: New test.
From-SVN: r41105
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/simplify-rtx.c | 16 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.c-torture/compile/20010404-1.c | 15 |
4 files changed, 36 insertions, 4 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index e7444c9..cfc9306 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2001-04-04 Diego Novillo <dnovillo@redhat.com> + + * simplify-rtx.c (simplify_binary_operation): Check for overflow + when folding integer division and modulo operations. + 2001-04-04 Andrew MacLeod <amacleod@redhat.com> * dwarf2out.c (output_cfi): Add 'for_eh' parameter, use PTR_SIZE diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c index dd7d2e1..af8b708 100644 --- a/gcc/simplify-rtx.c +++ b/gcc/simplify-rtx.c @@ -1407,25 +1407,33 @@ simplify_binary_operation (code, mode, op0, op1) break; case DIV: - if (arg1s == 0) + if (arg1s == 0 + || (arg0s == (HOST_WIDE_INT) 1 << (HOST_BITS_PER_WIDE_INT - 1) + && arg1s == -1)) return 0; val = arg0s / arg1s; break; case MOD: - if (arg1s == 0) + if (arg1s == 0 + || (arg0s == (HOST_WIDE_INT) 1 << (HOST_BITS_PER_WIDE_INT - 1) + && arg1s == -1)) return 0; val = arg0s % arg1s; break; case UDIV: - if (arg1 == 0) + if (arg1 == 0 + || (arg0s == (HOST_WIDE_INT) 1 << (HOST_BITS_PER_WIDE_INT - 1) + && arg1s == -1)) return 0; val = (unsigned HOST_WIDE_INT) arg0 / arg1; break; case UMOD: - if (arg1 == 0) + if (arg1 == 0 + || (arg0s == (HOST_WIDE_INT) 1 << (HOST_BITS_PER_WIDE_INT - 1) + && arg1s == -1)) return 0; val = (unsigned HOST_WIDE_INT) arg0 % arg1; break; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 225f928..5e4c155 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2001-04-04 Diego Novillo <dnovillo@redhat.com> + + * gcc.c-torture/compile/20010404-1.c: New test. + 2001-04-04 Jakub Jelinek <jakub@redhat.com> * gcc.c-torture/compile/20010326-1.c: New test. diff --git a/gcc/testsuite/gcc.c-torture/compile/20010404-1.c b/gcc/testsuite/gcc.c-torture/compile/20010404-1.c new file mode 100644 index 0000000..f890118 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/20010404-1.c @@ -0,0 +1,15 @@ +/* This testcase caused a floating point exception in the compiler when + compiled with -O2. The crash occurs when trying to simplify division + and modulo operations. */ + +#include <limits.h> + +extern void bar (int); + +void foo () +{ + int a = INT_MIN; + int b = -1; + bar (a / b); + bar (a % b); +} |