diff options
| author | Marek Polacek <polacek@redhat.com> | 2022-03-09 11:23:15 -0500 |
|---|---|---|
| committer | Marek Polacek <polacek@redhat.com> | 2022-03-10 09:31:34 -0500 |
| commit | ac8310dd122172bf9d7217e3367da55f9bf9b21b (patch) | |
| tree | 0a8305611b9ec38fbf3ad7e08755f5b8e18d6fb1 /gcc | |
| parent | e46843ff75c37c705811e0c13bb469eda13b5f6c (diff) | |
| download | gcc-ac8310dd122172bf9d7217e3367da55f9bf9b21b.zip gcc-ac8310dd122172bf9d7217e3367da55f9bf9b21b.tar.gz gcc-ac8310dd122172bf9d7217e3367da55f9bf9b21b.tar.bz2 | |
c++: ICE with operator delete [PR104846]
This is an ICE-on-invalid with "auto operator delete[] (void *)" whose
return type must be void. The return type is checked in coerce_delete_type
but we never got there in this test, because we took the wrong path in
grokdeclarator, set type to error_mark_node, ended up creating a FIELD_DECL
with build_decl, and confused grokmethod by giving it a FIELD_DECL.
Fixed by not taking the data member path for a FUNCTION_TYPE.
PR c++/104846
gcc/cp/ChangeLog:
* decl.cc (grokdeclarator): Check FUNC_OR_METHOD_TYPE_P before giving
data member errors.
gcc/testsuite/ChangeLog:
* g++.dg/init/delete5.C: New test.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/decl.cc | 2 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/init/delete5.C | 8 |
2 files changed, 9 insertions, 1 deletions
diff --git a/gcc/cp/decl.cc b/gcc/cp/decl.cc index 37d52d8..c42be60 100644 --- a/gcc/cp/decl.cc +++ b/gcc/cp/decl.cc @@ -13751,7 +13751,7 @@ grokdeclarator (const cp_declarator *declarator, } else if (decl_context == FIELD) { - if (!staticp && !friendp && TREE_CODE (type) != METHOD_TYPE) + if (!staticp && !friendp && !FUNC_OR_METHOD_TYPE_P (type)) if (tree auto_node = type_uses_auto (type)) { location_t tloc = declspecs->locations[ds_type_spec]; diff --git a/gcc/testsuite/g++.dg/init/delete5.C b/gcc/testsuite/g++.dg/init/delete5.C new file mode 100644 index 0000000..3555f43 --- /dev/null +++ b/gcc/testsuite/g++.dg/init/delete5.C @@ -0,0 +1,8 @@ +// PR c++/104846 +// { dg-do compile { target c++14 } } + +struct S { + auto operator delete (void *) {} // { dg-error ".operator delete. must return type .void'" } + auto operator delete[] (void *) {} // { dg-error ".operator delete. must return type .void'" } +}; + |