diff options
| author | Tamar Christina <tamar.christina@arm.com> | 2018-10-04 13:06:59 +0000 |
|---|---|---|
| committer | Tamar Christina <tnfchris@gcc.gnu.org> | 2018-10-04 13:06:59 +0000 |
| commit | ac712e4eb43f3dd8d7f12624ea4014ecb2a9cf34 (patch) | |
| tree | a540c09dec8245ba44904ec75d2f9b6a64e0fddb /gcc | |
| parent | 3edbcdbead288664d874dd3a2e0d8ada4c565af0 (diff) | |
| download | gcc-ac712e4eb43f3dd8d7f12624ea4014ecb2a9cf34.zip gcc-ac712e4eb43f3dd8d7f12624ea4014ecb2a9cf34.tar.gz gcc-ac712e4eb43f3dd8d7f12624ea4014ecb2a9cf34.tar.bz2 | |
Remove superfluous assignment in add_params.
This fixes the superfluous assignment that Coverity reported in add_params,
and changes the starting index from 0 to num_params - n in order for it to
work properly if add_params is called multiple times.
validate_params calls error so it doesn't matter that we don't check the
results here. The results is checked in individual parameter updates after
front-end initialization.
2018-10-04 Tamar Christina <tamar.christina@arm.com>
* params.c (add_params): Fix initialization.
From-SVN: r264841
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 4 | ||||
| -rw-r--r-- | gcc/params.c | 10 |
2 files changed, 8 insertions, 6 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index fdae3d1..21631ae 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2018-10-04 Tamar Christina <tamar.christina@arm.com> + + * params.c (add_params): Fix initialization. + 2018-10-04 Martin Liska <mliska@suse.cz> PR gcov-profile/84107 diff --git a/gcc/params.c b/gcc/params.c index b6a33df..af47396 100644 --- a/gcc/params.c +++ b/gcc/params.c @@ -87,12 +87,10 @@ add_params (const param_info params[], size_t n) if (!diagnostic_ready_p ()) diagnostic_initialize (global_dc, 0); - /* Now perform some validation and set the value if it validates. */ - for (size_t i = 0; i < n; i++) - { - if (validate_param (dst_params[i].default_value, dst_params[i], (int)i)) - dst_params[i].default_value = dst_params[i].default_value; - } + /* Now perform some validation and validation failures trigger an error so + initialization will stop. */ + for (size_t i = num_compiler_params - n; i < n; i++) + validate_param (params[i].default_value, params[i], (int)i); } /* Add all parameters and default values that can be set in both the |