diff options
| author | Andrew Pinski <pinskia@gcc.gnu.org> | 2006-08-25 00:13:48 -0700 |
|---|---|---|
| committer | Andrew Pinski <pinskia@gcc.gnu.org> | 2006-08-25 00:13:48 -0700 |
| commit | aa666e00632d6f6433ad549eb061e9c568708edd (patch) | |
| tree | f40e0754fe57cf6ccebf878a32456f5dde203129 /gcc | |
| parent | a073516d43b79060b506f67083d291832c706a93 (diff) | |
| download | gcc-aa666e00632d6f6433ad549eb061e9c568708edd.zip gcc-aa666e00632d6f6433ad549eb061e9c568708edd.tar.gz gcc-aa666e00632d6f6433ad549eb061e9c568708edd.tar.bz2 | |
re PR tree-optimization/28807 (wrong code with may_alias and structs)
2006-08-24 Andrew Pinski <pinskia@physics.uc.edu>
PR tree-opt/28807
* tree-ssa-operands.c (access_can_touch_variable): Don't say
the access through a base which has an alias set of 0 cannot
touch the variable.
2006-08-24 Andrew Pinski <pinskia@physics.uc.edu>
PR tree-opt/28807
* gcc.c-torture/execute/mayalias-2.c: New test.
* gcc.dg/tree-ssa/alias-13.c: New test.
From-SVN: r116393
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 9 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.c-torture/execute/mayalias-2.c | 17 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/tree-ssa/alias-13.c | 33 | ||||
| -rw-r--r-- | gcc/tree-ssa-operands.c | 5 |
5 files changed, 68 insertions, 2 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 5d27b87..d6d4d01 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,4 +1,11 @@ -2006-08-24 Bill Wendling <wendling@apple.com> +2006-08-24 Andrew Pinski <pinskia@physics.uc.edu> + + PR tree-opt/28807 + * tree-ssa-operands.c (access_can_touch_variable): Don't say + the access through a base which has an alias set of 0 cannot + touch the variable. + +2006-08-24 Bill Wendling <wendling@apple.com> * doc/tm.texi (TARGET_DEFAULT_PACK_STRUCT): Fixed English. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 92a3acb..e7d53d3 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2006-08-24 Andrew Pinski <pinskia@physics.uc.edu> + + PR tree-opt/28807 + * gcc.c-torture/execute/mayalias-2.c: New test. + * gcc.dg/tree-ssa/alias-13.c: New test. + 2006-08-24 Jan Hubicka <jh@suse.cz> PR debug/26881 diff --git a/gcc/testsuite/gcc.c-torture/execute/mayalias-2.c b/gcc/testsuite/gcc.c-torture/execute/mayalias-2.c new file mode 100644 index 0000000..5a1a9d5 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/execute/mayalias-2.c @@ -0,0 +1,17 @@ +struct S { short x; }; +typedef struct S __attribute__((__may_alias__)) test; + +int f() { + int a=10; + test *p=(test *)&a; + p->x = 1; + return a; +} + +int main() { + if (f() == 10) + __builtin_abort(); + return 0; +} + + diff --git a/gcc/testsuite/gcc.dg/tree-ssa/alias-13.c b/gcc/testsuite/gcc.dg/tree-ssa/alias-13.c new file mode 100644 index 0000000..ae7cc82 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/alias-13.c @@ -0,0 +1,33 @@ +/* { dg-do link } */ +/* { dg-options "-O2" } */ + + +struct a +{ + char a1; +}; + +int *aa; + +void g(int *a) +{ + aa = a; + *a = 2; +} + +int t(int i, struct a *b) +{ + g(&i); + b->a1 = 1; + i = 2; + if (b->a1 != 1) + link_failure (); +} +int main(void) +{ + struct a b; + t(1, &b); + return 0; +} + + diff --git a/gcc/tree-ssa-operands.c b/gcc/tree-ssa-operands.c index 0563781..0e931ca 100644 --- a/gcc/tree-ssa-operands.c +++ b/gcc/tree-ssa-operands.c @@ -1150,7 +1150,10 @@ access_can_touch_variable (tree ref, tree alias, HOST_WIDE_INT offset, || TREE_CODE (TREE_TYPE (base)) != UNION_TYPE) && !AGGREGATE_TYPE_P (TREE_TYPE (alias)) && TREE_CODE (TREE_TYPE (alias)) != COMPLEX_TYPE - && !POINTER_TYPE_P (TREE_TYPE (alias))) + && !POINTER_TYPE_P (TREE_TYPE (alias)) + /* When the struct has may_alias attached to it, we need not to + return true. */ + && get_alias_set (base)) { #ifdef ACCESS_DEBUGGING fprintf (stderr, "Access to "); |