diff options
| author | Paolo Carlini <paolo.carlini@oracle.com> | 2012-03-29 22:45:46 +0000 |
|---|---|---|
| committer | Paolo Carlini <paolo@gcc.gnu.org> | 2012-03-29 22:45:46 +0000 |
| commit | 9f693d564fabf90cae085d9d042ef46b697cb807 (patch) | |
| tree | faf9bc9290b6865b19eb1c4e24fa616af2a800fa /gcc | |
| parent | b9bebd7f03e0117bf488ed687ff752f8a0595b8e (diff) | |
| download | gcc-9f693d564fabf90cae085d9d042ef46b697cb807.zip gcc-9f693d564fabf90cae085d9d042ef46b697cb807.tar.gz gcc-9f693d564fabf90cae085d9d042ef46b697cb807.tar.bz2 | |
re PR c++/52718 (-Wzero-as-null-pointer-constant: misleading location for 0 as default argument)
/cp
2012-03-29 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/52718
* decl.c (check_default_argument): With -Wzero-as-null-pointer-constant
warn for a zero as null pointer constant default argument.
/testsuite
2012-03-29 Paolo Carlini <paolo.carlini@oracle.com>
PR c++/52718
* g++.dg/warn/Wzero-as-null-pointer-constant-5.C: New.
From-SVN: r185983
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/cp/decl.c | 11 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/g++.dg/warn/Wzero-as-null-pointer-constant-5.C | 20 |
4 files changed, 42 insertions, 0 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index af7fa2d..7e4e549 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2012-03-29 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/52718 + * decl.c (check_default_argument): With -Wzero-as-null-pointer-constant + warn for a zero as null pointer constant default argument. + 2012-03-29 Jason Merrill <jason@redhat.com> PR c++/52685 diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 8c5fda6..a89523d 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -10596,6 +10596,17 @@ check_default_argument (tree decl, tree arg) return error_mark_node; } + if (warn_zero_as_null_pointer_constant + && c_inhibit_evaluation_warnings == 0 + && (POINTER_TYPE_P (decl_type) || TYPE_PTR_TO_MEMBER_P (decl_type)) + && null_ptr_cst_p (arg) + && !NULLPTR_TYPE_P (TREE_TYPE (arg))) + { + warning (OPT_Wzero_as_null_pointer_constant, + "zero as null pointer constant"); + return nullptr_node; + } + /* [dcl.fct.default] Local variables shall not be used in default argument diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index d25b4d9..498218a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2012-03-29 Paolo Carlini <paolo.carlini@oracle.com> + + PR c++/52718 + * g++.dg/warn/Wzero-as-null-pointer-constant-5.C: New. + 2012-03-29 Jason Merrill <jason@redhat.com> PR c++/52685 diff --git a/gcc/testsuite/g++.dg/warn/Wzero-as-null-pointer-constant-5.C b/gcc/testsuite/g++.dg/warn/Wzero-as-null-pointer-constant-5.C new file mode 100644 index 0000000..185d2b5 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wzero-as-null-pointer-constant-5.C @@ -0,0 +1,20 @@ +// PR c++/52718 +// { dg-options "-Wzero-as-null-pointer-constant" } + +struct foo +{ + foo(void* a = 0) {}; // { dg-warning "zero as null pointer" } +}; + +void* fun(void* a = 0) {}; // { dg-warning "zero as null pointer" } + +struct bar: foo +{ + bar() {}; +}; + +struct baz +{ + baz(const foo& f1 = foo(), + void* f2 = fun()) {}; +}; |