diff options
| author | Haochen Gui <guihaoc@gcc.gnu.org> | 2022-12-08 13:22:29 +0800 |
|---|---|---|
| committer | Haochen Gui <guihaoc@gcc.gnu.org> | 2022-12-13 16:32:15 +0800 |
| commit | 99cce60d0b8f3c3a77be8e1bb716f3e2fee37d46 (patch) | |
| tree | 1de5acddb0b9189cacd33c59c74f18b0b62106f0 /gcc | |
| parent | 1728c537b4f697e2a4b4eba0b0c70165f2a02840 (diff) | |
| download | gcc-99cce60d0b8f3c3a77be8e1bb716f3e2fee37d46.zip gcc-99cce60d0b8f3c3a77be8e1bb716f3e2fee37d46.tar.gz gcc-99cce60d0b8f3c3a77be8e1bb716f3e2fee37d46.tar.bz2 | |
optabs: make prepare_cmp_insn goto fail when cbranchcc4 checks unsatisfied
prepare_cmp_insn is a help function to generate comparison rtx.
It should not assume that cbranchcc4 exists and all sub-CC modes
are supported on a target. When the check fails, it could go to
fail and return a NULL rtx as its callers check the return value
for CCmode.
The test case (gcc.target/powerpc/cbranchcc4-1.c) which covers
failure path will be committed with an rs6000 specific patch.
2022-12-05 Haochen Gui <guihaoc@linux.ibm.com>
gcc/
* optabs.cc (prepare_cmp_insn): Return a NULL rtx other than
assertion failure when targets don't have cbranch optab or
predicate check fails.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/optabs.cc | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/gcc/optabs.cc b/gcc/optabs.cc index 262a37f..2ffd455 100644 --- a/gcc/optabs.cc +++ b/gcc/optabs.cc @@ -4491,10 +4491,14 @@ prepare_cmp_insn (rtx x, rtx y, enum rtx_code comparison, rtx size, { enum insn_code icode = optab_handler (cbranch_optab, CCmode); test = gen_rtx_fmt_ee (comparison, VOIDmode, x, y); - gcc_assert (icode != CODE_FOR_nothing - && insn_operand_matches (icode, 0, test)); - *ptest = test; - return; + if (icode != CODE_FOR_nothing + && insn_operand_matches (icode, 0, test)) + { + *ptest = test; + return; + } + else + goto fail; } test = gen_rtx_fmt_ee (comparison, VOIDmode, x, y); |