diff options
| author | David Malcolm <dmalcolm@redhat.com> | 2024-02-27 14:49:42 -0500 |
|---|---|---|
| committer | David Malcolm <dmalcolm@redhat.com> | 2024-02-27 17:17:12 -0500 |
| commit | 939439a90f234f9e70d30240bf5c227eebe2b43f (patch) | |
| tree | 487426ac5368f3eab5ab182d22ed618f27ab384d /gcc | |
| parent | 15d1dae0d4d1be88d28ad7578a60fd3e36de36d8 (diff) | |
| download | gcc-939439a90f234f9e70d30240bf5c227eebe2b43f.zip gcc-939439a90f234f9e70d30240bf5c227eebe2b43f.tar.gz gcc-939439a90f234f9e70d30240bf5c227eebe2b43f.tar.bz2 | |
analyzer: use correct format code for string literal indices [PR110483,PR111802]
On e.g. gcc211 the use of "%li" with unsigned HOST_WIDE_INT led to this warning:
../../src/gcc/analyzer/access-diagram.cc: In member function ‘void ana::string_literal_spatial_item::add_column_for_byte(text_art::table&, const ana::bit_to_table_map&, text_art::style_manager&, ana::byte_offset_t, ana::byte_offset_t, int, int) const’:
../../src/gcc/analyzer/access-diagram.cc:1909:40: warning: format ‘%li’ expects argument of type ‘long int’, but argument 3 has type ‘long long unsigned int’ [-Wformat=]
byte_idx_within_string.ulow ()));
^
and to all values being erroneously printed as "0".
Fixed thusly.
gcc/analyzer/ChangeLog:
PR analyzer/110483
PR analyzer/111802
* access-diagram.cc
(string_literal_spatial_item::add_column_for_byte): Use %wu for
printing unsigned HOST_WIDE_INT.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/analyzer/access-diagram.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gcc/analyzer/access-diagram.cc b/gcc/analyzer/access-diagram.cc index 9555ee8..24d203f 100644 --- a/gcc/analyzer/access-diagram.cc +++ b/gcc/analyzer/access-diagram.cc @@ -1905,7 +1905,7 @@ private: const table::rect_t idx_table_rect = btm.get_table_rect (&m_string_reg, bytes, byte_idx_table_y, 1); t.set_cell_span (idx_table_rect, - fmt_styled_string (sm, "[%li]", + fmt_styled_string (sm, "[%wu]", byte_idx_within_string.ulow ())); } |