diff options
| author | Richard Biener <rguenther@suse.de> | 2024-01-18 13:23:27 +0100 |
|---|---|---|
| committer | Richard Biener <rguenther@suse.de> | 2024-01-18 14:13:03 +0100 |
| commit | 895a2138265fd9cace3588404523122f73626d2a (patch) | |
| tree | 47e3097599c3ea22b85d94e8eb257ebbe5d9541a /gcc | |
| parent | 5b421c2a5b429fcebd7ee6444a5677633df0f28a (diff) | |
| download | gcc-895a2138265fd9cace3588404523122f73626d2a.zip gcc-895a2138265fd9cace3588404523122f73626d2a.tar.gz gcc-895a2138265fd9cace3588404523122f73626d2a.tar.bz2 | |
tree-optimization/113475 - fix memory leak in phi_analyzer
phi_analyzer leaks all phi_group objects it allocates. The following
fixes this by maintaining a vector of allocated objects and release
them when destroying the phi_analyzer object.
PR tree-optimization/113475
* gimple-range-phi.h (phi_analyzer::m_phi_groups): New.
* gimple-range-phi.cc (phi_analyzer::phi_analyzer): Initialize.
(phi_analyzer::~phi_analyzer): Deallocate and free collected
phi_grous.
(phi_analyzer::process_phi): Record allocated phi_groups.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/gimple-range-phi.cc | 6 | ||||
| -rw-r--r-- | gcc/gimple-range-phi.h | 1 |
2 files changed, 6 insertions, 1 deletions
diff --git a/gcc/gimple-range-phi.cc b/gcc/gimple-range-phi.cc index 5aee761..01900a3 100644 --- a/gcc/gimple-range-phi.cc +++ b/gcc/gimple-range-phi.cc @@ -254,7 +254,7 @@ phi_group::dump (FILE *f) // Construct a phi analyzer which uses range_query G to pick up values. -phi_analyzer::phi_analyzer (range_query &g) : m_global (g) +phi_analyzer::phi_analyzer (range_query &g) : m_global (g), m_phi_groups (vNULL) { m_work.create (0); m_work.safe_grow (20); @@ -273,6 +273,9 @@ phi_analyzer::~phi_analyzer () bitmap_obstack_release (&m_bitmaps); m_tab.release (); m_work.release (); + for (auto grp : m_phi_groups) + delete grp; + m_phi_groups.release (); } // Return the group, if any, that NAME is part of. Do no analysis. @@ -458,6 +461,7 @@ phi_analyzer::process_phi (gphi *phi) if (!cyc.range ().varying_p ()) { g = new phi_group (cyc); + m_phi_groups.safe_push (g); if (dump_file && (dump_flags & TDF_DETAILS)) { fprintf (dump_file, "PHI ANALYZER : New "); diff --git a/gcc/gimple-range-phi.h b/gcc/gimple-range-phi.h index 04747ba..a40aece 100644 --- a/gcc/gimple-range-phi.h +++ b/gcc/gimple-range-phi.h @@ -87,6 +87,7 @@ protected: bitmap m_simple; // Processed, not part of a group. bitmap m_current; // Potential group currently being analyzed. + vec<phi_group *> m_phi_groups; vec<phi_group *> m_tab; bitmap_obstack m_bitmaps; }; |