diff options
author | Marek Polacek <polacek@redhat.com> | 2013-04-22 17:02:49 +0000 |
---|---|---|
committer | Marek Polacek <mpolacek@gcc.gnu.org> | 2013-04-22 17:02:49 +0000 |
commit | 829d0168e6816e2b309bc75f4e23d28656ceed6f (patch) | |
tree | 4be5c0822b6964735a77d9c3f84745cfd4e39abb /gcc | |
parent | 6d9b720879c18b7f73043f6cf6fc30439c05f826 (diff) | |
download | gcc-829d0168e6816e2b309bc75f4e23d28656ceed6f.zip gcc-829d0168e6816e2b309bc75f4e23d28656ceed6f.tar.gz gcc-829d0168e6816e2b309bc75f4e23d28656ceed6f.tar.bz2 |
re PR sanitizer/56990 (ICE: SIGFPE with -fsanitize=thread and empty struct)
PR sanitizer/56990
* tsan.c (instrument_expr): Don't instrument expression
in case its size is zero.
* gcc.dg/pr56990.c: New test.
From-SVN: r198147
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/ChangeLog | 6 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/pr56990.c | 10 | ||||
-rw-r--r-- | gcc/tsan.c | 3 |
4 files changed, 23 insertions, 1 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index ce29cce..f5b4635 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2013-04-22 Marek Polacek <polacek@redhat.com> + + PR sanitizer/56990 + * tsan.c (instrument_expr): Don't instrument expression + in case its size is zero. + 2013-04-22 Uros Bizjak <ubizjak@gmail.com> PR target/57032 diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 3917bbe..84a1fb9 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2013-04-22 Marek Polacek <polacek@redhat.com> + + PR sanitizer/56990 + * gcc.dg/pr56990.c: New test. + 2013-04-22 Vladimir Makarov <vmakarov@redhat.com> PR target/57018 diff --git a/gcc/testsuite/gcc.dg/pr56990.c b/gcc/testsuite/gcc.dg/pr56990.c new file mode 100644 index 0000000..ecb6ace --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr56990.c @@ -0,0 +1,10 @@ +/* PR sanitizer/56990 */ +/* { dg-do compile { target { x86_64-*-linux* && lp64 } } } */ +/* { dg-options "-fsanitize=thread" } */ + +struct S{}; + +void foo(struct S *p) +{ + *p = (struct S){}; +} @@ -131,7 +131,8 @@ instrument_expr (gimple_stmt_iterator gsi, tree expr, bool is_write) if (TREE_READONLY (base)) return false; - if (bitpos % (size * BITS_PER_UNIT) + if (size == 0 + || bitpos % (size * BITS_PER_UNIT) || bitsize != size * BITS_PER_UNIT) return false; |