diff options
| author | David Malcolm <dmalcolm@redhat.com> | 2022-10-24 16:41:09 -0400 |
|---|---|---|
| committer | David Malcolm <dmalcolm@redhat.com> | 2022-10-24 16:41:09 -0400 |
| commit | 687d11fd74e7de724d46d3e0c58eb012db93ec2b (patch) | |
| tree | 6d89e0b28e9baa2a7603822fedcc4bb3587472e6 /gcc | |
| parent | 2e8a0553918adc919f98ac5c0224fc6ce1fef68d (diff) | |
| download | gcc-687d11fd74e7de724d46d3e0c58eb012db93ec2b.zip gcc-687d11fd74e7de724d46d3e0c58eb012db93ec2b.tar.gz gcc-687d11fd74e7de724d46d3e0c58eb012db93ec2b.tar.bz2 | |
analyzer: fix ICE on va_copy [PR107349]
gcc/analyzer/ChangeLog:
PR analyzer/107349
* varargs.cc (get_va_copy_arg): Fix the non-pointer case.
gcc/testsuite/ChangeLog:
PR analyzer/107349
* gcc.dg/analyzer/stdarg-1-ms_abi.c (pr107349): New.
* gcc.dg/analyzer/stdarg-1-sysv_abi.c (pr107349): New.
* gcc.dg/analyzer/stdarg-1.c (pr107349): New.
Signed-off-by: David Malcolm <dmalcolm@redhat.com>
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/analyzer/varargs.cc | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/analyzer/stdarg-1-ms_abi.c | 6 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/analyzer/stdarg-1-sysv_abi.c | 6 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/analyzer/stdarg-1.c | 6 |
4 files changed, 20 insertions, 3 deletions
diff --git a/gcc/analyzer/varargs.cc b/gcc/analyzer/varargs.cc index 20c83db..e4dbad7 100644 --- a/gcc/analyzer/varargs.cc +++ b/gcc/analyzer/varargs.cc @@ -171,9 +171,8 @@ get_va_copy_arg (const region_model *model, const svalue *arg_sval = model->get_rvalue (arg, ctxt); if (const svalue *cast = arg_sval->maybe_undo_cast ()) arg_sval = cast; - /* Expect a POINTER_TYPE; does it point to an array type? */ - gcc_assert (TREE_CODE (TREE_TYPE (arg)) == POINTER_TYPE); - if (TREE_CODE (TREE_TYPE (TREE_TYPE (arg))) == ARRAY_TYPE) + if (TREE_CODE (TREE_TYPE (arg)) == POINTER_TYPE + && TREE_CODE (TREE_TYPE (TREE_TYPE (arg))) == ARRAY_TYPE) { /* va_list_arg_type_node is a pointer to a va_list; return *ARG_SVAL. */ diff --git a/gcc/testsuite/gcc.dg/analyzer/stdarg-1-ms_abi.c b/gcc/testsuite/gcc.dg/analyzer/stdarg-1-ms_abi.c index b0143a7..e55f10d 100644 --- a/gcc/testsuite/gcc.dg/analyzer/stdarg-1-ms_abi.c +++ b/gcc/testsuite/gcc.dg/analyzer/stdarg-1-ms_abi.c @@ -435,3 +435,9 @@ void test_va_arg_after_return (void) __analyzer_called_by_test_va_arg_after_return (42, 1066); i = __builtin_va_arg (global_ap, int); /* { dg-warning "dereferencing pointer 'global_ap' to within stale stack frame" } */ } + +void pr107349 (void) +{ + __builtin_ms_va_list x,y; + __builtin_ms_va_copy(x,y); /* { dg-warning "use of uninitialized value 'y'" } */ +} /* { dg-warning "missing call to 'va_end'" } */ diff --git a/gcc/testsuite/gcc.dg/analyzer/stdarg-1-sysv_abi.c b/gcc/testsuite/gcc.dg/analyzer/stdarg-1-sysv_abi.c index 1dc97ea3..fb49b35 100644 --- a/gcc/testsuite/gcc.dg/analyzer/stdarg-1-sysv_abi.c +++ b/gcc/testsuite/gcc.dg/analyzer/stdarg-1-sysv_abi.c @@ -435,3 +435,9 @@ void test_va_arg_after_return (void) __analyzer_called_by_test_va_arg_after_return (42, 1066); i = __builtin_va_arg (global_ap, int); /* { dg-warning "dereferencing pointer 'global_ap' to within stale stack frame" } */ } + +void pr107349 (void) +{ + __builtin_sysv_va_list x,y; + __builtin_sysv_va_copy(x,y); /* { dg-warning "use of uninitialized value 'y'" } */ +} /* { dg-warning "missing call to 'va_end'" } */ diff --git a/gcc/testsuite/gcc.dg/analyzer/stdarg-1.c b/gcc/testsuite/gcc.dg/analyzer/stdarg-1.c index f23d28c5..f2766a50 100644 --- a/gcc/testsuite/gcc.dg/analyzer/stdarg-1.c +++ b/gcc/testsuite/gcc.dg/analyzer/stdarg-1.c @@ -431,3 +431,9 @@ void test_va_arg_after_return (void) __analyzer_called_by_test_va_arg_after_return (42, 1066); i = __builtin_va_arg (global_ap, int); /* { dg-warning "dereferencing pointer 'global_ap' to within stale stack frame" } */ } + +void pr107349 (void) +{ + __builtin_va_list x,y; + __builtin_va_copy(x,y); /* { dg-warning "use of uninitialized value 'y'" } */ +} /* { dg-warning "missing call to 'va_end'" } */ |