diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2008-04-23 00:33:48 +0200 |
|---|---|---|
| committer | Jakub Jelinek <jakub@gcc.gnu.org> | 2008-04-23 00:33:48 +0200 |
| commit | 63cb92c1ee60811725c0f0b2512e7edcded5c7d4 (patch) | |
| tree | 6c47921f4947f086070ce6f76eeb80c06959ae83 /gcc | |
| parent | d7b5fa315012328dbd9b2fd6cb0e1c82942752c3 (diff) | |
| download | gcc-63cb92c1ee60811725c0f0b2512e7edcded5c7d4.zip gcc-63cb92c1ee60811725c0f0b2512e7edcded5c7d4.tar.gz gcc-63cb92c1ee60811725c0f0b2512e7edcded5c7d4.tar.bz2 | |
re PR rtl-optimization/36017 (Miscompilation of tail call sqrt)
PR rtl-optimization/36017
* builtins.c (expand_errno_check): Clear CALL_EXPR_TAILCALL before
expanding the library call.
* gcc.dg/pr36017.c: New test.
From-SVN: r134569
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ChangeLog | 6 | ||||
| -rw-r--r-- | gcc/builtins.c | 3 | ||||
| -rw-r--r-- | gcc/testsuite/ChangeLog | 5 | ||||
| -rw-r--r-- | gcc/testsuite/gcc.dg/pr36017.c | 29 |
4 files changed, 43 insertions, 0 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6132b7f..9a057f3 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2008-04-23 Jakub Jelinek <jakub@redhat.com> + + PR rtl-optimization/36017 + * builtins.c (expand_errno_check): Clear CALL_EXPR_TAILCALL before + expanding the library call. + 2008-04-22 Ian Lance Taylor <iant@google.com> * fold-const.c (pointer_may_wrap_p): Call int_size_in_bytes rather diff --git a/gcc/builtins.c b/gcc/builtins.c index d5c4f92..761a658 100644 --- a/gcc/builtins.c +++ b/gcc/builtins.c @@ -1804,6 +1804,9 @@ expand_errno_check (tree exp, rtx target) } #endif + /* Make sure the library call isn't expanded as a tail call. */ + CALL_EXPR_TAILCALL (exp) = 0; + /* We can't set errno=EDOM directly; let the library call do it. Pop the arguments right away in case the call gets deleted. */ NO_DEFER_POP; diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index cf689a4..435f081 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2008-04-23 Jakub Jelinek <jakub@redhat.com> + + PR rtl-optimization/36017 + * gcc.dg/pr36017.c: New test. + 2008-04-22 Jakub Jelinek <jakub@redhat.com> PR c++/35747 diff --git a/gcc/testsuite/gcc.dg/pr36017.c b/gcc/testsuite/gcc.dg/pr36017.c new file mode 100644 index 0000000..fa36927 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr36017.c @@ -0,0 +1,29 @@ +/* PR rtl-optimization/36017 */ +/* { dg-do run { target i?86-*-linux* x86_64-*-linux* } } */ +/* { dg-options "-O2 -lm" } */ + +extern double sqrt (double); +extern void abort (void); + +__attribute__((noinline)) double +foo (double a) +{ + double b, c, d = 0.7; + if (a <= d) + b = sqrt (d * a); + else + { + c = (1.0 - d) * (1.0 - a); + b = c > 0 ? 1.0 - sqrt (c) : 1.0; + } + return b; +} + +int +main (void) +{ + double c = foo (0.5); + if (c > 0.5917) + abort (); + return 0; +} |