aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorAndre Vieira <andre.simoesdiasvieira@arm.com>2015-10-22 05:12:32 +0000
committerRamana Radhakrishnan <ramana@gcc.gnu.org>2015-10-22 05:12:32 +0000
commit597bb9db4ac508410b42b53480451c7b521b8661 (patch)
tree01975beb47c87cde85fb64dbcc5a2ac7874f666a /gcc
parent1be3429587ab561a658cf1e90fcf00a7a51a645a (diff)
downloadgcc-597bb9db4ac508410b42b53480451c7b521b8661.zip
gcc-597bb9db4ac508410b42b53480451c7b521b8661.tar.gz
gcc-597bb9db4ac508410b42b53480451c7b521b8661.tar.bz2
[PATCH][ARM] Fix for testcase after r228661
This patch addresses PR-67948 by changing the xor-and.c test, initially written for a simplify-rtx pattern, to make it pass post r228661 (see https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00676.html). This test no longer triggered the simplify-rtx pattern it was written for prior to r228661, though other optimizations did lead to the same assembly the test checked for. The optimization added with r228661 matches the pattern used in the test and optimizes it to a better and still valid sequence. Being unable to easily change the test to trigger the original simplify-rtx pattern, I chose to change it to pass with the new produced assembly sequence. This is correct because the transformation is valid and it yields a more efficient pattern. However, as I pointed out before this test doesn't test the optimization it originally was intended for. Tested by running regression tests for armv6. Is this OK to commit? Thanks, Andre 2015-10-22 Andre Vieira <andre.simoesdiasvieira@arm.com> PR testsuite/67948 * gcc.target/arm/xor-and.c: Adjust test to check for eor instead of orr. From-SVN: r229161
Diffstat (limited to 'gcc')
-rw-r--r--gcc/testsuite/ChangeLog6
-rw-r--r--gcc/testsuite/gcc.target/arm/xor-and.c2
2 files changed, 7 insertions, 1 deletions
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index b952ac7..3bcbe96 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2015-10-22 Andre Vieira <andre.simoesdiasvieira@arm.com>
+
+ PR testsuite/67948
+ * gcc.target/arm/xor-and.c: Adjust test to check for eor
+ instead of orr.
+
2015-10-22 Jiong Wang <jiong.wang@arm.com>
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
diff --git a/gcc/testsuite/gcc.target/arm/xor-and.c b/gcc/testsuite/gcc.target/arm/xor-and.c
index 53dff85..3715530 100644
--- a/gcc/testsuite/gcc.target/arm/xor-and.c
+++ b/gcc/testsuite/gcc.target/arm/xor-and.c
@@ -10,6 +10,6 @@ unsigned short foo (unsigned short x)
return x;
}
-/* { dg-final { scan-assembler "orr" } } */
+/* { dg-final { scan-assembler "eor" } } */
/* { dg-final { scan-assembler-not "mvn" } } */
/* { dg-final { scan-assembler-not "uxth" } } */