diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2022-01-19 09:28:25 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2022-01-19 09:28:25 +0100 |
| commit | 53836c887a05db23ff3b9fc06f64e0ba78810ece (patch) | |
| tree | 796c3f091ff9a2ab19f69038c2cb7e9d09ec5edb /gcc | |
| parent | b834435c8fa4cb9424787fe3044a49fef7992de8 (diff) | |
| download | gcc-53836c887a05db23ff3b9fc06f64e0ba78810ece.zip gcc-53836c887a05db23ff3b9fc06f64e0ba78810ece.tar.gz gcc-53836c887a05db23ff3b9fc06f64e0ba78810ece.tar.bz2 | |
gimple-ssa-warn-access: Fix up asan_test.C -Wdangling-pointer regression [PR104103]
As reported in the PR or as I've seen since the weekend, asan_test.C fails
because of many warnings like:
gcc/testsuite/g++.dg/asan/asan_test.cc:1157:10: error: using a dangling pointer to an unnamed temporary [-Werror=dangling-pointer=]
gcc/testsuite/g++.dg/asan/asan_test.cc:1157:10: error: using a dangling pointer to an unnamed temporary [-Werror=dangling-pointer=]
gcc/testsuite/g++.dg/asan/asan_test.cc:1162:27: error: using a dangling pointer to an unnamed temporary [-Werror=dangling-pointer=]
...
(lots of them).
There are no dangling pointers though, the warning pass sees:
some_automatic_var ={v} {CLOBBER};
.ASAN_MARK (POISON, &some_automatic_var, 8);
and warns on that (both on user vars and on e.g. TARGET_EXPR temporaries).
There is nothing wrong on that, .ASAN_MARK is compiler instrumentation,
which doesn't even touch the variable in any way nor make it escaped.
What it instead does is change bytes in the shadow memory corresponding
to the variable to reflect that the variable is out of scope and make
sure that access to it would be diagnosed at runtime.
So, for all purposes of the -Wdangling-pointer and -Wuse-after-free
warnings, we should ignore this internal call.
2022-01-19 Jakub Jelinek <jakub@redhat.com>
PR middle-end/104103
* gimple-ssa-warn-access.cc (pass_waccess::check_call): Don't check
.ASAN_MARK calls.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/gimple-ssa-warn-access.cc | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/gcc/gimple-ssa-warn-access.cc b/gcc/gimple-ssa-warn-access.cc index f9508a1..c36cd5d 100644 --- a/gcc/gimple-ssa-warn-access.cc +++ b/gcc/gimple-ssa-warn-access.cc @@ -4234,6 +4234,11 @@ pass_waccess::check_call (gcall *stmt) if (gimple_call_builtin_p (stmt, BUILT_IN_NORMAL)) check_builtin (stmt); + /* .ASAN_MARK doesn't access any vars, only modifies shadow memory. */ + if (gimple_call_internal_p (stmt) + && gimple_call_internal_fn (stmt) == IFN_ASAN_MARK) + return; + if (!m_early_checks_p) if (tree callee = gimple_call_fndecl (stmt)) { |