diff options
| author | liuhongt <hongtao.liu@intel.com> | 2023-05-16 10:36:16 +0800 |
|---|---|---|
| committer | liuhongt <hongtao.liu@intel.com> | 2023-05-26 09:46:18 +0800 |
| commit | 4fb66b2329319e9b47e89200d613b6f741a114fc (patch) | |
| tree | 9aa8ffef007b2ff24347daf789bec304003df4fd /gcc | |
| parent | 5bd67d7abddca87198b11efccedee42f82e9f3a9 (diff) | |
| download | gcc-4fb66b2329319e9b47e89200d613b6f741a114fc.zip gcc-4fb66b2329319e9b47e89200d613b6f741a114fc.tar.gz gcc-4fb66b2329319e9b47e89200d613b6f741a114fc.tar.bz2 | |
Only use NO_REGS in cost calculation when !hard_regno_mode_ok for GENERAL_REGS and mode.
r14-172-g0368d169492017 replaces GENERAL_REGS with NO_REGS in cost
calculation when the preferred register class are not known yet.
It regressed powerpc PR109610 and PR109858, it looks too aggressive to use
NO_REGS when mode can be allocated with GENERAL_REGS.
The patch takes a step back, still use GENERAL_REGS when
hard_regno_mode_ok for mode and GENERAL_REGS, otherwise uses NO_REGS.
gcc/ChangeLog:
PR target/109610
PR target/109858
* ira-costs.cc (scan_one_insn): Only use NO_REGS in cost
calculation when !hard_regno_mode_ok for GENERAL_REGS and
mode, otherwise still use GENERAL_REGS.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/ira-costs.cc | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/gcc/ira-costs.cc b/gcc/ira-costs.cc index d2a801a..ae8304f 100644 --- a/gcc/ira-costs.cc +++ b/gcc/ira-costs.cc @@ -1572,12 +1572,16 @@ scan_one_insn (rtx_insn *insn) && (! ira_use_lra_p || ! pic_offset_table_rtx || ! contains_symbol_ref_p (XEXP (note, 0)))) { - /* Costs for NO_REGS are used in cost calculation on the - 1st pass when the preferred register classes are not - known yet. In this case we take the best scenario. */ - enum reg_class cl = NO_REGS; + enum reg_class cl = GENERAL_REGS; rtx reg = SET_DEST (set); int num = COST_INDEX (REGNO (reg)); + /* Costs for NO_REGS are used in cost calculation on the + 1st pass when the preferred register classes are not + known yet. In this case we take the best scenario when + mode can't be put into GENERAL_REGS. */ + if (!targetm.hard_regno_mode_ok (ira_class_hard_regs[cl][0], + GET_MODE (reg))) + cl = NO_REGS; COSTS (costs, num)->mem_cost -= ira_memory_move_cost[GET_MODE (reg)][cl][1] * frequency; |