diff options
author | Eric Botcazou <ebotcazou@gcc.gnu.org> | 2021-08-05 10:21:30 +0200 |
---|---|---|
committer | Eric Botcazou <ebotcazou@gcc.gnu.org> | 2021-08-05 10:24:50 +0200 |
commit | 4e3129b0caceec008a940aa5eada253cd0f0b3ec (patch) | |
tree | e69ff830c7b9b55901777ecd49a1dd3bab7c9021 /gcc | |
parent | ac8a2fbedf59eecda6d1c049952e10946ffc4a61 (diff) | |
download | gcc-4e3129b0caceec008a940aa5eada253cd0f0b3ec.zip gcc-4e3129b0caceec008a940aa5eada253cd0f0b3ec.tar.gz gcc-4e3129b0caceec008a940aa5eada253cd0f0b3ec.tar.bz2 |
Fix oversight in handling of reverse SSO in SRA pass
The scalar storage order does not apply to pointer and vector components.
gcc/
PR tree-optimization/101626
* tree-sra.c (propagate_subaccesses_from_rhs): Do not set the
reverse scalar storage order on a pointer or vector component.
gcc/testsuite/
* gcc.dg/sso-15.c: New test.
Diffstat (limited to 'gcc')
-rw-r--r-- | gcc/testsuite/gcc.dg/sso-15.c | 36 | ||||
-rw-r--r-- | gcc/tree-sra.c | 5 |
2 files changed, 40 insertions, 1 deletions
diff --git a/gcc/testsuite/gcc.dg/sso-15.c b/gcc/testsuite/gcc.dg/sso-15.c new file mode 100644 index 0000000..d8a711d --- /dev/null +++ b/gcc/testsuite/gcc.dg/sso-15.c @@ -0,0 +1,36 @@ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +#if __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__ +#define REV_ENDIANNESS __attribute__((scalar_storage_order("big-endian"))) +#else +#define REV_ENDIANNESS __attribute__((scalar_storage_order("little-endian"))) +#endif + +struct X { int *p; } REV_ENDIANNESS; + +struct X x; + +struct X __attribute__((noinline)) foo (int *p) +{ + struct X x; + x.p = p; + return x; +} + +void __attribute((noinline)) bar (void) +{ + *x.p = 1; +} + +extern void abort (void); + +int main (void) +{ + int i = 0; + x = foo(&i); + bar(); + if (i != 1) + abort (); + return 0; +} diff --git a/gcc/tree-sra.c b/gcc/tree-sra.c index c05d22f..3a9e14f 100644 --- a/gcc/tree-sra.c +++ b/gcc/tree-sra.c @@ -2790,7 +2790,10 @@ propagate_subaccesses_from_rhs (struct access *lacc, struct access *racc) { /* We are about to change the access type from aggregate to scalar, so we need to put the reverse flag onto the access, if any. */ - const bool reverse = TYPE_REVERSE_STORAGE_ORDER (lacc->type); + const bool reverse + = TYPE_REVERSE_STORAGE_ORDER (lacc->type) + && !POINTER_TYPE_P (racc->type) + && !VECTOR_TYPE_P (racc->type); tree t = lacc->base; lacc->type = racc->type; |