diff options
| author | Jakub Jelinek <jakub@redhat.com> | 2022-03-23 10:29:37 +0100 |
|---|---|---|
| committer | Jakub Jelinek <jakub@redhat.com> | 2022-03-23 10:29:37 +0100 |
| commit | 4a9e92164a547afcf8cd3fc593c7660238ad2d59 (patch) | |
| tree | 6903a24b602e7dac85bef0f590fffb7e89ed89a0 /gcc | |
| parent | 1002a7ace111d746249fdea71af9b8e039cea0eb (diff) | |
| download | gcc-4a9e92164a547afcf8cd3fc593c7660238ad2d59.zip gcc-4a9e92164a547afcf8cd3fc593c7660238ad2d59.tar.gz gcc-4a9e92164a547afcf8cd3fc593c7660238ad2d59.tar.bz2 | |
testsuite: Fix up sse2-v1ti-shift-3.c test [PR102986]
This test is dg-do run and invokes UB when these rotate functions
are called with 0 as second argument. There are some other tests
that do this but they are dg-do compile only and not even call those
functions at all, so it IMHO doesn't matter that they are only well
defined for [1,127] and not [0,127].
The following patch fixes it, we pattern recognize both forms as rotates
and we emit identical assembly.
2022-03-23 Jakub Jelinek <jakub@redhat.com>
PR target/102986
* gcc.target/i386/sse2-v1ti-shift-3.c (rotr_v1ti, rotl_v1ti, rotr_ti,
rotl_ti): Use -i&127 instead of 128-i to avoid UB on i == 0.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c b/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c index 8d5c122..b4739d3 100644 --- a/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c +++ b/gcc/testsuite/gcc.target/i386/sse2-v1ti-shift-3.c @@ -14,14 +14,14 @@ typedef __int128 ti; uv1ti ashl_v1ti(uv1ti x, unsigned int i) { return x << i; } uv1ti lshr_v1ti(uv1ti x, unsigned int i) { return x >> i; } sv1ti ashr_v1ti(sv1ti x, unsigned int i) { return x >> i; } -uv1ti rotr_v1ti(uv1ti x, unsigned int i) { return (x >> i) | (x << (128-i)); } -uv1ti rotl_v1ti(uv1ti x, unsigned int i) { return (x << i) | (x >> (128-i)); } +uv1ti rotr_v1ti(uv1ti x, unsigned int i) { return (x >> i) | (x << (-i&127)); } +uv1ti rotl_v1ti(uv1ti x, unsigned int i) { return (x << i) | (x >> (-i&127)); } uti ashl_ti(uti x, unsigned int i) { return x << i; } uti lshr_ti(uti x, unsigned int i) { return x >> i; } sti ashr_ti(sti x, unsigned int i) { return x >> i; } -uti rotr_ti(uti x, unsigned int i) { return (x >> i) | (x << (128-i)); } -uti rotl_ti(uti x, unsigned int i) { return (x << i) | (x >> (128-i)); } +uti rotr_ti(uti x, unsigned int i) { return (x >> i) | (x << (-i&127)); } +uti rotl_ti(uti x, unsigned int i) { return (x << i) | (x >> (-i&127)); } void test(ti x) { |