diff options
| author | Jason Merrill <jason@redhat.com> | 2021-09-15 09:30:10 -0400 |
|---|---|---|
| committer | Jason Merrill <jason@redhat.com> | 2021-09-15 11:30:37 -0400 |
| commit | 4320a4b717dcccddf230d0b944bfc5a7ae282508 (patch) | |
| tree | d34684de1d39d6468f123349b22f6f33bc74764f /gcc | |
| parent | adddfc85c07143f7c8097a90a83bfb15b8bd52e8 (diff) | |
| download | gcc-4320a4b717dcccddf230d0b944bfc5a7ae282508.zip gcc-4320a4b717dcccddf230d0b944bfc5a7ae282508.tar.gz gcc-4320a4b717dcccddf230d0b944bfc5a7ae282508.tar.bz2 | |
c++: don't warn about internal interference sizes
Most any compilation on ARM/AArch64 was warning because the default L1 cache
line size of 32B was smaller than the default
std::hardware_constructive_interference_size of 64B. This is mostly due to
inaccurate --param l1-cache-line-size, but it's not helpful to complain to a
user that didn't set the values.
gcc/cp/ChangeLog:
* decl.c (cxx_init_decl_processing): Only warn about odd
interference sizes if they were specified with --param.
Diffstat (limited to 'gcc')
| -rw-r--r-- | gcc/cp/decl.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c index 1a2925b..9ad9446 100644 --- a/gcc/cp/decl.c +++ b/gcc/cp/decl.c @@ -4756,7 +4756,7 @@ cxx_init_decl_processing (void) /* Check that the hardware interference sizes are at least alignof(max_align_t), as required by the standard. */ const int max_align = max_align_t_align () / BITS_PER_UNIT; - if (param_destruct_interfere_size) + if (global_options_set.x_param_destruct_interfere_size) { if (param_destruct_interfere_size < max_align) error ("%<--param destructive-interference-size=%d%> is less than " @@ -4767,11 +4767,13 @@ cxx_init_decl_processing (void) "is less than %<--param l1-cache-line-size=%d%>", param_destruct_interfere_size, param_l1_cache_line_size); } + else if (param_destruct_interfere_size) + /* Assume the internal value is OK. */; else if (param_l1_cache_line_size >= max_align) param_destruct_interfere_size = param_l1_cache_line_size; /* else leave it unset. */ - if (param_construct_interfere_size) + if (global_options_set.x_param_construct_interfere_size) { if (param_construct_interfere_size < max_align) error ("%<--param constructive-interference-size=%d%> is less than " @@ -4783,6 +4785,8 @@ cxx_init_decl_processing (void) "is greater than %<--param l1-cache-line-size=%d%>", param_construct_interfere_size, param_l1_cache_line_size); } + else if (param_construct_interfere_size) + /* Assume the internal value is OK. */; else if (param_l1_cache_line_size >= max_align) param_construct_interfere_size = param_l1_cache_line_size; } |