aboutsummaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorJason Merrill <jason@redhat.com>2010-12-03 11:56:37 -0500
committerJason Merrill <jason@gcc.gnu.org>2010-12-03 11:56:37 -0500
commit3ee353e956beac249a08337099ec885ae28bba04 (patch)
treef17f7173335da4fe762e344bfc510bf7e3d9d2a0 /gcc
parentfac680656629b130c140c11dca1272d0dbd6dd43 (diff)
downloadgcc-3ee353e956beac249a08337099ec885ae28bba04.zip
gcc-3ee353e956beac249a08337099ec885ae28bba04.tar.gz
gcc-3ee353e956beac249a08337099ec885ae28bba04.tar.bz2
re PR c++/46058 (gcc crashes with lvalue error on the following Code)
PR c++/46058 * tree.c (lvalue_kind) [SCOPE_REF]: Handle non-dependent case. From-SVN: r167435
Diffstat (limited to 'gcc')
-rw-r--r--gcc/cp/ChangeLog5
-rw-r--r--gcc/cp/tree.c7
-rw-r--r--gcc/testsuite/ChangeLog5
-rw-r--r--gcc/testsuite/g++.dg/template/scope4.C15
4 files changed, 30 insertions, 2 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index c24204e..edb50b5 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,8 @@
+2010-12-03 Jason Merrill <jason@redhat.com>
+
+ PR c++/46058
+ * tree.c (lvalue_kind) [SCOPE_REF]: Handle non-dependent case.
+
2010-12-03 Richard Guenther <rguenther@suse.de>
PR c/46745
diff --git a/gcc/cp/tree.c b/gcc/cp/tree.c
index 5538eea..1a77dc1 100644
--- a/gcc/cp/tree.c
+++ b/gcc/cp/tree.c
@@ -146,9 +146,12 @@ lvalue_kind (const_tree ref)
return clk_ordinary;
break;
- /* A currently unresolved scope ref. */
+ /* A scope ref in a template, left as SCOPE_REF to support later
+ access checking. */
case SCOPE_REF:
- gcc_unreachable ();
+ gcc_assert (!type_dependent_expression_p (CONST_CAST_TREE(ref)));
+ return lvalue_kind (TREE_OPERAND (ref, 1));
+
case MAX_EXPR:
case MIN_EXPR:
/* Disallow <? and >? as lvalues if either argument side-effects. */
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index c75ed75..e70cf6a 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2010-12-03 Jason Merrill <jason@redhat.com>
+
+ PR c++/46058
+ * g++.dg/template/scope4.C: New.
+
2010-12-03 Nathan Froyd <froydnj@codesourcery.com>
* gcc.target/arm/neon-offset-1.c: New test.
diff --git a/gcc/testsuite/g++.dg/template/scope4.C b/gcc/testsuite/g++.dg/template/scope4.C
new file mode 100644
index 0000000..a4ae074
--- /dev/null
+++ b/gcc/testsuite/g++.dg/template/scope4.C
@@ -0,0 +1,15 @@
+// PR c++/46058
+
+class StringLiterals {
+public:
+ static const char dec[];
+};
+
+template<class St, class Base, const char* name>
+class NoValueCommand : public Base {
+public:
+};
+
+template<class St, class Base>
+class DecBasic : public NoValueCommand<St,Base,StringLiterals::dec> {
+};